github-starred/pangolin
2
0
Fork 0
mirror of https://github.com/fosrl/pangolin.git synced 2026-07-16 14:47:04 -05:00
Code Issues 1.6k Packages Projects Releases 79 Wiki Activity

[GH-ISSUE #974] [Security] Hash users.server_admin.password in config #31775

New Issue
Closed
opened 2026-06-15 08:45:38 -05:00 by GiteaMirror · 1 comment
GiteaMirror commented 2026-06-15 08:45:38 -05:00
Owner
Copy Link

Originally created by @dystopiandev on GitHub (Jun 26, 2025).
Original GitHub issue: https://github.com/fosrl/pangolin/issues/974

users.server_admin.password is configured in plain text, but it would be better to have it as a hash. This would typically use bcrypt or some other algo if pangolin uses something different under the hood.

For backwards compatibility, maybe introduce users.server_admin.passwordHash? Also make this the default installer behavior, and document how to generate the hash (work factor, etc.) for manual installation.

Reason: Plain text passwords are readable by anyone who gains access to the config file. If the file is leaked or compromised, the attacker immediately knows the password. On the other hand, since bcrypt is a one-way hashing algo, the original password cannot be directly recovered from the hash.

Originally created by @dystopiandev on GitHub (Jun 26, 2025). Original GitHub issue: https://github.com/fosrl/pangolin/issues/974 `users.server_admin.password` is configured in plain text, but it would be better to have it as a hash. This would typically use bcrypt or some other algo if pangolin uses something different under the hood. For backwards compatibility, maybe introduce `users.server_admin.passwordHash`? Also make this the default installer behavior, and document how to generate the hash (work factor, etc.) for manual installation. Reason: Plain text passwords are readable by anyone who gains access to the config file. If the file is leaked or compromised, the attacker immediately knows the password. On the other hand, since bcrypt is a one-way hashing algo, the original password cannot be directly recovered from the hash.
GiteaMirror commented 2026-06-15 08:45:40 -05:00
Author
Owner
Copy Link

@oschwartz10612 commented on GitHub (Jun 27, 2025):

This will be resolved in the next release! Thanks for your issue!

<!-- gh-comment-id:3013028607 --> @oschwartz10612 commented on GitHub (Jun 27, 2025): This will be resolved in the next release! Thanks for your issue!
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
api
authentication
bug
config
dependencies
docker
documentation
enhancement
good first issue
help wanted
Improvement
Look Into
needs investigating
networking
new feature
non-critical bug
potential bug
pull-request
Mirrored from GitHub Pull Request
 question
reverse proxy
Security
stale
ui
wontfix
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/pangolin#31775
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?