github-starred/pangolin
2
0
Fork 0
mirror of https://github.com/fosrl/pangolin.git synced 2026-05-21 09:21:15 -05:00
Code Issues 856 Packages Projects Releases 74 Wiki Activity

[PR #2799] [MERGED] fix: use targetId as row identifier #3165

New Issue
Closed
opened 2026-04-16 09:50:49 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-16 09:50:49 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/fosrl/pangolin/pull/2799
Author: @LaurenceJJones
Created: 4/6/2026
Status: ✅ Merged
Merged: 4/11/2026
Merged by: @oschwartz10612

Base: dev ← Head: fix/proxy-target-deletion

📝 Commits (2)

  • 81eba50 fix: use targetId as row identifier
  • 7d3d5b2 use targetid also on proxy create as that also has same issue

📊 Changes

2 files changed (+2 additions, -0 deletions)

View changed files

📝 src/app/[orgId]/settings/resources/proxy/[niceId]/proxy/page.tsx (+1 -0)
📝 src/app/[orgId]/settings/resources/proxy/create/page.tsx (+1 -0)

📄 Description

fix: #2797

Community Contribution License Agreement

By creating this pull request, I grant the project maintainers an unlimited,
perpetual license to use, modify, and redistribute these contributions under any terms they
choose, including both the AGPLv3 and the Fossorial Commercial license terms. I
represent that I have the right to grant this license for all contributed content.

Description

When no getRowId function is provided it uses the index of the array for the tanstack table. This causes render issues if the data is nested and causes the problem outline in #2797.

How to test?

What is odd is that I could not reproduce the issue by creating three targets under the same site. To match the user's setup, I had to create three separate sites, since the dashboard uses the site itself as the data point being displayed.

From what I can see, the correct ID does appear to be deleted. The issue seems to be with the UI not updating properly afterward, likely because the data passed into the render is deeply nested and React is not re-rendering that state correctly.

closed #2798 because pointed to wrong branch 🤦🏻

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/fosrl/pangolin/pull/2799 **Author:** [@LaurenceJJones](https://github.com/LaurenceJJones) **Created:** 4/6/2026 **Status:** ✅ Merged **Merged:** 4/11/2026 **Merged by:** [@oschwartz10612](https://github.com/oschwartz10612) **Base:** `dev` ← **Head:** `fix/proxy-target-deletion` --- ### 📝 Commits (2) - [`81eba50`](https://github.com/fosrl/pangolin/commit/81eba50c9a3a6b5353e4baa58ba2216ccbd7401b) fix: use targetId as row identifier - [`7d3d5b2`](https://github.com/fosrl/pangolin/commit/7d3d5b2b22aafa4e0b6bc5584ec65ba405c80878) use targetid also on proxy create as that also has same issue ### 📊 Changes **2 files changed** (+2 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `src/app/[orgId]/settings/resources/proxy/[niceId]/proxy/page.tsx` (+1 -0) 📝 `src/app/[orgId]/settings/resources/proxy/create/page.tsx` (+1 -0) </details> ### 📄 Description fix: #2797 ## Community Contribution License Agreement By creating this pull request, I grant the project maintainers an unlimited, perpetual license to use, modify, and redistribute these contributions under any terms they choose, including both the AGPLv3 and the Fossorial Commercial license terms. I represent that I have the right to grant this license for all contributed content. ## Description When no `getRowId` function is provided it uses the index of the array for the tanstack table. This causes render issues if the data is nested and causes the problem outline in #2797. ## How to test? What is odd is that I could not reproduce the issue by creating three targets under the same site. To match the user's setup, I had to create three separate sites, since the dashboard uses the site itself as the data point being displayed. From what I can see, the correct ID does appear to be deleted. The issue seems to be with the UI not updating properly afterward, likely because the data passed into the render is deeply nested and React is not re-rendering that state correctly. closed #2798 because pointed to wrong branch 🤦🏻 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-16 09:50:49 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
api
authentication
bug
config
dependencies
docker
documentation
enhancement
good first issue
help wanted
Improvement
Look Into
needs investigating
networking
new feature
non-critical bug
potential bug
pull-request
Mirrored from GitHub Pull Request
 question
reverse proxy
Security
stale
ui
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/pangolin#3165
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?