github-starred/pangolin
2
0
Fork 0
mirror of https://github.com/fosrl/pangolin.git synced 2026-05-21 17:20:36 -05:00
Code Issues 899 Packages Projects Releases 74 Wiki Activity

[PR #2798] [CLOSED] fix: use targetId as row identifier #3164

New Issue
Closed
opened 2026-04-16 09:50:47 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-16 09:50:47 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/fosrl/pangolin/pull/2798
Author: @LaurenceJJones
Created: 4/6/2026
Status: ❌ Closed

Base: main ← Head: fix/proxy-target-deletion

📝 Commits (2)

  • 81eba50 fix: use targetId as row identifier
  • 7d3d5b2 use targetid also on proxy create as that also has same issue

📊 Changes

2 files changed (+2 additions, -0 deletions)

View changed files

📝 src/app/[orgId]/settings/resources/proxy/[niceId]/proxy/page.tsx (+1 -0)
📝 src/app/[orgId]/settings/resources/proxy/create/page.tsx (+1 -0)

📄 Description

fix: #2797

Community Contribution License Agreement

By creating this pull request, I grant the project maintainers an unlimited,
perpetual license to use, modify, and redistribute these contributions under any terms they
choose, including both the AGPLv3 and the Fossorial Commercial license terms. I
represent that I have the right to grant this license for all contributed content.

Description

When no getRowId function is provided it uses the index of the array for the tanstack table. This causes render issues and causes the problem outline in #2797.

How to test?

Well this is the odd thing, I couldnt replicate the issue by creating 3 targets from the same site, I had to create 3 sites as the user had to replicate the "site" being the data point shown in the dashboard. However, I think the correct ID is being deleted but since the data is deep nested react is not updating correctly on screen.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/fosrl/pangolin/pull/2798 **Author:** [@LaurenceJJones](https://github.com/LaurenceJJones) **Created:** 4/6/2026 **Status:** ❌ Closed **Base:** `main` ← **Head:** `fix/proxy-target-deletion` --- ### 📝 Commits (2) - [`81eba50`](https://github.com/fosrl/pangolin/commit/81eba50c9a3a6b5353e4baa58ba2216ccbd7401b) fix: use targetId as row identifier - [`7d3d5b2`](https://github.com/fosrl/pangolin/commit/7d3d5b2b22aafa4e0b6bc5584ec65ba405c80878) use targetid also on proxy create as that also has same issue ### 📊 Changes **2 files changed** (+2 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `src/app/[orgId]/settings/resources/proxy/[niceId]/proxy/page.tsx` (+1 -0) 📝 `src/app/[orgId]/settings/resources/proxy/create/page.tsx` (+1 -0) </details> ### 📄 Description fix: #2797 ## Community Contribution License Agreement By creating this pull request, I grant the project maintainers an unlimited, perpetual license to use, modify, and redistribute these contributions under any terms they choose, including both the AGPLv3 and the Fossorial Commercial license terms. I represent that I have the right to grant this license for all contributed content. ## Description When no `getRowId` function is provided it uses the index of the array for the tanstack table. This causes render issues and causes the problem outline in #2797. ## How to test? Well this is the odd thing, I couldnt replicate the issue by creating 3 targets from the same site, I had to create 3 sites as the user had to replicate the "site" being the data point shown in the dashboard. However, I think the correct ID is being deleted but since the data is deep nested react is not updating correctly on screen. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-16 09:50:47 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
api
authentication
bug
config
dependencies
docker
documentation
enhancement
good first issue
help wanted
Improvement
Look Into
needs investigating
networking
new feature
non-critical bug
potential bug
pull-request
Mirrored from GitHub Pull Request
 question
reverse proxy
Security
stale
ui
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/pangolin#3164
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?