github-starred/pangolin
2
0
Fork 0
mirror of https://github.com/fosrl/pangolin.git synced 2026-07-16 06:08:33 -05:00
Code Issues 1.6k Packages Projects Releases 79 Wiki Activity

[PR #2575] [CLOSED] fix: blueprint overwrites sso-users and sso-roles when empty arrays provided #30961

New Issue
Closed
opened 2026-06-13 11:26:11 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-06-13 11:26:11 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/fosrl/pangolin/pull/2575
Author: @Fizza-Mukhtar
Created: 3/1/2026
Status: ❌ Closed

Base: main ← Head: fix/blueprint-overwriting-sso-settings-2197

📝 Commits (1)

  • e607c39 fix: skip syncing empty sso-roles and sso-users arrays in blueprints

📊 Changes

1 file changed (+4 additions, -4 deletions)

View changed files

📝 server/lib/blueprints/proxyResources.ts (+4 -4)

📄 Description

Community Contribution License Agreement

By creating this pull request, I grant the project maintainers an unlimited,
perpetual license to use, modify, and redistribute these contributions under any terms they
choose, including both the AGPLv3 and the Fossorial Commercial license terms. I
represent that I have the right to grant this license for all contributed content.

Fixes #2197

Problem

When a blueprint defines sso-enabled and auto-login-idp but omits sso-users and sso-roles, the sync functions were being called with empty arrays, causing all existing users and roles to be cleared on every redeploy.

Fix

Added .length > 0 check before calling syncRoleResources and syncUserResources, consistent with how whitelist-users was already handled.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/fosrl/pangolin/pull/2575 **Author:** [@Fizza-Mukhtar](https://github.com/Fizza-Mukhtar) **Created:** 3/1/2026 **Status:** ❌ Closed **Base:** `main` ← **Head:** `fix/blueprint-overwriting-sso-settings-2197` --- ### 📝 Commits (1) - [`e607c39`](https://github.com/fosrl/pangolin/commit/e607c39b9811036d7018846fcef96b54f3f8ae5e) fix: skip syncing empty sso-roles and sso-users arrays in blueprints ### 📊 Changes **1 file changed** (+4 additions, -4 deletions) <details> <summary>View changed files</summary> 📝 `server/lib/blueprints/proxyResources.ts` (+4 -4) </details> ### 📄 Description ## Community Contribution License Agreement By creating this pull request, I grant the project maintainers an unlimited, perpetual license to use, modify, and redistribute these contributions under any terms they choose, including both the AGPLv3 and the Fossorial Commercial license terms. I represent that I have the right to grant this license for all contributed content. Fixes #2197 ## Problem When a blueprint defines `sso-enabled` and `auto-login-idp` but omits `sso-users` and `sso-roles`, the sync functions were being called with empty arrays, causing all existing users and roles to be cleared on every redeploy. ## Fix Added `.length > 0` check before calling `syncRoleResources` and `syncUserResources`, consistent with how `whitelist-users` was already handled. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-06-13 11:26:11 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
api
authentication
bug
config
dependencies
docker
documentation
enhancement
good first issue
help wanted
Improvement
Look Into
needs investigating
networking
new feature
non-critical bug
potential bug
pull-request
Mirrored from GitHub Pull Request
 question
reverse proxy
Security
stale
ui
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/pangolin#30961
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?