github-starred/pangolin
2
0
Fork 0
mirror of https://github.com/fosrl/pangolin.git synced 2026-05-08 05:39:49 -05:00
Code Issues 564 Packages Projects Releases 72 Wiki Activity

[PR #2616] [MERGED] fix(newt): missing hcStatus in hc config on reconnect #3061

New Issue
Closed
opened 2026-04-16 09:46:36 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-16 09:46:36 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/fosrl/pangolin/pull/2616
Author: @LaurenceJJones
Created: 3/7/2026
Status: ✅ Merged
Merged: 3/8/2026
Merged by: @oschwartz10612

Base: dev ← Head: fix/issue-240-hcStatus-missing

📝 Commits (1)

  • be609b5 Fix missing hcStatus field in health check config on reconnect

📊 Changes

1 file changed (+4 additions, -2 deletions)

View changed files

📝 server/routers/newt/buildConfiguration.ts (+4 -2)

📄 Description

Community Contribution License Agreement

By creating this pull request, I grant the project maintainers an unlimited,
perpetual license to use, modify, and redistribute these contributions under any terms they
choose, including both the AGPLv3 and the Fossorial Commercial license terms. I
represent that I have the right to grant this license for all contributed content.

Description

The buildTargetConfigurationForNewtClient function was not including the
hcStatus field when building health check targets for the newt/wg/connect
message. This caused custom expected response codes (e.g., 409) to revert
to the default 2xx range check after Pangolin server restart.

Added hcStatus to both the database select query and the returned health
check target object, matching the behavior in targets.ts addTargets.

fixes: https://github.com/fosrl/newt/issues/240

How to test?

Follow the steps defined in https://github.com/fosrl/newt/issues/240, after this change the expected code should function correctly.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/fosrl/pangolin/pull/2616 **Author:** [@LaurenceJJones](https://github.com/LaurenceJJones) **Created:** 3/7/2026 **Status:** ✅ Merged **Merged:** 3/8/2026 **Merged by:** [@oschwartz10612](https://github.com/oschwartz10612) **Base:** `dev` ← **Head:** `fix/issue-240-hcStatus-missing` --- ### 📝 Commits (1) - [`be609b5`](https://github.com/fosrl/pangolin/commit/be609b5000ec07dc857a268c39609ba0543b6594) Fix missing hcStatus field in health check config on reconnect ### 📊 Changes **1 file changed** (+4 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `server/routers/newt/buildConfiguration.ts` (+4 -2) </details> ### 📄 Description ## Community Contribution License Agreement By creating this pull request, I grant the project maintainers an unlimited, perpetual license to use, modify, and redistribute these contributions under any terms they choose, including both the AGPLv3 and the Fossorial Commercial license terms. I represent that I have the right to grant this license for all contributed content. ## Description The buildTargetConfigurationForNewtClient function was not including the hcStatus field when building health check targets for the newt/wg/connect message. This caused custom expected response codes (e.g., 409) to revert to the default 2xx range check after Pangolin server restart. Added hcStatus to both the database select query and the returned health check target object, matching the behavior in targets.ts addTargets. fixes: https://github.com/fosrl/newt/issues/240 ## How to test? Follow the steps defined in https://github.com/fosrl/newt/issues/240, after this change the expected code should function correctly. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-16 09:46:36 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
api
authentication
bug
config
dependencies
docker
documentation
enhancement
good first issue
help wanted
Improvement
Look Into
needs investigating
networking
new feature
non-critical bug
potential bug
pull-request
Mirrored from GitHub Pull Request
 question
reverse proxy
Security
stale
ui
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/pangolin#3061
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?