mirror of
https://github.com/fosrl/pangolin.git
synced 2026-07-16 06:08:33 -05:00
[GH-ISSUE #2990] Resource health checks have no name #30121
No Assignees
Notifications
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: github-starred/pangolin#30121
Reference in New Issue
Block a user
Delete Branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @gnullme on GitHub (May 4, 2026).
Original GitHub issue: https://github.com/fosrl/pangolin/issues/2990
Originally assigned to: @oschwartz10612 on GitHub.
Describe the Bug
The resource health checks do not have a name associated with them, and there seems to be no way to add one after creation.
When creating an alert rule for specific health checks, the selection list contains many empty entries as a result.
Environment
To Reproduce
Expected Behavior
A name is created automatically or can be set manually when creating the resource health check.
@AstralDestiny commented on GitHub (May 4, 2026):
Yeah only have one with a name not sure how it got that likely part of the newer checks.
So likely will need to allow post editing the name.
@AstralDestiny commented on GitHub (May 4, 2026):
If you create a resource then make the health check it does have a name but if it's an existing it won't get a name likely we should grant users the ability to set the name. if any
@gnullme commented on GitHub (May 4, 2026):
Thank you for looking into this.
Just for clarification, the health checks without a name were created in the proxy settings of the corresponding resource, not in the alerting menu. All of them existed before the introduction of alerting in Pangolin 1.18.
@AstralDestiny commented on GitHub (May 4, 2026):
Yeah if you make them in the public resources right now in newer versions it provides a name but you can't edit the name either way.
@gnullme commented on GitHub (May 4, 2026):
I can confirm that creating a new resource with a health check generates a name. So the issue is a missing naming migration for pre-1.18 resource health checks. However, as you mentioned, the ability to set a name would generally be a good idea.
@oschwartz10612 commented on GitHub (May 4, 2026):
Unfortunately this effects people who used the original 1.18.0 migration before it was patched in the 1.18.1 version. I added a migration to the 1.18.3 version that will come out earlier this week to help fix this and the mismatch between the health check status and resource status issue.