mirror of
https://github.com/fosrl/pangolin.git
synced 2026-07-16 14:47:04 -05:00
[GH-ISSUE #2736] Health checks are still running when Ressource is disabled #30058
Reference in New Issue
Block a user
Delete Branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @maieredv-manuel on GitHub (Mar 29, 2026).
Original GitHub issue: https://github.com/fosrl/pangolin/issues/2736
Describe the Bug
Health checks are still running when Ressource is disabled
Environment
To Reproduce
Disable an Ressource with enabled Healthchecks and look in the logs of newt.
Expected Behavior
If i disable a Ressource also the Healthchecks sould be disabled
@oschwartz10612 commented on GitHub (Mar 29, 2026):
Yeah we should send a message to add and remove the healthchecks when enabled and disabled to the newt downstream.
@Adarsh-Raj-Jaiswal commented on GitHub (Mar 30, 2026):
Hi! I'd love to work on this issue. I plan to locate the resource update router and dispatch a WebSocket message to the Newt client to add/remove health checks based on the enabled state. Let me know if you have any architectural pointers!
@oschwartz10612 commented on GitHub (Mar 30, 2026):
Sure @Adarsh-Raj-Jaiswal give it a shot. I will review the PR when you are ready.
@Adarsh-Raj-Jaiswal commented on GitHub (Apr 6, 2026):
Since I have windows so I was facing some issues in setting up pangolin. But now it's done and I'm able to proceed on this. Just wanted to update about this :)
@oschwartz10612 commented on GitHub (May 1, 2026):
This was fixed in the 1.18.1 release!
@LeonvanHeerden commented on GitHub (Jun 13, 2026):
I am moving some resources to run through the new Newt 1.13.0. The not all the endpoints are active at the moment. Using Pangolin 1.19.1
Enabled health checks and found that the target is offline. I then disable the resource as well as HTTPS Target access. the Health-check on the Newt connection continues to run and fail.
I also have to also disabled the health check and I see newt is still continuing the healthcheck.
I restarted the Newt container to see if that stops the checks and it looks like that worked. So maybe there is no instruction to newt to stop checking the health?