[PR #3219] [MERGED] feat: make clear filter buttons more consistent accross tables #26866

Closed
opened 2026-06-08 20:19:34 -05:00 by GiteaMirror · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/fosrl/pangolin/pull/3219
Author: @Fredkiss3
Created: 6/4/2026
Status: Merged
Merged: 6/8/2026
Merged by: @miloschwartz

Base: devHead: refactor/standardize-clear-buttons


📝 Commits (10+)

  • 9cff5f6 🚧 wip: site label column filter standardized
  • d485a09 ♻️ use site label filter column
  • feb8045 ♻️ refactor
  • db014e3 ♻️ use the same clear filter text for clearing filters in the column filter buttons
  • c86026c ♻️ refactor
  • 33fdc9a 🚧 wip: column filter button
  • eb03fb7 ♻️ standardize http request log data-tables
  • a4548fd 💄 Break all text
  • 95ce91d Merge branch 'dev' into refactor/standardize-clear-buttons
  • a994f8f 💄 Column filter buttons for log tables

📊 Changes

14 files changed (+355 additions, -363 deletions)

View changed files

📝 messages/en-US.json (+1 -0)
📝 src/app/[orgId]/settings/logs/access/page.tsx (+29 -29)
📝 src/app/[orgId]/settings/logs/action/page.tsx (+13 -17)
📝 src/app/[orgId]/settings/logs/connection/page.tsx (+29 -35)
📝 src/app/[orgId]/settings/logs/request/page.tsx (+46 -54)
📝 src/components/ColumnFilterButton.tsx (+5 -3)
📝 src/components/ColumnMultiFilterButton.tsx (+2 -1)
📝 src/components/LabelColumnFilterButton.tsx (+1 -1)
📝 src/components/LogDataTable.tsx (+1 -1)
📝 src/components/PrivateResourcesTable.tsx (+43 -117)
📝 src/components/PublicResourcesTable.tsx (+22 -101)
src/components/SitesColumnFilterButton.tsx (+160 -0)
📝 src/components/multi-site-selector.tsx (+0 -1)
📝 src/components/site-selector.tsx (+3 -3)

📄 Description

Community Contribution License Agreement

By creating this pull request, I grant the project maintainers an unlimited,
perpetual license to use, modify, and redistribute these contributions under any terms they
choose, including both the AGPLv3 and the Fossorial Commercial license terms. I
represent that I have the right to grant this license for all contributed content.

Summary

  • Made the clear buttons to be clear filters
  • Made it so that the log data tables use ColumnFilterButton component instead of the filter button to the right of the column name for all logs tables
  • Also added padding to the columns to make it easier to separate the columns

Screenshots

Name Screenshot
Http request logs pages
Clear button on sites filter button image

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/fosrl/pangolin/pull/3219 **Author:** [@Fredkiss3](https://github.com/Fredkiss3) **Created:** 6/4/2026 **Status:** ✅ Merged **Merged:** 6/8/2026 **Merged by:** [@miloschwartz](https://github.com/miloschwartz) **Base:** `dev` ← **Head:** `refactor/standardize-clear-buttons` --- ### 📝 Commits (10+) - [`9cff5f6`](https://github.com/fosrl/pangolin/commit/9cff5f66b189a3db772d9d8348f3435de2f28822) 🚧 wip: site label column filter standardized - [`d485a09`](https://github.com/fosrl/pangolin/commit/d485a09318cfcf595d2ff2689393daa771666e25) ♻️ use site label filter column - [`feb8045`](https://github.com/fosrl/pangolin/commit/feb8045643f06c6f8d5f23e26df78f64833c09fc) ♻️ refactor - [`db014e3`](https://github.com/fosrl/pangolin/commit/db014e3446146c4db474d61242e5075dae649bcf) ♻️ use the same `clear filter` text for clearing filters in the column filter buttons - [`c86026c`](https://github.com/fosrl/pangolin/commit/c86026c9412e42631d59ad6c9426102e3a4cf191) ♻️ refactor - [`33fdc9a`](https://github.com/fosrl/pangolin/commit/33fdc9a94f2a81c2f7de57b33c3c2ad5d529146b) 🚧 wip: column filter button - [`eb03fb7`](https://github.com/fosrl/pangolin/commit/eb03fb706071a039c4589f82daa72564998b5610) ♻️ standardize http request log data-tables - [`a4548fd`](https://github.com/fosrl/pangolin/commit/a4548fd874ae97a522aa348ce924cdf61fc58338) 💄 Break all text - [`95ce91d`](https://github.com/fosrl/pangolin/commit/95ce91d94bcb294498db270bf309227a090338d1) Merge branch 'dev' into refactor/standardize-clear-buttons - [`a994f8f`](https://github.com/fosrl/pangolin/commit/a994f8ff07f0e2586e8377cf7db0912aa93fe878) 💄 Column filter buttons for log tables ### 📊 Changes **14 files changed** (+355 additions, -363 deletions) <details> <summary>View changed files</summary> 📝 `messages/en-US.json` (+1 -0) 📝 `src/app/[orgId]/settings/logs/access/page.tsx` (+29 -29) 📝 `src/app/[orgId]/settings/logs/action/page.tsx` (+13 -17) 📝 `src/app/[orgId]/settings/logs/connection/page.tsx` (+29 -35) 📝 `src/app/[orgId]/settings/logs/request/page.tsx` (+46 -54) 📝 `src/components/ColumnFilterButton.tsx` (+5 -3) 📝 `src/components/ColumnMultiFilterButton.tsx` (+2 -1) 📝 `src/components/LabelColumnFilterButton.tsx` (+1 -1) 📝 `src/components/LogDataTable.tsx` (+1 -1) 📝 `src/components/PrivateResourcesTable.tsx` (+43 -117) 📝 `src/components/PublicResourcesTable.tsx` (+22 -101) ➕ `src/components/SitesColumnFilterButton.tsx` (+160 -0) 📝 `src/components/multi-site-selector.tsx` (+0 -1) 📝 `src/components/site-selector.tsx` (+3 -3) </details> ### 📄 Description ## Community Contribution License Agreement By creating this pull request, I grant the project maintainers an unlimited, perpetual license to use, modify, and redistribute these contributions under any terms they choose, including both the AGPLv3 and the Fossorial Commercial license terms. I represent that I have the right to grant this license for all contributed content. ## Summary - Made the clear buttons to be `clear filters` - Made it so that the log data tables use `ColumnFilterButton` component instead of the filter button to the right of the column name for all logs tables - Also added padding to the columns to make it easier to separate the columns ## Screenshots | Name | Screenshot | |---|---| | Http request logs pages | <video src="https://github.com/user-attachments/assets/aff6e37e-15e3-42a2-8e9d-e615787bbf3c"></video> | | Clear button on sites filter button | <img width="806" height="750" alt="image" src="https://github.com/user-attachments/assets/49ab7da8-b778-4c6b-9fa3-b03999f79835" /> | --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-06-08 20:19:34 -05:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/pangolin#26866