github-starred/pangolin
2
0
Fork 0
mirror of https://github.com/fosrl/pangolin.git synced 2026-07-15 21:31:24 -05:00
Code Issues 1.6k Packages Projects Releases 79 Wiki Activity

[PR #3199] fix: blueprint apply fails with UNIQUE constraint on certificates.dom… #26850

New Issue
Open
opened 2026-06-08 20:18:45 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-06-08 20:18:45 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/fosrl/pangolin/pull/3199
Author: @Adityakk9031
Created: 6/1/2026
Status: 🔄 Open

Base: dev ← Head: #2937

📝 Commits (1)

  • 92f9c11 fix: blueprint apply fails with UNIQUE constraint on certificates.domain (#2937)

📊 Changes

1 file changed (+13 additions, -18 deletions)

View changed files

📝 server/private/routers/certificates/createCertificate.ts (+13 -18)

📄 Description

Problem
Applying a blueprint with a resource under a wildcard subdomain (e.g. *.web.domain.com) fails with:

SqliteError: UNIQUE constraint failed: certificates.domain

Resources under a top-level wildcard (e.g. *.domain.com) succeed. Only deeper wildcard domains are affected.

Root Cause
createCertificate checked for an existing cert by filtering on both domainId and domain. However, certificates.domain has a global unique constraint (not per-domainId).

When getDomainId() resolves a full-domain to a parent domain (e.g. domain.com → domainId = "domain1") instead of the more specific web.domain.com domain, the domainId used in the check doesn't match the existing cert's stored domainId. The check silently misses the cert and falls through to INSERT — which then crashes on the global unique constraint.

Fix
Removed domainId from the existing-cert WHERE clause. Since certificates.domain is globally unique, checking by domain value alone is correct and sufficient.
Added .onConflictDoNothing() to the INSERT as a safety net for any remaining edge cases.
Files Changed
server/private/routers/certificates/createCertificate.ts
Fixes
Closes #2937

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/fosrl/pangolin/pull/3199 **Author:** [@Adityakk9031](https://github.com/Adityakk9031) **Created:** 6/1/2026 **Status:** 🔄 Open **Base:** `dev` ← **Head:** `#2937` --- ### 📝 Commits (1) - [`92f9c11`](https://github.com/fosrl/pangolin/commit/92f9c113c0b3867de0d2f2bde46eb19f9c580a4f) fix: blueprint apply fails with UNIQUE constraint on certificates.domain (#2937) ### 📊 Changes **1 file changed** (+13 additions, -18 deletions) <details> <summary>View changed files</summary> 📝 `server/private/routers/certificates/createCertificate.ts` (+13 -18) </details> ### 📄 Description Problem Applying a blueprint with a resource under a wildcard subdomain (e.g. *.web.domain.com) fails with: SqliteError: UNIQUE constraint failed: certificates.domain Resources under a top-level wildcard (e.g. *.domain.com) succeed. Only deeper wildcard domains are affected. Root Cause createCertificate checked for an existing cert by filtering on both domainId and domain. However, certificates.domain has a global unique constraint (not per-domainId). When getDomainId() resolves a full-domain to a parent domain (e.g. domain.com → domainId = "domain1") instead of the more specific web.domain.com domain, the domainId used in the check doesn't match the existing cert's stored domainId. The check silently misses the cert and falls through to INSERT — which then crashes on the global unique constraint. Fix Removed domainId from the existing-cert WHERE clause. Since certificates.domain is globally unique, checking by domain value alone is correct and sufficient. Added .onConflictDoNothing() to the INSERT as a safety net for any remaining edge cases. Files Changed server/private/routers/certificates/createCertificate.ts Fixes Closes #2937 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-06-08 20:18:45 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
api
authentication
bug
config
dependencies
docker
documentation
enhancement
good first issue
help wanted
Improvement
Look Into
needs investigating
networking
new feature
non-critical bug
potential bug
pull-request
Mirrored from GitHub Pull Request
 question
reverse proxy
Security
stale
ui
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/pangolin#26850
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?