[PR #1240] [MERGED] Support Unicode Domain Input and Display #2484

Closed
opened 2026-04-16 09:25:59 -05:00 by GiteaMirror · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/fosrl/pangolin/pull/1240
Author: @Pallavikumarimdb
Created: 8/8/2025
Status: Merged
Merged: 9/1/2025
Merged by: @oschwartz10612

Base: devHead: Fix/allow-unicode-domain-name


📝 Commits (3)

  • 78f464f Show/allow unicode domain name
  • 8a62f12 fix lint
  • 7d5961c Support unicode with subdomain sanitized

📊 Changes

24 files changed (+341 additions, -184 deletions)

View changed files

📝 messages/bg-BG.json (+3 -1)
📝 messages/cs-CZ.json (+3 -1)
📝 messages/de-DE.json (+3 -1)
📝 messages/en-US.json (+3 -1)
📝 messages/es-ES.json (+3 -1)
📝 messages/fr-FR.json (+3 -1)
📝 messages/it-IT.json (+3 -1)
📝 messages/ko-KR.json (+3 -1)
📝 messages/nl-NL.json (+3 -1)
📝 messages/pl-PL.json (+3 -1)
📝 messages/pt-PT.json (+3 -1)
📝 messages/ru-RU.json (+3 -1)
📝 messages/tr-TR.json (+3 -1)
📝 messages/zh-CN.json (+3 -1)
📝 src/app/[orgId]/settings/domains/CreateDomainForm.tsx (+169 -78)
📝 src/app/[orgId]/settings/domains/page.tsx (+8 -1)
📝 src/app/[orgId]/settings/resources/[resourceId]/CustomDomainInput.tsx (+2 -1)
📝 src/app/[orgId]/settings/resources/[resourceId]/ResourceInfoBox.tsx (+9 -5)
📝 src/app/[orgId]/settings/resources/[resourceId]/general/page.tsx (+13 -8)
📝 src/app/[orgId]/settings/resources/create/page.tsx (+8 -2)

...and 4 more files

📄 Description

Community Contribution License Agreement

By creating this pull request, I grant the project maintainers an unlimited,
perpetual license to use, modify, and redistribute these contributions under any terms they
choose, including both the AGPLv3 and the Fossorial Commercial license terms. I
represent that I have the right to grant this license for all contributed content.

Description

This PR adds support for Unicode domain names in the frontend interface while maintaining backend compatibility with Punycode.

Changes Made:

  • Accepts Unicode domain names (e.g., café.com, 点看.com) in the domain input field.
  • Automatically converts Unicode domains to Punycode before sending them to the backend using the built-in punycode module.
  • Converts domains fetched from the backend (in Punycode) to Unicode for display in the UI.
  • Improves user experience by allowing users to input and view domain names in their original, recognizable format.

How to test?

  1. Add a new domain with Unicode characters (e.g., café.com, 点看.com, straße.de) via the domain input form.

    • The domain should be accepted without any error.
    • The form should auto-convert the domain to Punycode in the background before submission.
  2. Check the domain listing after adding.

    • The newly added domain should appear in the list in Unicode form (e.g., café.com), even though it’s stored as Punycode.

Fixes: #1162


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/fosrl/pangolin/pull/1240 **Author:** [@Pallavikumarimdb](https://github.com/Pallavikumarimdb) **Created:** 8/8/2025 **Status:** ✅ Merged **Merged:** 9/1/2025 **Merged by:** [@oschwartz10612](https://github.com/oschwartz10612) **Base:** `dev` ← **Head:** `Fix/allow-unicode-domain-name` --- ### 📝 Commits (3) - [`78f464f`](https://github.com/fosrl/pangolin/commit/78f464f6ca43ce4eaa61213e735af6f420e938a2) Show/allow unicode domain name - [`8a62f12`](https://github.com/fosrl/pangolin/commit/8a62f12e8b960637ec25fc125e1e4d08bf8c7c49) fix lint - [`7d5961c`](https://github.com/fosrl/pangolin/commit/7d5961cf5036ec35a21db7181878949062c28d58) Support unicode with subdomain sanitized ### 📊 Changes **24 files changed** (+341 additions, -184 deletions) <details> <summary>View changed files</summary> 📝 `messages/bg-BG.json` (+3 -1) 📝 `messages/cs-CZ.json` (+3 -1) 📝 `messages/de-DE.json` (+3 -1) 📝 `messages/en-US.json` (+3 -1) 📝 `messages/es-ES.json` (+3 -1) 📝 `messages/fr-FR.json` (+3 -1) 📝 `messages/it-IT.json` (+3 -1) 📝 `messages/ko-KR.json` (+3 -1) 📝 `messages/nl-NL.json` (+3 -1) 📝 `messages/pl-PL.json` (+3 -1) 📝 `messages/pt-PT.json` (+3 -1) 📝 `messages/ru-RU.json` (+3 -1) 📝 `messages/tr-TR.json` (+3 -1) 📝 `messages/zh-CN.json` (+3 -1) 📝 `src/app/[orgId]/settings/domains/CreateDomainForm.tsx` (+169 -78) 📝 `src/app/[orgId]/settings/domains/page.tsx` (+8 -1) 📝 `src/app/[orgId]/settings/resources/[resourceId]/CustomDomainInput.tsx` (+2 -1) 📝 `src/app/[orgId]/settings/resources/[resourceId]/ResourceInfoBox.tsx` (+9 -5) 📝 `src/app/[orgId]/settings/resources/[resourceId]/general/page.tsx` (+13 -8) 📝 `src/app/[orgId]/settings/resources/create/page.tsx` (+8 -2) _...and 4 more files_ </details> ### 📄 Description ## Community Contribution License Agreement By creating this pull request, I grant the project maintainers an unlimited, perpetual license to use, modify, and redistribute these contributions under any terms they choose, including both the AGPLv3 and the Fossorial Commercial license terms. I represent that I have the right to grant this license for all contributed content. ## Description This PR adds support for Unicode domain names in the frontend interface while maintaining backend compatibility with Punycode. #### ✅ Changes Made: * Accepts Unicode domain names (e.g., `café.com`, `点看.com`) in the domain input field. * Automatically converts Unicode domains to **Punycode** before sending them to the backend using the built-in `punycode` module. * Converts domains fetched from the backend (in Punycode) to **Unicode** for display in the UI. * Improves user experience by allowing users to input and view domain names in their original, recognizable format. ## How to test? 1. **Add a new domain with Unicode characters** (e.g., `café.com`, `点看.com`, `straße.de`) via the domain input form. * The domain should be accepted without any error. * The form should auto-convert the domain to Punycode in the background before submission. 2. **Check the domain listing after adding.** * The newly added domain should appear in the list **in Unicode form** (e.g., `café.com`), even though it’s stored as Punycode. Fixes: #1162 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-16 09:25:59 -05:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/pangolin#2484