github-starred/pangolin
2
0
Fork 0
mirror of https://github.com/fosrl/pangolin.git synced 2026-07-16 14:47:04 -05:00
Code Issues 1.6k Packages Projects Releases 79 Wiki Activity

[PR #876] [MERGED] Add Typescript specific linting & define files in eslint #21592

New Issue
Closed
opened 2026-06-02 04:03:16 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-06-02 04:03:16 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/fosrl/pangolin/pull/876
Author: @thijsvanloef
Created: 6/9/2025
Status: ✅ Merged
Merged: 6/9/2025
Merged by: @oschwartz10612

Base: dev ← Head: fix/define-files-in-eslint

📝 Commits (5)

  • 3b10453 define files in eslint
  • 2047aa3 add typescript specific linting
  • a575bac add typescript eslint
  • c7018e9 Merge branch 'dev' into fix/define-files-in-eslint
  • 3d59556 readd accidentally removed line

📊 Changes

3 files changed (+84 additions, -56 deletions)

View changed files

📝 eslint.config.js (+6 -3)
📝 package-lock.json (+77 -53)
📝 package.json (+1 -0)

📄 Description

Community Contribution License Agreement

By creating this pull request, I grant the project maintainers an unlimited,
perpetual license to use, modify, and redistribute these contributions under any terms they
choose, including both the AGPLv3 and the Fossorial Commercial license terms. I
represent that I have the right to grant this license for all contributed content.

Description

I was thinking about adding a eslinter to the github actions as well, however came across an error the existing eslint.config.js.
As there are no files defined in the eslint.config.js the linter will not actually run any of its checks on the typescript files.
Further, the linter was not checking typescript specific recommended rules.

If wanted, I can also add automated linting via github actions that run on every PR.

Feel free to close this PR if this is not needed/wanted.

How to test?

  1. Clone the repository
  2. Run npx eslint
  3. See that there are linting errors found:
    image

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/fosrl/pangolin/pull/876 **Author:** [@thijsvanloef](https://github.com/thijsvanloef) **Created:** 6/9/2025 **Status:** ✅ Merged **Merged:** 6/9/2025 **Merged by:** [@oschwartz10612](https://github.com/oschwartz10612) **Base:** `dev` ← **Head:** `fix/define-files-in-eslint` --- ### 📝 Commits (5) - [`3b10453`](https://github.com/fosrl/pangolin/commit/3b10453af3afc5f91371f06a5aafc27156f9d961) define files in eslint - [`2047aa3`](https://github.com/fosrl/pangolin/commit/2047aa30e13daed36ac0db13b9ccbe6e654adb42) add typescript specific linting - [`a575bac`](https://github.com/fosrl/pangolin/commit/a575bace39f475cf546330de067fff1f29025f89) add typescript eslint - [`c7018e9`](https://github.com/fosrl/pangolin/commit/c7018e92b09396b1fcad3a88e45809d3a1a93c6c) Merge branch 'dev' into fix/define-files-in-eslint - [`3d59556`](https://github.com/fosrl/pangolin/commit/3d59556bcd4d98f9c60e84228689d95ab100aa8f) readd accidentally removed line ### 📊 Changes **3 files changed** (+84 additions, -56 deletions) <details> <summary>View changed files</summary> 📝 `eslint.config.js` (+6 -3) 📝 `package-lock.json` (+77 -53) 📝 `package.json` (+1 -0) </details> ### 📄 Description ## Community Contribution License Agreement By creating this pull request, I grant the project maintainers an unlimited, perpetual license to use, modify, and redistribute these contributions under any terms they choose, including both the AGPLv3 and the Fossorial Commercial license terms. I represent that I have the right to grant this license for all contributed content. ## Description I was thinking about adding a eslinter to the github actions as well, however came across an error the existing `eslint.config.js`. As there are no files defined in the `eslint.config.js` the linter will not actually run any of its checks on the typescript files. Further, the linter was not checking typescript specific recommended rules. If wanted, I can also add automated linting via github actions that run on every PR. Feel free to close this PR if this is not needed/wanted. ## How to test? 1. Clone the repository 2. Run `npx eslint` 3. See that there are linting errors found: ![image](https://github.com/user-attachments/assets/45069c44-83ef-4016-bc2c-3adad67b1310) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-06-02 04:03:16 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
api
authentication
bug
config
dependencies
docker
documentation
enhancement
good first issue
help wanted
Improvement
Look Into
needs investigating
networking
new feature
non-critical bug
potential bug
pull-request
Mirrored from GitHub Pull Request
 question
reverse proxy
Security
stale
ui
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/pangolin#21592
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?