github-starred/pangolin
2
0
Fork 0
mirror of https://github.com/fosrl/pangolin.git synced 2026-07-16 14:47:04 -05:00
Code Issues 1.6k Packages Projects Releases 79 Wiki Activity

[PR #2977] [MERGED] fix(newt): update Helm install credentials and client flag handling #21448

New Issue
Closed
opened 2026-05-29 02:51:44 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-05-29 02:51:44 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/fosrl/pangolin/pull/2977
Author: @marcschaeferger
Created: 5/3/2026
Status: ✅ Merged
Merged: 5/4/2026
Merged by: @oschwartz10612

Base: dev ← Head: newt-install-commands

📝 Commits (1)

  • 1772ac2 fix(newt): update Helm install credentials and client flag handling

📊 Changes

1 file changed (+16 additions, -7 deletions)

View changed files

📝 src/components/newt-install-commands.tsx (+16 -7)

📄 Description

Community Contribution License Agreement

By creating this pull request, I grant the project maintainers an unlimited,
perpetual license to use, modify, and redistribute these contributions under any terms they
choose, including both the AGPLv3 and the Fossorial Commercial license terms. I
represent that I have the right to grant this license for all contributed content.

Description (Copilot generated)

This pull request updates the Helm installation instructions for Newt to improve Kubernetes compatibility and secret management. The changes focus on creating required namespaces and secrets using kubectl before running the Helm command, and updating how authentication and client acceptance options are handled.

Helm installation improvements:

  • Added a kubectl create namespace command to ensure the newt namespace exists before installation.
  • Added a kubectl create secret generic command to create the newt-main-tunnel-auth secret with required credentials, replacing direct value injection via Helm.
  • Updated the Helm install command to use helm upgrade --install with -n newt and reference the pre-created secret via --set-string newtInstances[0].auth.existingSecretName="newt-main-tunnel-auth".
  • Modified the handling of the acceptClients option: now appends --set newtInstances[0].acceptClients=true to the Helm command only if clients are accepted. [1] [2]

How to test?

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/fosrl/pangolin/pull/2977 **Author:** [@marcschaeferger](https://github.com/marcschaeferger) **Created:** 5/3/2026 **Status:** ✅ Merged **Merged:** 5/4/2026 **Merged by:** [@oschwartz10612](https://github.com/oschwartz10612) **Base:** `dev` ← **Head:** `newt-install-commands` --- ### 📝 Commits (1) - [`1772ac2`](https://github.com/fosrl/pangolin/commit/1772ac220fac91398659a4dce9b9846896b67eef) fix(newt): update Helm install credentials and client flag handling ### 📊 Changes **1 file changed** (+16 additions, -7 deletions) <details> <summary>View changed files</summary> 📝 `src/components/newt-install-commands.tsx` (+16 -7) </details> ### 📄 Description ## Community Contribution License Agreement By creating this pull request, I grant the project maintainers an unlimited, perpetual license to use, modify, and redistribute these contributions under any terms they choose, including both the AGPLv3 and the Fossorial Commercial license terms. I represent that I have the right to grant this license for all contributed content. ## Description (Copilot generated) This pull request updates the Helm installation instructions for Newt to improve Kubernetes compatibility and secret management. The changes focus on creating required namespaces and secrets using `kubectl` before running the Helm command, and updating how authentication and client acceptance options are handled. **Helm installation improvements:** * Added a `kubectl create namespace` command to ensure the `newt` namespace exists before installation. * Added a `kubectl create secret generic` command to create the `newt-main-tunnel-auth` secret with required credentials, replacing direct value injection via Helm. * Updated the Helm install command to use `helm upgrade --install` with `-n newt` and reference the pre-created secret via `--set-string newtInstances[0].auth.existingSecretName="newt-main-tunnel-auth"`. * Modified the handling of the `acceptClients` option: now appends `--set newtInstances[0].acceptClients=true` to the Helm command only if clients are accepted. [[1]](diffhunk://#diff-22cc84b941ab6521a88da1afb0533704a7257d772fd3907847ce3850f31803c4R55-R58) [[2]](diffhunk://#diff-22cc84b941ab6521a88da1afb0533704a7257d772fd3907847ce3850f31803c4L165-R180) ## How to test? --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-05-29 02:51:44 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
api
authentication
bug
config
dependencies
docker
documentation
enhancement
good first issue
help wanted
Improvement
Look Into
needs investigating
networking
new feature
non-critical bug
potential bug
pull-request
Mirrored from GitHub Pull Request
 question
reverse proxy
Security
stale
ui
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/pangolin#21448
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?