github-starred/pangolin
2
0
Fork 0
mirror of https://github.com/fosrl/pangolin.git synced 2026-07-16 22:55:14 -05:00
Code Issues 1.6k Packages Projects Releases 79 Wiki Activity

[PR #1205] [MERGED] System wide default language detection via browser language header #20678

New Issue
Closed
opened 2026-05-29 02:12:35 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-05-29 02:12:35 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/fosrl/pangolin/pull/1205
Author: @Pallavikumarimdb
Created: 8/3/2025
Status: ✅ Merged
Merged: 8/3/2025
Merged by: @oschwartz10612

Base: dev ← Head: feature-default-language

📝 Commits (2)

  • 3fbfe50 Default language detection via browser language header
  • 616dae2 code format

📊 Changes

1 file changed (+24 additions, -4 deletions)

View changed files

📝 src/services/locale.ts (+24 -4)

📄 Description

Community Contribution License Agreement

By creating this pull request, I grant the project maintainers an unlimited,
perpetual license to use, modify, and redistribute these contributions under any terms they
choose, including both the AGPLv3 and the Fossorial Commercial license terms. I
represent that I have the right to grant this license for all contributed content.

Description

This PR adds support for detecting a user's preferred language from their browser settings (Accept-Language header) and falling back to a predefined default (en-US) when not available. The flow works as follows:

  1. If a cookie exists and its value matches one of the app-supported locales (/i18n/config.ts), it is used.

  2. If not, the Accept-Language header from the browser is parsed.
    We extract the base language (e.g., fr from fr-FR).
    We try to match it against available locales by comparing prefixes.

  3. If no match is found, the app falls back to the default locale: 'en-US'.

Fixes #1131

How to test?

  1. Open your browser settings and change the preferred language to something like French.
  2. Make sure the NEXT_LOCALE cookie is not set by clearing cookies or using an incognito/private window.
  3. Visit the app in a new tab or incognito window.
  4. Set your browser to a language not included in the app’s locales. The application should fallback to en-US.
  5. Cookie Override Test: If NEXT_LOCALE cookie is set (e.g., via language switcher), it should take priority over browser settings on the next visit.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/fosrl/pangolin/pull/1205 **Author:** [@Pallavikumarimdb](https://github.com/Pallavikumarimdb) **Created:** 8/3/2025 **Status:** ✅ Merged **Merged:** 8/3/2025 **Merged by:** [@oschwartz10612](https://github.com/oschwartz10612) **Base:** `dev` ← **Head:** `feature-default-language` --- ### 📝 Commits (2) - [`3fbfe50`](https://github.com/fosrl/pangolin/commit/3fbfe50e09e23fd9a7ce86f03cfc726751aad559) Default language detection via browser language header - [`616dae2`](https://github.com/fosrl/pangolin/commit/616dae2d8b0a06f299154f1f82d604378b69653d) code format ### 📊 Changes **1 file changed** (+24 additions, -4 deletions) <details> <summary>View changed files</summary> 📝 `src/services/locale.ts` (+24 -4) </details> ### 📄 Description ## Community Contribution License Agreement By creating this pull request, I grant the project maintainers an unlimited, perpetual license to use, modify, and redistribute these contributions under any terms they choose, including both the AGPLv3 and the Fossorial Commercial license terms. I represent that I have the right to grant this license for all contributed content. ## Description This PR adds support for detecting a user's preferred language from their browser settings (Accept-Language header) and falling back to a predefined default (en-US) when not available. The flow works as follows: 1. If a cookie exists and its value matches one of the app-supported locales (/i18n/config.ts), it is used. 2. If not, the Accept-Language header from the browser is parsed. We extract the base language (e.g., fr from fr-FR). We try to match it against available locales by comparing prefixes. 3. If no match is found, the app falls back to the default locale: 'en-US'. Fixes #1131 ## How to test? 1. Open your browser settings and change the preferred language to something like French. 2. Make sure the NEXT_LOCALE cookie is not set by clearing cookies or using an incognito/private window. 3. Visit the app in a new tab or incognito window. 5. Set your browser to a language not included in the app’s locales. The application should fallback to en-US. 6. Cookie Override Test: If NEXT_LOCALE cookie is set (e.g., via language switcher), it should take priority over browser settings on the next visit. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-05-29 02:12:35 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
api
authentication
bug
config
dependencies
docker
documentation
enhancement
good first issue
help wanted
Improvement
Look Into
needs investigating
networking
new feature
non-critical bug
potential bug
pull-request
Mirrored from GitHub Pull Request
 question
reverse proxy
Security
stale
ui
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/pangolin#20678
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?