github-starred/pangolin
2
0
Fork 0
mirror of https://github.com/fosrl/pangolin.git synced 2026-07-16 22:55:14 -05:00
Code Issues 1.6k Packages Projects Releases 79 Wiki Activity

[PR #3118] [MERGED] Fix public resource health with unknown WireGuard targets #20457

New Issue
Closed
opened 2026-05-21 22:06:08 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-05-21 22:06:08 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/fosrl/pangolin/pull/3118
Author: @Adityakk9031
Created: 5/20/2026
Status: ✅ Merged
Merged: 5/20/2026
Merged by: @oschwartz10612

Base: main ← Head: #3105

📝 Commits (1)

  • a6469e6 Fix public resource health with unknown WireGuard targets

📊 Changes

1 file changed (+11 additions, -3 deletions)

View changed files

📝 server/lib/alerts/events/healthCheckEvents.ts (+11 -3)

📄 Description

Description

Fixes #3105.

Public resources were marked as degraded when a WireGuard target was added alongside healthy Newt targets. WireGuard targets do not report target health checks, so their hcHealth is stored as unknown.

The resource health aggregation previously treated any mixed state that was not all healthy, all unhealthy, or all unknown as degraded. That made healthy + healthy + unknown become degraded.

This change ignores unknown target health when at least one monitored target exists. Unknown targets remain neutral in the overall resource health calculation.

Expected behavior after this change:

  • healthy + healthy + unknown -> healthy
  • healthy + unhealthy + unknown -> degraded
  • unhealthy + unhealthy + unknown -> unhealthy
  • unknown + unknown -> unknown

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/fosrl/pangolin/pull/3118 **Author:** [@Adityakk9031](https://github.com/Adityakk9031) **Created:** 5/20/2026 **Status:** ✅ Merged **Merged:** 5/20/2026 **Merged by:** [@oschwartz10612](https://github.com/oschwartz10612) **Base:** `main` ← **Head:** `#3105` --- ### 📝 Commits (1) - [`a6469e6`](https://github.com/fosrl/pangolin/commit/a6469e67a80469e5c779a7ff617759b9bd630a17) Fix public resource health with unknown WireGuard targets ### 📊 Changes **1 file changed** (+11 additions, -3 deletions) <details> <summary>View changed files</summary> 📝 `server/lib/alerts/events/healthCheckEvents.ts` (+11 -3) </details> ### 📄 Description ## Description Fixes #3105. Public resources were marked as degraded when a WireGuard target was added alongside healthy Newt targets. WireGuard targets do not report target health checks, so their `hcHealth` is stored as `unknown`. The resource health aggregation previously treated any mixed state that was not all healthy, all unhealthy, or all unknown as degraded. That made `healthy + healthy + unknown` become `degraded`. This change ignores `unknown` target health when at least one monitored target exists. Unknown targets remain neutral in the overall resource health calculation. Expected behavior after this change: - `healthy + healthy + unknown` -> `healthy` - `healthy + unhealthy + unknown` -> `degraded` - `unhealthy + unhealthy + unknown` -> `unhealthy` - `unknown + unknown` -> `unknown` --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-05-21 22:06:08 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
api
authentication
bug
config
dependencies
docker
documentation
enhancement
good first issue
help wanted
Improvement
Look Into
needs investigating
networking
new feature
non-critical bug
potential bug
pull-request
Mirrored from GitHub Pull Request
 question
reverse proxy
Security
stale
ui
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/pangolin#20457
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?