github-starred/pangolin
2
0
Fork 0
mirror of https://github.com/fosrl/pangolin.git synced 2026-05-22 01:22:50 -05:00
Code Issues 959 Packages Projects Releases 74 Wiki Activity

[GH-ISSUE #1705] Geoblock rules don't get created properly by blueprint (Docker Labels) #1984

New Issue
Closed
opened 2026-04-16 08:53:36 -05:00 by GiteaMirror · 4 comments
GiteaMirror commented 2026-04-16 08:53:36 -05:00
Owner
Copy Link

Originally created by @txwgnd on GitHub (Oct 19, 2025).
Original GitHub issue: https://github.com/fosrl/pangolin/issues/1705

Originally assigned to: @Pallavikumarimdb on GitHub.

Describe the Bug

Hello All,

I experienced a bug when creating a ressource with Docker Labels.
The match type doesn't get populated properly for type country.
The rule doesn't work either when created like this so it is not just a UI bug!

Macht type country:
Image

In comparison to match type path:
Image

Environment

  • OS Type & Version: TrueNAS 25.04
  • Pangolin Version: 1.11.0
  • Gerbil Version: 1.2.1
  • Traefik Version: v3.5.3
  • Newt Version: 1.5.2
  • Olm Version: (if applicable)

To Reproduce

Create a ressource with a ruleset for match type country inside of Pangolin through Newt's Docker Socket connection with Docker Labels.

e.g.

labels:
  - pangolin.proxy-resources.pocket-id.name=Pocket ID
  - pangolin.proxy-resources.pocket-id.full-domain=${IDP_SUB}.${MAIN_DOMAIN}
  - pangolin.proxy-resources.pocket-id.protocol=http   
  - pangolin.proxy-resources.pocket-id.ssl=true
  - pangolin.proxy-resources.pocket-id.enabled=true
  - pangolin.proxy-resources.pocket-id.targets[0].site=${SITE}
  - pangolin.proxy-resources.pocket-id.targets[0].hostname=pid
  - pangolin.proxy-resources.pocket-id.targets[0].port=${IDP_PORT}
  - pangolin.proxy-resources.pocket-id.targets[0].method=http
  - pangolin.proxy-resources.pocket-id.rules[0].action=allow
  - pangolin.proxy-resources.pocket-id.rules[0].match=country
  - pangolin.proxy-resources.pocket-id.rules[0].value=DE

Expected Behavior

The rule should be created with the match type filled in properly and work as set.

Originally created by @txwgnd on GitHub (Oct 19, 2025). Original GitHub issue: https://github.com/fosrl/pangolin/issues/1705 Originally assigned to: @Pallavikumarimdb on GitHub. ### Describe the Bug Hello All, I experienced a bug when creating a ressource with Docker Labels. The match type doesn't get populated properly for type `country`. The rule doesn't work either when created like this so it is not just a UI bug! Macht type `country`: <img width="1239" height="332" alt="Image" src="https://github.com/user-attachments/assets/840c341a-694a-4f7e-923d-174b00bf5a2a" /> In comparison to match type `path`: <img width="1240" height="347" alt="Image" src="https://github.com/user-attachments/assets/3960bc99-9e1e-4909-a81f-ec3d5dd298d8" /> ### Environment - OS Type & Version: TrueNAS 25.04 - Pangolin Version: 1.11.0 - Gerbil Version: 1.2.1 - Traefik Version: v3.5.3 - Newt Version: 1.5.2 - Olm Version: (if applicable) ### To Reproduce Create a ressource with a ruleset for match type `country` inside of Pangolin through Newt's Docker Socket connection with Docker Labels. e.g. > labels: > - pangolin.proxy-resources.pocket-id.name=Pocket ID > - pangolin.proxy-resources.pocket-id.full-domain=${IDP_SUB}.${MAIN_DOMAIN} > - pangolin.proxy-resources.pocket-id.protocol=http > - pangolin.proxy-resources.pocket-id.ssl=true > - pangolin.proxy-resources.pocket-id.enabled=true > - pangolin.proxy-resources.pocket-id.targets[0].site=${SITE} > - pangolin.proxy-resources.pocket-id.targets[0].hostname=pid > - pangolin.proxy-resources.pocket-id.targets[0].port=${IDP_PORT} > - pangolin.proxy-resources.pocket-id.targets[0].method=http > - pangolin.proxy-resources.pocket-id.rules[0].action=allow > - pangolin.proxy-resources.pocket-id.rules[0].match=country > - pangolin.proxy-resources.pocket-id.rules[0].value=DE ### Expected Behavior The rule should be created with the match type filled in properly and work as set.
GiteaMirror commented 2026-04-16 08:53:37 -05:00
Author
Owner
Copy Link

@oschwartz10612 commented on GitHub (Oct 19, 2025):

Hey @Pallavikumarimdb could you also look at this one? I think should be fairly straight forward fix on the blueprints code in the proxyResource.ts.

<!-- gh-comment-id:3419994820 --> @oschwartz10612 commented on GitHub (Oct 19, 2025): Hey @Pallavikumarimdb could you also look at this one? I think should be fairly straight forward fix on the blueprints code in the `proxyResource.ts`.
GiteaMirror commented 2026-04-16 08:53:37 -05:00
Author
Owner
Copy Link

@Pallavikumarimdb commented on GitHub (Oct 20, 2025):

Sure, I’ll check.

<!-- gh-comment-id:3421582933 --> @Pallavikumarimdb commented on GitHub (Oct 20, 2025): Sure, I’ll check.
GiteaMirror commented 2026-04-16 08:53:37 -05:00
Author
Owner
Copy Link

@Lokowitz commented on GitHub (Oct 21, 2025):

Have the same problem.

<!-- gh-comment-id:3428339106 --> @Lokowitz commented on GitHub (Oct 21, 2025): Have the same problem.
GiteaMirror commented 2026-04-16 08:53:37 -05:00
Author
Owner
Copy Link

@txwgnd commented on GitHub (Oct 21, 2025):

I have a side question regarding this. What should the value of pangolin.proxy-resources.pocket-id.rules[0].value= actually be? The docs only mention that the format is dependend on the match type, which is correct but doesn't make it clear.
My brain automatically thought of ISO 3166-1 A-2 country codes but the entrys of the drop-down are longer.

<!-- gh-comment-id:3429812564 --> @txwgnd commented on GitHub (Oct 21, 2025): I have a side question regarding this. What should the value of `pangolin.proxy-resources.pocket-id.rules[0].value=` actually be? The docs only mention that the format is dependend on the match type, which is correct but doesn't make it clear. My brain automatically thought of ISO 3166-1 A-2 country codes but the entrys of the drop-down are longer.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
api
authentication
bug
config
dependencies
docker
documentation
enhancement
good first issue
help wanted
Improvement
Look Into
needs investigating
networking
new feature
non-critical bug
potential bug
pull-request
Mirrored from GitHub Pull Request
 question
reverse proxy
Security
stale
ui
wontfix
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/pangolin#1984
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?