By creating this pull request, I grant the project maintainers an unlimited,
perpetual license to use, modify, and redistribute these contributions under any terms they
choose, including both the AGPLv3 and the Fossorial Commercial license terms. I
represent that I have the right to grant this license for all contributed content.
Description
When a user typed a subdomain and then selected a different base domain, the subdomain value was being cleared due to onDomainChange being called with subdomain: undefined.
How to test?
User need to to have more than 1 domain to test.
Type subdomain first then change the base domain.
If the subdomain is valid for the new base domain, the subdomain should be preserved
This should be tested on Create Resource Page and General Section of Resource Settings
🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.
## 📋 Pull Request Information
**Original PR:** https://github.com/fosrl/pangolin/pull/1383
**Author:** [@arevindh](https://github.com/arevindh)
**Created:** 8/29/2025
**Status:** ❌ Closed
**Base:** `dev` ← **Head:** `fix-domain-picker-issue`
---
### 📝 Commits (5)
- [`6c9b445`](https://github.com/fosrl/pangolin/commit/6c9b445be60139901f3b1f8bd2afed74e6a15020) Merge pull request #1353 from fosrl/dev
- [`2e2753b`](https://github.com/fosrl/pangolin/commit/2e2753b935aa6f49d18b90ce757613b3ca222781) Merge branch 'dev' of https://github.com/fosrl/pangolin into dev
- [`35ece5f`](https://github.com/fosrl/pangolin/commit/35ece5f3846cf00d4318ef8c8fb50c2b035dcb5e) Fix domain picker issue when subdomain is picked first
- [`549c9d4`](https://github.com/fosrl/pangolin/commit/549c9d48cdf31587928acfe15d8802e28549cffb) Merge branch 'dev' of https://github.com/fosrl/pangolin into fix-domain-picker-issue
- [`86be87b`](https://github.com/fosrl/pangolin/commit/86be87b9facd9e5aaf3325bd9a4df53cfae28b25) Merge branch 'dev' of https://github.com/fosrl/pangolin into fix-domain-picker-issue
### 📊 Changes
**1 file changed** (+24 additions, -16 deletions)
<details>
<summary>View changed files</summary>
📝 `src/components/DomainPicker.tsx` (+24 -16)
</details>
### 📄 Description
## Community Contribution License Agreement
By creating this pull request, I grant the project maintainers an unlimited,
perpetual license to use, modify, and redistribute these contributions under any terms they
choose, including both the AGPLv3 and the Fossorial Commercial license terms. I
represent that I have the right to grant this license for all contributed content.
## Description
When a user typed a subdomain and then selected a different base domain, the subdomain value was being cleared due to `onDomainChange` being called with `subdomain: undefined`.
## How to test?
- User need to to have more than 1 domain to test.
- Type subdomain first then change the base domain.
- If the subdomain is valid for the new base domain, the subdomain should be preserved
This should be tested on **Create Resource Page** and **General Section** of **Resource Settings**
---
<sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
Blocking a user prevents them from interacting with repositories, such as opening or commenting on pull requests or issues. Learn more about blocking a user.
📋 Pull Request Information
Original PR: https://github.com/fosrl/pangolin/pull/1383
Author: @arevindh
Created: 8/29/2025
Status: ❌ Closed
Base:
dev← Head:fix-domain-picker-issue📝 Commits (5)
6c9b445Merge pull request #1353 from fosrl/dev2e2753bMerge branch 'dev' of https://github.com/fosrl/pangolin into dev35ece5fFix domain picker issue when subdomain is picked first549c9d4Merge branch 'dev' of https://github.com/fosrl/pangolin into fix-domain-picker-issue86be87bMerge branch 'dev' of https://github.com/fosrl/pangolin into fix-domain-picker-issue📊 Changes
1 file changed (+24 additions, -16 deletions)
View changed files
📝
src/components/DomainPicker.tsx(+24 -16)📄 Description
Community Contribution License Agreement
By creating this pull request, I grant the project maintainers an unlimited,
perpetual license to use, modify, and redistribute these contributions under any terms they
choose, including both the AGPLv3 and the Fossorial Commercial license terms. I
represent that I have the right to grant this license for all contributed content.
Description
When a user typed a subdomain and then selected a different base domain, the subdomain value was being cleared due to
onDomainChangebeing called withsubdomain: undefined.How to test?
This should be tested on Create Resource Page and General Section of Resource Settings
🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.