github-starred/pangolin
2
0
Fork 0
mirror of https://github.com/fosrl/pangolin.git synced 2026-05-23 10:02:28 -05:00
Code Issues 959 Packages Projects Releases 74 Wiki Activity

[GH-ISSUE #2736] Health checks are still running when Ressource is disabled #13033

New Issue
Closed
opened 2026-05-13 18:34:29 -05:00 by GiteaMirror · 5 comments
GiteaMirror commented 2026-05-13 18:34:29 -05:00
Owner
Copy Link

Originally created by @maieredv-manuel on GitHub (Mar 29, 2026).
Original GitHub issue: https://github.com/fosrl/pangolin/issues/2736

Describe the Bug

Health checks are still running when Ressource is disabled

Environment

  • OS Type & Version: Debian 12
  • Pangolin Version: v1.16.2
  • Gerbil Version: 1.3.0
  • Traefik Version: 3.6
  • Newt Version: 1.10.3
  • Olm Version: (if applicable)

To Reproduce

Disable an Ressource with enabled Healthchecks and look in the logs of newt.

Expected Behavior

If i disable a Ressource also the Healthchecks sould be disabled

Originally created by @maieredv-manuel on GitHub (Mar 29, 2026). Original GitHub issue: https://github.com/fosrl/pangolin/issues/2736 ### Describe the Bug Health checks are still running when Ressource is disabled ### Environment - OS Type & Version: Debian 12 - Pangolin Version: v1.16.2 - Gerbil Version: 1.3.0 - Traefik Version: 3.6 - Newt Version: 1.10.3 - Olm Version: (if applicable) ### To Reproduce Disable an Ressource with enabled Healthchecks and look in the logs of newt. ### Expected Behavior If i disable a Ressource also the Healthchecks sould be disabled
GiteaMirror added the good first issuebughelp wanted labels 2026-05-13 18:34:30 -05:00
GiteaMirror commented 2026-05-13 18:34:32 -05:00
Author
Owner
Copy Link

@oschwartz10612 commented on GitHub (Mar 29, 2026):

Yeah we should send a message to add and remove the healthchecks when enabled and disabled to the newt downstream.

<!-- gh-comment-id:4150886818 --> @oschwartz10612 commented on GitHub (Mar 29, 2026): Yeah we should send a message to add and remove the healthchecks when enabled and disabled to the newt downstream.
GiteaMirror commented 2026-05-13 18:34:32 -05:00
Author
Owner
Copy Link

@Adarsh-Raj-Jaiswal commented on GitHub (Mar 30, 2026):

Hi! I'd love to work on this issue. I plan to locate the resource update router and dispatch a WebSocket message to the Newt client to add/remove health checks based on the enabled state. Let me know if you have any architectural pointers!

<!-- gh-comment-id:4153880455 --> @Adarsh-Raj-Jaiswal commented on GitHub (Mar 30, 2026): Hi! I'd love to work on this issue. I plan to locate the resource update router and dispatch a WebSocket message to the Newt client to add/remove health checks based on the enabled state. Let me know if you have any architectural pointers!
GiteaMirror commented 2026-05-13 18:34:33 -05:00
Author
Owner
Copy Link

@oschwartz10612 commented on GitHub (Mar 30, 2026):

Sure @Adarsh-Raj-Jaiswal give it a shot. I will review the PR when you are ready.

<!-- gh-comment-id:4156587309 --> @oschwartz10612 commented on GitHub (Mar 30, 2026): Sure @Adarsh-Raj-Jaiswal give it a shot. I will review the PR when you are ready.
GiteaMirror commented 2026-05-13 18:34:33 -05:00
Author
Owner
Copy Link

@Adarsh-Raj-Jaiswal commented on GitHub (Apr 6, 2026):

Since I have windows so I was facing some issues in setting up pangolin. But now it's done and I'm able to proceed on this. Just wanted to update about this :)

<!-- gh-comment-id:4190215802 --> @Adarsh-Raj-Jaiswal commented on GitHub (Apr 6, 2026): Since I have windows so I was facing some issues in setting up pangolin. But now it's done and I'm able to proceed on this. Just wanted to update about this :)
GiteaMirror commented 2026-05-13 18:34:33 -05:00
Author
Owner
Copy Link

@oschwartz10612 commented on GitHub (May 1, 2026):

This was fixed in the 1.18.1 release!

<!-- gh-comment-id:4361972129 --> @oschwartz10612 commented on GitHub (May 1, 2026): This was fixed in the 1.18.1 release!
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
api
authentication
bug
config
dependencies
docker
documentation
enhancement
good first issue
help wanted
Improvement
Look Into
needs investigating
networking
new feature
non-critical bug
potential bug
pull-request
Mirrored from GitHub Pull Request
 question
reverse proxy
Security
stale
ui
wontfix
No Label bug good first issue help wanted
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/pangolin#13033
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?