github-starred/pangolin
2
0
Fork 0
mirror of https://github.com/fosrl/pangolin.git synced 2025-12-05 19:17:29 -06:00
Code Issues 94 Packages Projects Releases 48 Wiki Activity

[PR #1856] fix: Remove return in installer which prevents showing token #1252

New Issue
Open
opened 2025-11-13 12:21:29 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2025-11-13 12:21:29 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/fosrl/pangolin/pull/1856
Author: @LaurenceJJones
Created: 11/13/2025
Status: 🔄 Open

Base: main ← Head: fix-remove-return-before-showing-token

📝 Commits (1)

  • fbce392 Remove unnecessary return after success message

📊 Changes

1 file changed (+0 additions, -1 deletions)

View changed files

📝 install/main.go (+0 -1)

📄 Description

Remove redundant return statement after success message.

Community Contribution License Agreement

By creating this pull request, I grant the project maintainers an unlimited,
perpetual license to use, modify, and redistribute these contributions under any terms they
choose, including both the AGPLv3 and the Fossorial Commercial license terms. I
represent that I have the right to grant this license for all contributed content.

Description

Should fix #1509 after selecting to install crowdsec unless an error occurs. Its a quick fix, but you may want to move the showing of token before the crowdsec installation.

How to test?

When installing pangolin and selecting for managed node even when accepting to use crowdsec should show the code at the end of the installation.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/fosrl/pangolin/pull/1856 **Author:** [@LaurenceJJones](https://github.com/LaurenceJJones) **Created:** 11/13/2025 **Status:** 🔄 Open **Base:** `main` ← **Head:** `fix-remove-return-before-showing-token` --- ### 📝 Commits (1) - [`fbce392`](https://github.com/fosrl/pangolin/commit/fbce392137da5e4dc6742b73251ed52a1018bc0b) Remove unnecessary return after success message ### 📊 Changes **1 file changed** (+0 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `install/main.go` (+0 -1) </details> ### 📄 Description Remove redundant return statement after success message. ## Community Contribution License Agreement By creating this pull request, I grant the project maintainers an unlimited, perpetual license to use, modify, and redistribute these contributions under any terms they choose, including both the AGPLv3 and the Fossorial Commercial license terms. I represent that I have the right to grant this license for all contributed content. ## Description Should fix #1509 after selecting to install crowdsec unless an error occurs. Its a quick fix, but you may want to move the showing of token before the crowdsec installation. ## How to test? When installing pangolin and selecting for managed node even when accepting to use crowdsec should show the code at the end of the installation. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the
pull-request
 label 2025-11-13 12:21:29 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
api
authentication
bug
config
dependencies
docker
documentation
enhancement
good first issue
help wanted
Improvement
Look Into
needs investigating
networking
new feature
non-critical bug
potential bug
pull-request
Mirrored from GitHub Pull Request
question
reverse proxy
Security
stale
ui
No Label
pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/pangolin#1252
No description provided.
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?