github-starred/pangolin
2
0
Fork 0
mirror of https://github.com/fosrl/pangolin.git synced 2026-05-24 03:18:37 -05:00
Code Issues 959 Packages Projects Releases 74 Wiki Activity

[GH-ISSUE #963] [Feature request] Allow yml to be absent when ENV is set #12512

New Issue
Closed
opened 2026-05-13 17:50:21 -05:00 by GiteaMirror · 6 comments
GiteaMirror commented 2026-05-13 17:50:21 -05:00
Owner
Copy Link

Originally created by @jackrosenberg on GitHub (Jun 24, 2025).
Original GitHub issue: https://github.com/fosrl/pangolin/issues/963

In config.yml, certain fields such as USERS_SERVERADMIN_PASSWORD need to be hard coded. It would be nice if these fields could be left blank in the case that the corresponding env var is found on startup. Currently pangolin throws: Error: Invalid configuration file: Validation error, which is the expected behavior, but something like lazy loading would be an elegant fix for this.

Originally created by @jackrosenberg on GitHub (Jun 24, 2025). Original GitHub issue: https://github.com/fosrl/pangolin/issues/963 In `config.yml`, certain fields such as `USERS_SERVERADMIN_PASSWORD` need to be hard coded. It would be nice if these fields could be left blank in the case that the corresponding `env` var is found on startup. Currently pangolin throws: `Error: Invalid configuration file: Validation error`, which is the expected behavior, but something like lazy loading would be an elegant fix for this.
GiteaMirror added the enhancementnon-critical bughelp wanted labels 2026-05-13 17:50:21 -05:00
GiteaMirror commented 2026-05-13 17:50:24 -05:00
Author
Owner
Copy Link

@oschwartz10612 commented on GitHub (Jun 25, 2025):

Good point this should be a simple fix we could add soon!

<!-- gh-comment-id:3005116375 --> @oschwartz10612 commented on GitHub (Jun 25, 2025): Good point this should be a simple fix we could add soon!
GiteaMirror commented 2026-05-13 17:50:25 -05:00
Author
Owner
Copy Link

@jackrosenberg commented on GitHub (Jun 25, 2025):

Thanks for the fast response, I can PR this myself sometime in the coming weeks :)

<!-- gh-comment-id:3005205906 --> @jackrosenberg commented on GitHub (Jun 25, 2025): Thanks for the fast response, I can PR this myself sometime in the coming weeks :)
GiteaMirror commented 2026-05-13 17:50:27 -05:00
Author
Owner
Copy Link

@oschwartz10612 commented on GitHub (Jun 26, 2025):

That would be great!

<!-- gh-comment-id:3008828315 --> @oschwartz10612 commented on GitHub (Jun 26, 2025): That would be great!
GiteaMirror commented 2026-05-13 17:50:29 -05:00
Author
Owner
Copy Link

@jackrosenberg commented on GitHub (Jun 30, 2025):

Think this is closed by 1.6.0, right? @oschwartz10612

<!-- gh-comment-id:3020419913 --> @jackrosenberg commented on GitHub (Jun 30, 2025): Think this is closed by 1.6.0, right? @oschwartz10612
GiteaMirror commented 2026-05-13 17:50:30 -05:00
Author
Owner
Copy Link

@miloschwartz commented on GitHub (Jul 1, 2025):

@jackrosenberg Yep! We removed the need for these variables in 1.6

<!-- gh-comment-id:3021686319 --> @miloschwartz commented on GitHub (Jul 1, 2025): @jackrosenberg Yep! We removed the need for these variables in 1.6
GiteaMirror commented 2026-05-13 17:50:31 -05:00
Author
Owner
Copy Link

@jackrosenberg commented on GitHub (Jul 1, 2025):

Nice, good one!

<!-- gh-comment-id:3022564888 --> @jackrosenberg commented on GitHub (Jul 1, 2025): Nice, good one!
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
api
authentication
bug
config
dependencies
docker
documentation
enhancement
good first issue
help wanted
Improvement
Look Into
needs investigating
networking
new feature
non-critical bug
potential bug
pull-request
Mirrored from GitHub Pull Request
 question
reverse proxy
Security
stale
ui
wontfix
No Label enhancement help wanted non-critical bug
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/pangolin#12512
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?