[PR #1735] [CLOSED] fix blueprint country issue - fix #1705 #1200

New Issue

2025-11-13T12:20:21-06:00

GiteaMirror commented

2025-11-13 12:20:21 -06:00

📋 Pull Request Information

Original PR: https://github.com/fosrl/pangolin/pull/1735
Author: @Lokowitz
Created: 10/23/2025
Status: ❌ Closed

Base: dev ← Head: dev

📝 Commits (1)

d48124e fix blueprint country issue

📊 Changes

1 file changed (+1 additions, -1 deletions)

View changed files

📝 server/lib/blueprints/types.ts (+1 -1)

📄 Description

Community Contribution License Agreement

By creating this pull request, I grant the project maintainers an unlimited,
perpetual license to use, modify, and redistribute these contributions under any terms they
choose, including both the AGPLv3 and the Fossorial Commercial license terms. I
represent that I have the right to grant this license for all contributed content.

Description

The rules section in resources is handling geoblocking as match type geoip and not as country.

Do you want to stay with geoip or switch completely to country?
Will also update the docs accordingly.

Staying with geoip will cause a rewrite of all users blueprints and since you are selecting a country will maybe cause some confusions.
A rewrite of the rules section and a database migration from geoip to country would be more user friendly.

Fixes https://github.com/fosrl/pangolin/issues/1705#issuecomment-3429812564

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/fosrl/pangolin/pull/1735 **Author:** [@Lokowitz](https://github.com/Lokowitz) **Created:** 10/23/2025 **Status:** ❌ Closed **Base:** `dev` ← **Head:** `dev` --- ### 📝 Commits (1) - [`d48124e`](https://github.com/fosrl/pangolin/commit/d48124e9a8f6cc70b73f68f74eca4a28b4371588) fix blueprint country issue ### 📊 Changes **1 file changed** (+1 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `server/lib/blueprints/types.ts` (+1 -1) </details> ### 📄 Description ## Community Contribution License Agreement By creating this pull request, I grant the project maintainers an unlimited, perpetual license to use, modify, and redistribute these contributions under any terms they choose, including both the AGPLv3 and the Fossorial Commercial license terms. I represent that I have the right to grant this license for all contributed content. ## Description The rules section in resources is handling geoblocking as match type `geoip` and not as `country`. Do you want to stay with `geoip` or switch completely to `country`? Will also update the docs accordingly. Staying with geoip will cause a rewrite of all users blueprints and since you are selecting a country will maybe cause some confusions. A rewrite of the rules section and a database migration from geoip to country would be more user friendly. Fixes https://github.com/fosrl/pangolin/issues/1705#issuecomment-3429812564 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

GiteaMirror added the pull-request label 2025-11-13 12:20:21 -06:00

GiteaMirror closed this issue