github-starred/pangolin
2
0
Fork 0
mirror of https://github.com/fosrl/pangolin.git synced 2026-05-06 12:55:03 -05:00
Code Issues 564 Packages Projects Releases 72 Wiki Activity

[PR #2748] [MERGED] fix: show contextual toast when saving with no targets #11940

New Issue
Closed
opened 2026-05-06 16:32:50 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-05-06 16:32:50 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/fosrl/pangolin/pull/2748
Author: @jaydeep-pipaliya
Created: 3/31/2026
Status: ✅ Merged
Merged: 3/31/2026
Merged by: @oschwartz10612

Base: main ← Head: fix/empty-targets-toast-message

📝 Commits (1)

  • e06f2f4 fix: show contextual toast when saving with no targets

📊 Changes

2 files changed (+8 additions, -2 deletions)

View changed files

📝 messages/en-US.json (+2 -0)
📝 src/app/[orgId]/settings/resources/proxy/[niceId]/proxy/page.tsx (+6 -2)

📄 Description

Summary

Follow-up to #2711 based on maintainer feedback — saving with no targets should still work (to allow clearing targets), but the notification should reflect what actually happened.

What changed: Instead of always showing "Settings updated" when saving, the toast now shows:

  • "Targets cleared" when the target list is empty
  • "Settings updated" when targets were actually saved

No save action is blocked — this only changes the notification text.

Fixes #586

Test plan

  • Save with no targets → toast says "Targets cleared"
  • Save with targets → toast says "Settings updated"
  • Remove all targets and save → deletions process correctly, toast says "Targets cleared"

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/fosrl/pangolin/pull/2748 **Author:** [@jaydeep-pipaliya](https://github.com/jaydeep-pipaliya) **Created:** 3/31/2026 **Status:** ✅ Merged **Merged:** 3/31/2026 **Merged by:** [@oschwartz10612](https://github.com/oschwartz10612) **Base:** `main` ← **Head:** `fix/empty-targets-toast-message` --- ### 📝 Commits (1) - [`e06f2f4`](https://github.com/fosrl/pangolin/commit/e06f2f47b18da9be2eac3b50ba14a4220a4a9c5d) fix: show contextual toast when saving with no targets ### 📊 Changes **2 files changed** (+8 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `messages/en-US.json` (+2 -0) 📝 `src/app/[orgId]/settings/resources/proxy/[niceId]/proxy/page.tsx` (+6 -2) </details> ### 📄 Description ## Summary Follow-up to #2711 based on maintainer feedback — saving with no targets should still work (to allow clearing targets), but the notification should reflect what actually happened. **What changed:** Instead of always showing "Settings updated" when saving, the toast now shows: - **"Targets cleared"** when the target list is empty - **"Settings updated"** when targets were actually saved No save action is blocked — this only changes the notification text. Fixes #586 ## Test plan - [x] Save with no targets → toast says "Targets cleared" - [x] Save with targets → toast says "Settings updated" - [x] Remove all targets and save → deletions process correctly, toast says "Targets cleared" --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-05-06 16:32:50 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
api
authentication
bug
config
dependencies
docker
documentation
enhancement
good first issue
help wanted
Improvement
Look Into
needs investigating
networking
new feature
non-critical bug
potential bug
pull-request
Mirrored from GitHub Pull Request
 question
reverse proxy
Security
stale
ui
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/pangolin#11940
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?