github-starred/pangolin
2
0
Fork 0
mirror of https://github.com/fosrl/pangolin.git synced 2026-05-06 20:59:07 -05:00
Code Issues 564 Packages Projects Releases 72 Wiki Activity

[PR #2434] feat: Add path setting to share links (resourceAccessToken) #11768

New Issue
Open
opened 2026-05-06 16:24:04 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-05-06 16:24:04 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/fosrl/pangolin/pull/2434
Author: @NHClaessens
Created: 2/8/2026
Status: 🔄 Open

Base: main ← Head: feature-share-link-redirect-path

📝 Commits (7)

  • db34247 Alter schema + add form field
  • 2b8a0ad Adjust validation to allow creation with (optional) path
  • ceec9e9 Add path onto redirectUrl
  • 661f135 Add translations
  • eb98592 Update postgres schema
  • f1a92f2 Merge branch 'main' into feature-share-link-redirect-path
  • 06d81a2 Merge branch 'main' into feature-share-link-redirect-path

📊 Changes

24 files changed (+269 additions, -27 deletions)

View changed files

➕ drizzle.config.ts (+15 -0)
📝 messages/bg-BG.json (+1 -0)
📝 messages/cs-CZ.json (+1 -0)
📝 messages/de-DE.json (+1 -0)
📝 messages/en-US.json (+1 -0)
📝 messages/es-ES.json (+1 -0)
📝 messages/fr-FR.json (+1 -0)
📝 messages/it-IT.json (+1 -0)
📝 messages/ko-KR.json (+1 -0)
📝 messages/nb-NO.json (+1 -0)
📝 messages/nl-NL.json (+1 -0)
📝 messages/pl-PL.json (+1 -0)
📝 messages/pt-PT.json (+1 -0)
📝 messages/ru-RU.json (+1 -0)
📝 messages/tr-TR.json (+1 -0)
📝 messages/zh-CN.json (+1 -0)
📝 messages/zh-TW.json (+1 -0)
📝 package-lock.json (+6 -24)
📝 server/db/pg/schema/schema.ts (+1 -0)
📝 server/db/sqlite/schema/schema.ts (+1 -0)

...and 4 more files

📄 Description

Community Contribution License Agreement

By creating this pull request, I grant the project maintainers an unlimited,
perpetual license to use, modify, and redistribute these contributions under any terms they
choose, including both the AGPLv3 and the Fossorial Commercial license terms. I
represent that I have the right to grant this license for all contributed content.

Description

Adds an optional path parameter to share links that allows specifying a custom redirect path when accessing a resource.

This feature addresses a specific use case, if this change is not desired in the main branch, or if any changes are required, I would be more than happy to cooperate.

The use case in question:

  • I run an Immich instance with shared albums
  • In order to allow users to upload pictures, the /api/ endpoint needs to be exposed, which is undesirable
  • Share links would mitigate this, as they use a cookie to only allow users with a link to access the resource
  • However, the link redirects to the base URL of the resource, with no option to change this
  • Thus, I have added the option to add an (optional) path onto a share link's redirect (e.g. share/xxxx)

Changes Made

  • Added path column in the resourceAccessToken schema in Postgres and SQLite schemas (optional field, so not a breaking change)
  • Added field in CreateSharedLinkForm.tsx
  • Change generateAccessToken.ts to accept and return path value
  • Change authWithAccessToken.ts to add the path onto the redirect url
  • Add translations for the new field

How to test?

  1. Go to Access > Links
  2. Create a new Share Link
  3. Optionally add a path
  4. Confirm that the final redirect leads to the expected location, and does not result in malformed URLs

(This is my first open-source contribution, thank you for your patience)

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/fosrl/pangolin/pull/2434 **Author:** [@NHClaessens](https://github.com/NHClaessens) **Created:** 2/8/2026 **Status:** 🔄 Open **Base:** `main` ← **Head:** `feature-share-link-redirect-path` --- ### 📝 Commits (7) - [`db34247`](https://github.com/fosrl/pangolin/commit/db34247840228e41b90cafe8b27333445a3523d8) Alter schema + add form field - [`2b8a0ad`](https://github.com/fosrl/pangolin/commit/2b8a0ad97c18b4e95350228d409fd14fd13b6ad4) Adjust validation to allow creation with (optional) path - [`ceec9e9`](https://github.com/fosrl/pangolin/commit/ceec9e9dbcac97e5aea6b6a5297d0b1eb75c26db) Add path onto redirectUrl - [`661f135`](https://github.com/fosrl/pangolin/commit/661f135aa1c8a54a83488b1002ac7ea3afefaf02) Add translations - [`eb98592`](https://github.com/fosrl/pangolin/commit/eb985924f74dc3a36b8b428c75c2cdf970177bf4) Update postgres schema - [`f1a92f2`](https://github.com/fosrl/pangolin/commit/f1a92f2202b64af961915e7ad3b187b866cf175e) Merge branch 'main' into feature-share-link-redirect-path - [`06d81a2`](https://github.com/fosrl/pangolin/commit/06d81a2b511ce35feb99fc8de176e7573fddb353) Merge branch 'main' into feature-share-link-redirect-path ### 📊 Changes **24 files changed** (+269 additions, -27 deletions) <details> <summary>View changed files</summary> ➕ `drizzle.config.ts` (+15 -0) 📝 `messages/bg-BG.json` (+1 -0) 📝 `messages/cs-CZ.json` (+1 -0) 📝 `messages/de-DE.json` (+1 -0) 📝 `messages/en-US.json` (+1 -0) 📝 `messages/es-ES.json` (+1 -0) 📝 `messages/fr-FR.json` (+1 -0) 📝 `messages/it-IT.json` (+1 -0) 📝 `messages/ko-KR.json` (+1 -0) 📝 `messages/nb-NO.json` (+1 -0) 📝 `messages/nl-NL.json` (+1 -0) 📝 `messages/pl-PL.json` (+1 -0) 📝 `messages/pt-PT.json` (+1 -0) 📝 `messages/ru-RU.json` (+1 -0) 📝 `messages/tr-TR.json` (+1 -0) 📝 `messages/zh-CN.json` (+1 -0) 📝 `messages/zh-TW.json` (+1 -0) 📝 `package-lock.json` (+6 -24) 📝 `server/db/pg/schema/schema.ts` (+1 -0) 📝 `server/db/sqlite/schema/schema.ts` (+1 -0) _...and 4 more files_ </details> ### 📄 Description ## Community Contribution License Agreement By creating this pull request, I grant the project maintainers an unlimited, perpetual license to use, modify, and redistribute these contributions under any terms they choose, including both the AGPLv3 and the Fossorial Commercial license terms. I represent that I have the right to grant this license for all contributed content. ## Description Adds an optional `path` parameter to share links that allows specifying a custom redirect path when accessing a resource. This feature addresses a specific use case, if this change is not desired in the main branch, or if any changes are required, I would be more than happy to cooperate. The use case in question: - I run an Immich instance with shared albums - In order to allow users to upload pictures, the `/api/` endpoint needs to be exposed, which is undesirable - Share links would mitigate this, as they use a cookie to only allow users with a link to access the resource - However, the link redirects to the base URL of the resource, with no option to change this - Thus, I have added the option to add an (optional) path onto a share link's redirect (e.g. `share/xxxx`) ## Changes Made - Added `path` column in the `resourceAccessToken` schema in Postgres and SQLite schemas (optional field, so not a breaking change) - Added field in CreateSharedLinkForm.tsx - Change generateAccessToken.ts to accept and return `path` value - Change authWithAccessToken.ts to add the path onto the redirect url - Add translations for the new field ## How to test? 1. Go to `Access` > `Links` 2. Create a new Share Link 3. Optionally add a path 4. Confirm that the final redirect leads to the expected location, and does not result in malformed URLs (This is my first open-source contribution, thank you for your patience) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-05-06 16:24:04 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
api
authentication
bug
config
dependencies
docker
documentation
enhancement
good first issue
help wanted
Improvement
Look Into
needs investigating
networking
new feature
non-critical bug
potential bug
pull-request
Mirrored from GitHub Pull Request
 question
reverse proxy
Security
stale
ui
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/pangolin#11768
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?