[PR #1989] [MERGED] refactor: save button positionning #11603

Closed
opened 2026-05-06 16:16:59 -05:00 by GiteaMirror · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/fosrl/pangolin/pull/1989
Author: @Fredkiss3
Created: 12/5/2025
Status: Merged
Merged: 12/18/2025
Merged by: @miloschwartz

Base: devHead: refactor/save-button-positions


📝 Commits (10+)

  • a0a369d ♻️ refactor reverse proxy targets page
  • 2ec2295 ♻️ separate proxy page into multiple forms
  • 72bc26f 💬 update texts to be more specific
  • ea43bf9 Merge branch 'dev' into refactor/save-button-positions
  • ce6b609 ♻️ Update domain picker component to accept default values
  • 4e842a6 🚧 wip: refactor proxy resource page
  • c13bfc7 Merge branch 'dev' into refactor/save-button-positions
  • 7f07cce Merge branch 'dev' into refactor/save-button-positions
  • 124ba20 ♻️ use react querty
  • 769d20c Merge branch 'dev' into refactor/save-button-positions

📊 Changes

12 files changed (+2323 additions, -2485 deletions)

View changed files

📝 cli/commands/clearExitNodes.ts (+2 -2)
📝 messages/en-US.json (+7 -2)
📝 src/app/[orgId]/settings/general/page.tsx (+696 -535)
📝 src/app/[orgId]/settings/resources/proxy/[niceId]/authentication/page.tsx (+371 -349)
📝 src/app/[orgId]/settings/resources/proxy/[niceId]/general/page.tsx (+274 -400)
📝 src/app/[orgId]/settings/resources/proxy/[niceId]/layout.tsx (+2 -1)
📝 src/app/[orgId]/settings/resources/proxy/[niceId]/proxy/page.tsx (+919 -1166)
📝 src/components/DomainPicker.tsx (+6 -0)
📝 src/contexts/orgContext.ts (+1 -2)
📝 src/contexts/resourceContext.ts (+1 -1)
📝 src/lib/queries.ts (+42 -4)
📝 src/providers/OrgProvider.tsx (+2 -23)

📄 Description

Community Contribution License Agreement

By creating this pull request, I grant the project maintainers an unlimited,
perpetual license to use, modify, and redistribute these contributions under any terms they
choose, including both the AGPLv3 and the Fossorial Commercial license terms. I
represent that I have the right to grant this license for all contributed content.

Description

Main changes:

  • Mainly changed the proxy details page and org settings page by separating the single form into multiple ones
  • Also did some refactoring regarding fetching data in useEffect in the resource proxy & authentication pages, and instead using react query to fetch and cache the data (subsequent navigations is faster with no loading states)

Screenshots

Name Screenshot
Resource Proxy page
Org settings page

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/fosrl/pangolin/pull/1989 **Author:** [@Fredkiss3](https://github.com/Fredkiss3) **Created:** 12/5/2025 **Status:** ✅ Merged **Merged:** 12/18/2025 **Merged by:** [@miloschwartz](https://github.com/miloschwartz) **Base:** `dev` ← **Head:** `refactor/save-button-positions` --- ### 📝 Commits (10+) - [`a0a369d`](https://github.com/fosrl/pangolin/commit/a0a369dc43ebd8c11723a3b265642b99ecfc5aef) ♻️ refactor reverse proxy targets page - [`2ec2295`](https://github.com/fosrl/pangolin/commit/2ec2295cd66badb7abed46f0f16e7be09f06e632) ♻️ separate proxy page into multiple forms - [`72bc26f`](https://github.com/fosrl/pangolin/commit/72bc26f0f84c08a3ee98f56fe15e2df05e8531c0) 💬 update texts to be more specific - [`ea43bf9`](https://github.com/fosrl/pangolin/commit/ea43bf97c7a305206a3530105d9e62a88764240c) Merge branch 'dev' into refactor/save-button-positions - [`ce6b609`](https://github.com/fosrl/pangolin/commit/ce6b609ca2ce1d0115bd4564742450230452e5a3) ♻️ Update domain picker component to accept default values - [`4e842a6`](https://github.com/fosrl/pangolin/commit/4e842a660a37874cc9770ef1ac157c031b0f6070) 🚧 wip: refactor proxy resource page - [`c13bfc7`](https://github.com/fosrl/pangolin/commit/c13bfc709f0446f63e3f6f351f958a60db26e331) Merge branch 'dev' into refactor/save-button-positions - [`7f07cce`](https://github.com/fosrl/pangolin/commit/7f07ccea449a2acea3af8eb55cf2fabe6b487ee1) Merge branch 'dev' into refactor/save-button-positions - [`124ba20`](https://github.com/fosrl/pangolin/commit/124ba208de648bfae22057b3556b668be0d0e16f) ♻️ use react querty - [`769d20c`](https://github.com/fosrl/pangolin/commit/769d20cea12b83829603187b303621fb246b13bb) Merge branch 'dev' into refactor/save-button-positions ### 📊 Changes **12 files changed** (+2323 additions, -2485 deletions) <details> <summary>View changed files</summary> 📝 `cli/commands/clearExitNodes.ts` (+2 -2) 📝 `messages/en-US.json` (+7 -2) 📝 `src/app/[orgId]/settings/general/page.tsx` (+696 -535) 📝 `src/app/[orgId]/settings/resources/proxy/[niceId]/authentication/page.tsx` (+371 -349) 📝 `src/app/[orgId]/settings/resources/proxy/[niceId]/general/page.tsx` (+274 -400) 📝 `src/app/[orgId]/settings/resources/proxy/[niceId]/layout.tsx` (+2 -1) 📝 `src/app/[orgId]/settings/resources/proxy/[niceId]/proxy/page.tsx` (+919 -1166) 📝 `src/components/DomainPicker.tsx` (+6 -0) 📝 `src/contexts/orgContext.ts` (+1 -2) 📝 `src/contexts/resourceContext.ts` (+1 -1) 📝 `src/lib/queries.ts` (+42 -4) 📝 `src/providers/OrgProvider.tsx` (+2 -23) </details> ### 📄 Description ## Community Contribution License Agreement By creating this pull request, I grant the project maintainers an unlimited, perpetual license to use, modify, and redistribute these contributions under any terms they choose, including both the AGPLv3 and the Fossorial Commercial license terms. I represent that I have the right to grant this license for all contributed content. ## Description **Main changes:** - Mainly changed the proxy details page and org settings page by separating the single form into multiple ones - Also did some refactoring regarding fetching data in `useEffect` in the resource proxy & authentication pages, and instead using react query to fetch and cache the data (subsequent navigations is faster with no loading states) ## Screenshots | Name | Screenshot | | :----------------: | :--------: | | Resource Proxy page | <video src="https://github.com/user-attachments/assets/d4ff23a1-ae68-46a8-bd6d-03cfbb386b46"></video> | | Org settings page | <video src="https://github.com/user-attachments/assets/07cb0869-5b9c-461b-99de-30f417b500a9"></video> | --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-05-06 16:16:59 -05:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/pangolin#11603