github-starred/pangolin
2
0
Fork 0
mirror of https://github.com/fosrl/pangolin.git synced 2026-05-21 09:21:15 -05:00
Code Issues 856 Packages Projects Releases 74 Wiki Activity

[PR #1539] [MERGED] [Feature] Update traefik dynamic config to also use resource name #1114

New Issue
Closed
opened 2025-11-13 12:18:31 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2025-11-13 12:18:31 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/fosrl/pangolin/pull/1539
Author: @OddMagnet
Created: 9/25/2025
Status: ✅ Merged
Merged: 10/6/2025
Merged by: @oschwartz10612

Base: main ← Head: feature-add-resource-name-to-resource-id

📝 Commits (2)

  • 9e8e00d Update traefik dynamic config to also use resource name
  • cd285cc Clean up and copy to getTraefikConfig

📊 Changes

3 files changed (+107 additions, -117 deletions)

View changed files

📝 server/lib/traefik/getTraefikConfig.ts (+14 -99)
📝 server/lib/traefik/privateGetTraefikConfig.ts (+12 -18)
➕ server/lib/traefik/utils.ts (+81 -0)

📄 Description

Community Contribution License Agreement

By creating this pull request, I grant the project maintainers an unlimited,
perpetual license to use, modify, and redistribute these contributions under any terms they
choose, including both the AGPLv3 and the Fossorial Commercial license terms. I
represent that I have the right to grant this license for all contributed content.

Description

This PR adds the name of the resource to the dynamic config of Traefik

How to test?

  1. Clone and build the project (see contributing in the docs)
  2. Go through the initial setup process
  3. Create a site (local is fine)
  4. Create a resource
  5. Check http://localhost:3001/api/v1/traefik-config to see that the router and service now are named like this 1-resourceName-router / 1-resourceName-service
  6. Try creating a resource with special-characters and spaces
  7. The name in the dynamic config should be sanitized of all special characters and spaces

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/fosrl/pangolin/pull/1539 **Author:** [@OddMagnet](https://github.com/OddMagnet) **Created:** 9/25/2025 **Status:** ✅ Merged **Merged:** 10/6/2025 **Merged by:** [@oschwartz10612](https://github.com/oschwartz10612) **Base:** `main` ← **Head:** `feature-add-resource-name-to-resource-id` --- ### 📝 Commits (2) - [`9e8e00d`](https://github.com/fosrl/pangolin/commit/9e8e00d4bbf20f2638c823d2847c48bd705d6e46) Update traefik dynamic config to also use resource name - [`cd285cc`](https://github.com/fosrl/pangolin/commit/cd285cc019e233f52f90ccb7a0669ccb4e1b0eed) Clean up and copy to getTraefikConfig ### 📊 Changes **3 files changed** (+107 additions, -117 deletions) <details> <summary>View changed files</summary> 📝 `server/lib/traefik/getTraefikConfig.ts` (+14 -99) 📝 `server/lib/traefik/privateGetTraefikConfig.ts` (+12 -18) ➕ `server/lib/traefik/utils.ts` (+81 -0) </details> ### 📄 Description ## Community Contribution License Agreement By creating this pull request, I grant the project maintainers an unlimited, perpetual license to use, modify, and redistribute these contributions under any terms they choose, including both the AGPLv3 and the Fossorial Commercial license terms. I represent that I have the right to grant this license for all contributed content. ## Description This PR adds the name of the resource to the dynamic config of Traefik ## How to test? 1. Clone and build the project (see [contributing](https://docs.digpangolin.com/development/contributing) in the docs) 2. Go through the initial setup process 3. Create a site (local is fine) 4. Create a resource 5. Check `http://localhost:3001/api/v1/traefik-config` to see that the `router` and `service` now are named like this `1-resourceName-router` / `1-resourceName-service` 6. Try creating a resource with special-characters and spaces 7. The name in the dynamic config should be sanitized of all special characters and spaces --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2025-11-13 12:18:31 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
api
authentication
bug
config
dependencies
docker
documentation
enhancement
good first issue
help wanted
Improvement
Look Into
needs investigating
networking
new feature
non-critical bug
potential bug
pull-request
Mirrored from GitHub Pull Request
 question
reverse proxy
Security
stale
ui
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/pangolin#1114
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?