[PR #1459] [MERGED] Revert "fix: change default integration_api to 3004" #1080

Closed
opened 2025-11-13 12:17:46 -06:00 by GiteaMirror · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/fosrl/pangolin/pull/1459
Author: @SigmaSquadron
Created: 9/14/2025
Status: Merged
Merged: 10/6/2025
Merged by: @oschwartz10612

Base: devHead: revert-1281-push-nymutulytrsq


📝 Commits (1)

  • ee8952d Revert "fix: change default integration_api to 3004"

📊 Changes

1 file changed (+1 additions, -1 deletions)

View changed files

📝 server/lib/readConfigFile.ts (+1 -1)

📄 Description

Reverts fosrl/pangolin#1281. It makes absolutely no sense that Pangolin uses ports 3000-3002, skips 3003, and uses 3004. Gerbil should have been changed instead. This is a particularly annoying inconsistency as it prevents me from elegantly mapping the default pangolin ports in a functional language if I have to arbitrarily skip a number:

da9f816ee7/nixos/modules/services/networking/pangolin/default.nix (L375-L395)

https://github.com/fosrl/gerbil/pull/28


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/fosrl/pangolin/pull/1459 **Author:** [@SigmaSquadron](https://github.com/SigmaSquadron) **Created:** 9/14/2025 **Status:** ✅ Merged **Merged:** 10/6/2025 **Merged by:** [@oschwartz10612](https://github.com/oschwartz10612) **Base:** `dev` ← **Head:** `revert-1281-push-nymutulytrsq` --- ### 📝 Commits (1) - [`ee8952d`](https://github.com/fosrl/pangolin/commit/ee8952de10171831a0d6332ea49b7116627a3c3d) Revert "fix: change default integration_api to 3004" ### 📊 Changes **1 file changed** (+1 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `server/lib/readConfigFile.ts` (+1 -1) </details> ### 📄 Description Reverts fosrl/pangolin#1281. It makes absolutely no sense that Pangolin uses ports 3000-3002, skips 3003, and uses 3004. Gerbil should have been changed instead. This is a particularly annoying inconsistency as it prevents me from elegantly mapping the default pangolin ports in a functional language if I have to arbitrarily skip a number: https://github.com/NixOS/nixpkgs/blob/da9f816ee7211d180eb1bc28f22358b9668b5fbe/nixos/modules/services/networking/pangolin/default.nix#L375-L395 https://github.com/fosrl/gerbil/pull/28 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2025-11-13 12:17:46 -06:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/pangolin#1080