github-starred/pangolin
2
0
Fork 0
mirror of https://github.com/fosrl/pangolin.git synced 2026-05-08 21:59:09 -05:00
Code Issues 564 Packages Projects Releases 72 Wiki Activity

[PR #1431] [MERGED] Fix inconsistent destinationIp validation between create and update APIs #1066

New Issue
Closed
opened 2025-11-13 12:17:25 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2025-11-13 12:17:25 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/fosrl/pangolin/pull/1431
Author: @Pallavikumarimdb
Created: 9/7/2025
Status: ✅ Merged
Merged: 9/8/2025
Merged by: @oschwartz10612

Base: dev ← Head: Fix/site-resource-destinationip-validation

📝 Commits (1)

  • 9e2a58d inconsistent destinationIp validation between create and update

📊 Changes

1 file changed (+1 additions, -1 deletions)

View changed files

📝 server/routers/siteResource/updateSiteResource.ts (+1 -1)

📄 Description

Community Contribution License Agreement

By creating this pull request, I grant the project maintainers an unlimited,
perpetual license to use, modify, and redistribute these contributions under any terms they
choose, including both the AGPLv3 and the Fossorial Commercial license terms. I
represent that I have the right to grant this license for all contributed content.

Description

This PR resolves the inconsistency reported in #1419 and #1426 where the update site resource rejected hostnames (localhost, host.docker.internal, etc.) due to strict .ip() validation, while the create API accepted them.

How to test?

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/fosrl/pangolin/pull/1431 **Author:** [@Pallavikumarimdb](https://github.com/Pallavikumarimdb) **Created:** 9/7/2025 **Status:** ✅ Merged **Merged:** 9/8/2025 **Merged by:** [@oschwartz10612](https://github.com/oschwartz10612) **Base:** `dev` ← **Head:** `Fix/site-resource-destinationip-validation` --- ### 📝 Commits (1) - [`9e2a58d`](https://github.com/fosrl/pangolin/commit/9e2a58dd46c0b8024aca78361c05a2a4f65f3e05) inconsistent destinationIp validation between create and update ### 📊 Changes **1 file changed** (+1 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `server/routers/siteResource/updateSiteResource.ts` (+1 -1) </details> ### 📄 Description ## Community Contribution License Agreement By creating this pull request, I grant the project maintainers an unlimited, perpetual license to use, modify, and redistribute these contributions under any terms they choose, including both the AGPLv3 and the Fossorial Commercial license terms. I represent that I have the right to grant this license for all contributed content. ## Description This PR resolves the inconsistency reported in #1419 and #1426 where the update site resource rejected hostnames (localhost, host.docker.internal, etc.) due to strict .ip() validation, while the create API accepted them. ## How to test? --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2025-11-13 12:17:25 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
api
authentication
bug
config
dependencies
docker
documentation
enhancement
good first issue
help wanted
Improvement
Look Into
needs investigating
networking
new feature
non-critical bug
potential bug
pull-request
Mirrored from GitHub Pull Request
 question
reverse proxy
Security
stale
ui
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/pangolin#1066
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?