github-starred/pangolin
2
0
Fork 0
mirror of https://github.com/fosrl/pangolin.git synced 2026-03-15 11:25:06 -05:00
Code Issues 94 Packages Projects Releases 48 Wiki Activity

[PR #1406] [MERGED] Enter key handling & hostname field reset in resource create #1059

New Issue
Closed
opened 2025-11-13 12:17:16 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2025-11-13 12:17:16 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/fosrl/pangolin/pull/1406
Author: @Pallavikumarimdb
Created: 9/3/2025
Status: ✅ Merged
Merged: 9/15/2025
Merged by: @oschwartz10612

Base: dev ← Head: enhancement-#906/enter-key-form-behavior

📝 Commits (3)

  • 84fb3ad Enter key handling & hostname field reset in resource create
  • 86956b8 fix enter key reload issue
  • 2f89a16 minor fix to domain sanitize when create resources

📊 Changes

5 files changed (+78 additions, -15 deletions)

View changed files

📝 src/app/[orgId]/settings/api-keys/create/page.tsx (+5 -0)
📝 src/app/[orgId]/settings/clients/create/page.tsx (+5 -0)
📝 src/app/[orgId]/settings/resources/create/page.tsx (+58 -15)
📝 src/app/[orgId]/settings/sites/create/page.tsx (+5 -0)
📝 src/app/admin/api-keys/create/page.tsx (+5 -0)

📄 Description

Community Contribution License Agreement

By creating this pull request, I grant the project maintainers an unlimited,
perpetual license to use, modify, and redistribute these contributions under any terms they
choose, including both the AGPLv3 and the Fossorial Commercial license terms. I
represent that I have the right to grant this license for all contributed content.

Description

1. Weird "Enter" Behaviors (Page reload on Enter) (4.5) : #906
Prevented unintended page refresh on Enter that could cause unsaved data loss.

2. Hostname Field Resetting Port/Method inside "Create Resource Page"
(Similar to fix : #1394)
Fixed hostname resetting method and port values.

How to test?

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/fosrl/pangolin/pull/1406 **Author:** [@Pallavikumarimdb](https://github.com/Pallavikumarimdb) **Created:** 9/3/2025 **Status:** ✅ Merged **Merged:** 9/15/2025 **Merged by:** [@oschwartz10612](https://github.com/oschwartz10612) **Base:** `dev` ← **Head:** `enhancement-#906/enter-key-form-behavior` --- ### 📝 Commits (3) - [`84fb3ad`](https://github.com/fosrl/pangolin/commit/84fb3add337df64b7e79fb21d9d7847d9fb9e596) Enter key handling & hostname field reset in resource create - [`86956b8`](https://github.com/fosrl/pangolin/commit/86956b8cacb3f50351d6fa922367a173d0c7a13b) fix enter key reload issue - [`2f89a16`](https://github.com/fosrl/pangolin/commit/2f89a1685213863156d02754bd09ce725340ecd4) minor fix to domain sanitize when create resources ### 📊 Changes **5 files changed** (+78 additions, -15 deletions) <details> <summary>View changed files</summary> 📝 `src/app/[orgId]/settings/api-keys/create/page.tsx` (+5 -0) 📝 `src/app/[orgId]/settings/clients/create/page.tsx` (+5 -0) 📝 `src/app/[orgId]/settings/resources/create/page.tsx` (+58 -15) 📝 `src/app/[orgId]/settings/sites/create/page.tsx` (+5 -0) 📝 `src/app/admin/api-keys/create/page.tsx` (+5 -0) </details> ### 📄 Description ## Community Contribution License Agreement By creating this pull request, I grant the project maintainers an unlimited, perpetual license to use, modify, and redistribute these contributions under any terms they choose, including both the AGPLv3 and the Fossorial Commercial license terms. I represent that I have the right to grant this license for all contributed content. ## Description **1. Weird "Enter" Behaviors (Page reload on Enter) (4.5) : #906** Prevented unintended page refresh on Enter that could cause unsaved data loss. **2. Hostname Field Resetting Port/Method inside "Create Resource Page"** (Similar to fix : #1394) Fixed hostname resetting method and port values. ## How to test? --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2025-11-13 12:17:16 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
api
authentication
bug
config
dependencies
docker
documentation
enhancement
good first issue
help wanted
Improvement
Look Into
needs investigating
networking
new feature
non-critical bug
potential bug
pull-request
Mirrored from GitHub Pull Request
 question
reverse proxy
Security
stale
ui
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/pangolin#1059
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?