[PR #1394] [MERGED] Fix/hostname field reset port and method #1055

New Issue

2025-11-13T12:17:10-06:00

GiteaMirror commented

2025-11-13 12:17:10 -06:00

📋 Pull Request Information

Original PR: https://github.com/fosrl/pangolin/pull/1394
Author: @Pallavikumarimdb
Created: 9/1/2025
Status: ✅ Merged
Merged: 9/1/2025
Merged by: @oschwartz10612

Base: dev ← Head: Fix/hostname-field-reset-port-and-method

📝 Commits (2)

5e5754f preserve port and method on host change
b670e6e update parser to handle h2c

📊 Changes

2 files changed (+53 additions, -20 deletions)

View changed files

📝 src/app/[orgId]/settings/resources/[resourceId]/proxy/page.tsx (+35 -16)
📝 src/lib/parseHostTarget.ts (+18 -4)

📄 Description

Community Contribution License Agreement

By creating this pull request, I grant the project maintainers an unlimited,
perpetual license to use, modify, and redistribute these contributions under any terms they
choose, including both the AGPLv3 and the Fossorial Commercial license terms. I
represent that I have the right to grant this license for all contributed content.

Description

Modified the handlers to only trigger URL parsing when the input actually looks like a URL.

Conditional updates:

Method: Only update if protocol was explicitly provided OR no method currently set
Port: Only update if port was explicitly provided OR no port currently set
IP: Always update (this is the primary field)

Preserve existing values: Plain IP/hostname entries don't trigger parsing at all.
Update the parseHostTarget to support h2c.

Fixes: #1393

How to test?

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/fosrl/pangolin/pull/1394 **Author:** [@Pallavikumarimdb](https://github.com/Pallavikumarimdb) **Created:** 9/1/2025 **Status:** ✅ Merged **Merged:** 9/1/2025 **Merged by:** [@oschwartz10612](https://github.com/oschwartz10612) **Base:** `dev` ← **Head:** `Fix/hostname-field-reset-port-and-method` --- ### 📝 Commits (2) - [`5e5754f`](https://github.com/fosrl/pangolin/commit/5e5754fa6260eb20dcf18c6632472eb091a2ba9e) preserve port and method on host change - [`b670e6e`](https://github.com/fosrl/pangolin/commit/b670e6e3dcdf81e2ee92fb7fe9e494a29e291fed) update parser to handle h2c ### 📊 Changes **2 files changed** (+53 additions, -20 deletions) <details> <summary>View changed files</summary> 📝 `src/app/[orgId]/settings/resources/[resourceId]/proxy/page.tsx` (+35 -16) 📝 `src/lib/parseHostTarget.ts` (+18 -4) </details> ### 📄 Description ## Community Contribution License Agreement By creating this pull request, I grant the project maintainers an unlimited, perpetual license to use, modify, and redistribute these contributions under any terms they choose, including both the AGPLv3 and the Fossorial Commercial license terms. I represent that I have the right to grant this license for all contributed content. ## Description Modified the handlers to only trigger URL parsing when the input actually looks like a URL. **Conditional updates:** - Method: Only update if protocol was explicitly provided OR no method currently set - Port: Only update if port was explicitly provided OR no port currently set - IP: Always update (this is the primary field) **Preserve existing values: Plain IP/hostname entries don't trigger parsing at all. Update the parseHostTarget to support h2c.** Fixes: #1393 ## How to test? --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

GiteaMirror added the pull-request label 2025-11-13 12:17:10 -06:00

GiteaMirror closed this issue