github-starred/pangolin
2
0
Fork 0
mirror of https://github.com/fosrl/pangolin.git synced 2026-05-06 12:55:03 -05:00
Code Issues 564 Packages Projects Releases 72 Wiki Activity

[GH-ISSUE #586] [Bug] Dont show targets updated when you save with no targets #10280

New Issue
Closed
opened 2026-05-06 13:27:06 -05:00 by GiteaMirror · 1 comment
GiteaMirror commented 2026-05-06 13:27:06 -05:00
Owner
Copy Link

Originally created by @wojciehm on GitHub (Apr 24, 2025).
Original GitHub issue: https://github.com/fosrl/pangolin/issues/586

Originally assigned to: @oschwartz10612 on GitHub.

Hi,

I would like to ask to implement validation of newly added resource. I was a bit tired yesterday and I tried to add new resource. I added IP, port etc and I clicked gazzilion times sve target. Even though target is empty the notification appears Targets Updated.

Image

I think it would make sense to validate if anything is entered as target and display notification - please enter target first or sth like that.

Cheers,
Wojciech

Originally created by @wojciehm on GitHub (Apr 24, 2025). Original GitHub issue: https://github.com/fosrl/pangolin/issues/586 Originally assigned to: @oschwartz10612 on GitHub. Hi, I would like to ask to implement validation of newly added resource. I was a bit tired yesterday and I tried to add new resource. I added IP, port etc and I clicked gazzilion times sve target. Even though target is empty the notification appears **Targets Updated**. <img width="1652" alt="Image" src="https://github.com/user-attachments/assets/c3e99dd1-d5d1-4239-ad76-28c40b381b7f" /> I think it would make sense to validate if anything is entered as target and display notification - please enter target first or sth like that. Cheers, Wojciech
GiteaMirror added the wontfix label 2026-05-06 13:27:06 -05:00
GiteaMirror commented 2026-05-06 13:27:08 -05:00
Author
Owner
Copy Link

@ryanehamil commented on GitHub (Jul 31, 2025):

If this does get changed, I would still like it to be valid to save with no targets entered. I do agree that the alert box text could be updated to acknowledge the target list is empty. When I am doing a lot of changes I will sometimes just hit save and leave no targets, then I come back later and populate them. No idea why, must be some lizard brain shit.

<!-- gh-comment-id:3138231595 --> @ryanehamil commented on GitHub (Jul 31, 2025): If this does get changed, I would still like it to be valid to save with no targets entered. I do agree that the alert box text could be updated to acknowledge the target list is empty. When I am doing a lot of changes I will sometimes just hit save and leave no targets, then I come back later and populate them. No idea why, must be some lizard brain shit.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
api
authentication
bug
config
dependencies
docker
documentation
enhancement
good first issue
help wanted
Improvement
Look Into
needs investigating
networking
new feature
non-critical bug
potential bug
pull-request
Mirrored from GitHub Pull Request
 question
reverse proxy
Security
stale
ui
wontfix
No Label wontfix
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/pangolin#10280
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?