[PR #24798] fix: drop unpaired tool_use/tool_result when reconstructing from stored output (#24758) #98890

New Issue

GiteaMirror · 2026-05-16T01:48:20-05:00

GiteaMirror commented

2026-05-16 01:48:20 -05:00

📋 Pull Request Information

Original PR: https://github.com/open-webui/open-webui/pull/24798
Author: @Classic298
Created: 5/15/2026
Status: 🔄 Open

Base: dev ← Head: fix/convert-output-orphan-tool-calls

📝 Commits (1)

8658e0a fix: drop unpaired tool_use/tool_result when reconstructing from stored output (#24758)

📊 Changes

1 file changed (+60 additions, -1 deletions)

View changed files

📝 backend/open_webui/utils/misc.py (+60 -1)

📄 Description

convert_output_to_messages() emitted an assistant tool_calls entry with no following tool message whenever a function_call_output was missing from the stored output (e.g. lost when a knowledge base is updated mid-chat, or a tool call interrupted before its result was written). Strict providers (Anthropic, AWS Bedrock Converse) reject the resulting history with a 400: "tool_use ids were found without tool_result blocks".

Add a reconciliation pass after flush_pending() that strips any assistant tool_call whose id has no matching tool message, drops an assistant message left empty by that stripping, and symmetrically drops a tool message whose tool_call_id has no surviving tool_call. Well-formed output is unaffected: every id pairs, so nothing is stripped (verified no-op for single and multi-call batches).

Contributor License Agreement

By submitting this pull request, I confirm that I have read and fully agree to the Contributor License Agreement (CLA), and I am providing my contributions under its terms.

Note

Deleting the CLA section will lead to immediate closure of your PR and it will not be merged in.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/open-webui/open-webui/pull/24798 **Author:** [@Classic298](https://github.com/Classic298) **Created:** 5/15/2026 **Status:** 🔄 Open **Base:** `dev` ← **Head:** `fix/convert-output-orphan-tool-calls` --- ### 📝 Commits (1) - [`8658e0a`](https://github.com/open-webui/open-webui/commit/8658e0a26a3a0f47371109a37c3e5bcd520be407) fix: drop unpaired tool_use/tool_result when reconstructing from stored output (#24758) ### 📊 Changes **1 file changed** (+60 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `backend/open_webui/utils/misc.py` (+60 -1) </details> ### 📄 Description convert_output_to_messages() emitted an assistant tool_calls entry with no following tool message whenever a function_call_output was missing from the stored output (e.g. lost when a knowledge base is updated mid-chat, or a tool call interrupted before its result was written). Strict providers (Anthropic, AWS Bedrock Converse) reject the resulting history with a 400: "tool_use ids were found without tool_result blocks". Add a reconciliation pass after flush_pending() that strips any assistant tool_call whose id has no matching tool message, drops an assistant message left empty by that stripping, and symmetrically drops a tool message whose tool_call_id has no surviving tool_call. Well-formed output is unaffected: every id pairs, so nothing is stripped (verified no-op for single and multi-call batches). ### Contributor License Agreement  - [x] By submitting this pull request, I confirm that I have read and fully agree to the [Contributor License Agreement (CLA)](https://github.com/open-webui/open-webui/blob/main/CONTRIBUTOR_LICENSE_AGREEMENT), and I am providing my contributions under its terms. > [!NOTE] > Deleting the CLA section will lead to immediate closure of your PR and it will not be merged in. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

GiteaMirror added the pull-request label 2026-05-16 01:48:20 -05:00

Sign in to join this conversation.

Branches Tags

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: github-starred/open-webui#98890