[PR #24683] [MERGED] fix: default WEB_LOADER_ENGINE in start.sh to avoid unbound-variable … #98815

New Issue

GiteaMirror · 2026-05-16T01:40:56-05:00

GiteaMirror commented

2026-05-16 01:40:56 -05:00

📋 Pull Request Information

Original PR: https://github.com/open-webui/open-webui/pull/24683
Author: @Classic298
Created: 5/13/2026
Status: ✅ Merged
Merged: 5/15/2026
Merged by: @tjbck

Base: dev ← Head: fix/start-sh-unbound-web-loader-engine

📝 Commits (1)

ed28dda fix: default optional env vars used with bash ,, in start.sh

📊 Changes

1 file changed (+6 additions, -0 deletions)

View changed files

📝 backend/start.sh (+6 -0)

📄 Description

…crash

start.sh runs with set -euo pipefail, but the playwright-install branch references ${WEB_LOADER_ENGINE,,} without a :- default. Containers that don't set WEB_LOADER_ENGINE in their env — the default for every deployment that isn't explicitly using playwright/firecrawl/tavily — crash on startup with:

start.sh: line 15: WEB_LOADER_ENGINE: unbound variable

Introduced by 070ab2650 (refac: reorganize scripts and ci workflows). Every other env-var reference in start.sh already uses :-; this one was missed because bash's ,, lowercase expansion can't be combined with :- in a single substitution. Splitting into two steps keeps the lowercase comparison intact.

Contributor License Agreement

By submitting this pull request, I confirm that I have read and fully agree to the Contributor License Agreement (CLA), and I am providing my contributions under its terms.

Note

Deleting the CLA section will lead to immediate closure of your PR and it will not be merged in.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/open-webui/open-webui/pull/24683 **Author:** [@Classic298](https://github.com/Classic298) **Created:** 5/13/2026 **Status:** ✅ Merged **Merged:** 5/15/2026 **Merged by:** [@tjbck](https://github.com/tjbck) **Base:** `dev` ← **Head:** `fix/start-sh-unbound-web-loader-engine` --- ### 📝 Commits (1) - [`ed28dda`](https://github.com/open-webui/open-webui/commit/ed28ddab4a6ed74ad101ac51dc6cf8e114e07adc) fix: default optional env vars used with bash `,,` in start.sh ### 📊 Changes **1 file changed** (+6 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `backend/start.sh` (+6 -0) </details> ### 📄 Description …crash start.sh runs with `set -euo pipefail`, but the playwright-install branch references `${WEB_LOADER_ENGINE,,}` without a `:-` default. Containers that don't set WEB_LOADER_ENGINE in their env — the default for every deployment that isn't explicitly using playwright/firecrawl/tavily — crash on startup with: start.sh: line 15: WEB_LOADER_ENGINE: unbound variable Introduced by 070ab2650 (refac: reorganize scripts and ci workflows). Every other env-var reference in start.sh already uses `:-`; this one was missed because bash's `,,` lowercase expansion can't be combined with `:-` in a single substitution. Splitting into two steps keeps the lowercase comparison intact. ### Contributor License Agreement  - [x] By submitting this pull request, I confirm that I have read and fully agree to the [Contributor License Agreement (CLA)](https://github.com/open-webui/open-webui/blob/main/CONTRIBUTOR_LICENSE_AGREEMENT), and I am providing my contributions under its terms. > [!NOTE] > Deleting the CLA section will lead to immediate closure of your PR and it will not be merged in. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

GiteaMirror added the pull-request label 2026-05-16 01:40:56 -05:00

GiteaMirror closed this issue

2026-05-16 01:40:59 -05:00

Sign in to join this conversation.

Branches Tags

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: github-starred/open-webui#98815