[PR #24588] [MERGED] fix: validate folder_id ownership on chat create + folder-update endpoints #98768

New Issue

GiteaMirror · 2026-05-16T01:36:51-05:00

GiteaMirror commented

2026-05-16 01:36:51 -05:00

📋 Pull Request Information

Original PR: https://github.com/open-webui/open-webui/pull/24588
Author: @Classic298
Created: 5/11/2026
Status: ✅ Merged
Merged: 5/13/2026
Merged by: @tjbck

Base: dev ← Head: fix/chats-new-validate-folder-ownership

📝 Commits (1)

ccc37eb fix: validate folder_id ownership on chat create + folder-update endpoints

📊 Changes

1 file changed (+21 additions, -0 deletions)

View changed files

📝 backend/open_webui/routers/chats.py (+21 -0)

📄 Description

POST /api/v1/chats/new and POST /api/v1/chats/{id}/folder accepted a caller-supplied folder_id with no validation — neither ownership, nor existence, nor UUID format. The row was persisted with the supplied value verbatim, so the DB ended up with chat rows whose folder_id referenced another user's folder, a non-existent UUID, or even a non-UUID string.

No read path surfaces this across users — every chat-folder read is user_id-filtered on both sides — so this is referential-integrity hardening rather than a security boundary fix. But there's no reason to accept dangling references either, and the downstream consumers shouldn't have to assume the column is clean.

Add a Folders.get_folder_by_id_and_user_id() lookup at both writers: if a folder_id is supplied, it must match a folder owned by the caller. None remains allowed (chat-without-folder is the default). Non-existent and non-UUID values fall through to 404.

Contributor License Agreement

By submitting this pull request, I confirm that I have read and fully agree to the Contributor License Agreement (CLA), and I am providing my contributions under its terms.

Note

Deleting the CLA section will lead to immediate closure of your PR and it will not be merged in.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/open-webui/open-webui/pull/24588 **Author:** [@Classic298](https://github.com/Classic298) **Created:** 5/11/2026 **Status:** ✅ Merged **Merged:** 5/13/2026 **Merged by:** [@tjbck](https://github.com/tjbck) **Base:** `dev` ← **Head:** `fix/chats-new-validate-folder-ownership` --- ### 📝 Commits (1) - [`ccc37eb`](https://github.com/open-webui/open-webui/commit/ccc37ebf7ba05cf8e48f5ffd7b066a55ef69382f) fix: validate folder_id ownership on chat create + folder-update endpoints ### 📊 Changes **1 file changed** (+21 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `backend/open_webui/routers/chats.py` (+21 -0) </details> ### 📄 Description POST /api/v1/chats/new and POST /api/v1/chats/{id}/folder accepted a caller-supplied folder_id with no validation — neither ownership, nor existence, nor UUID format. The row was persisted with the supplied value verbatim, so the DB ended up with chat rows whose folder_id referenced another user's folder, a non-existent UUID, or even a non-UUID string. No read path surfaces this across users — every chat-folder read is user_id-filtered on both sides — so this is referential-integrity hardening rather than a security boundary fix. But there's no reason to accept dangling references either, and the downstream consumers shouldn't have to assume the column is clean. Add a Folders.get_folder_by_id_and_user_id() lookup at both writers: if a folder_id is supplied, it must match a folder owned by the caller. None remains allowed (chat-without-folder is the default). Non-existent and non-UUID values fall through to 404. ### Contributor License Agreement  - [x] By submitting this pull request, I confirm that I have read and fully agree to the [Contributor License Agreement (CLA)](https://github.com/open-webui/open-webui/blob/main/CONTRIBUTOR_LICENSE_AGREEMENT), and I am providing my contributions under its terms. > [!NOTE] > Deleting the CLA section will lead to immediate closure of your PR and it will not be merged in. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

GiteaMirror added the pull-request label 2026-05-16 01:36:51 -05:00

GiteaMirror closed this issue

2026-05-16 01:36:53 -05:00

Sign in to join this conversation.

Branches Tags

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: github-starred/open-webui#98768