[PR #24520] [CLOSED] fix: sandbox terminal proxy responses to prevent cross-user XSS via uploaded HTML #98741

New Issue

2026-05-16T01:34:58-05:00

GiteaMirror commented

2026-05-16 01:34:58 -05:00

📋 Pull Request Information

Original PR: https://github.com/open-webui/open-webui/pull/24520
Author: @Classic298
Created: 5/9/2026
Status: ❌ Closed

Base: dev ← Head: fix/terminal-proxy-xss-sandbox-headers

📝 Commits (1)

95122d7 fix: sandbox terminal proxy responses to prevent cross-user XSS via uploaded HTML

📊 Changes

1 file changed (+11 additions, -0 deletions)

View changed files

📝 backend/open_webui/routers/terminals.py (+11 -0)

📄 Description

Terminal proxy at /api/v1/terminals/{server_id}/{path:path} forwarded the upstream Content-Type verbatim with no Content-Security-Policy or X-Content-Type-Options. A terminal-trusted user could host an HTML file on a port reachable through the proxy; another user with access to the same terminal server who opened the proxy URL would render that HTML under open-webui's same origin and a <script> payload could read localStorage.token for full session theft → ATO.

Contributor License Agreement

By submitting this pull request, I confirm that I have read and fully agree to the Contributor License Agreement (CLA), and I am providing my contributions under its terms.

Note

Deleting the CLA section will lead to immediate closure of your PR and it will not be merged in.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/open-webui/open-webui/pull/24520 **Author:** [@Classic298](https://github.com/Classic298) **Created:** 5/9/2026 **Status:** ❌ Closed **Base:** `dev` ← **Head:** `fix/terminal-proxy-xss-sandbox-headers` --- ### 📝 Commits (1) - [`95122d7`](https://github.com/open-webui/open-webui/commit/95122d72e8c83095b9ecc14df5c13c6cc3cb0fd3) fix: sandbox terminal proxy responses to prevent cross-user XSS via uploaded HTML ### 📊 Changes **1 file changed** (+11 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `backend/open_webui/routers/terminals.py` (+11 -0) </details> ### 📄 Description Terminal proxy at /api/v1/terminals/{server_id}/{path:path} forwarded the upstream Content-Type verbatim with no Content-Security-Policy or X-Content-Type-Options. A terminal-trusted user could host an HTML file on a port reachable through the proxy; another user with access to the same terminal server who opened the proxy URL would render that HTML under open-webui's same origin and a `<script>` payload could read `localStorage.token` for full session theft → ATO. ### Contributor License Agreement  - [x] By submitting this pull request, I confirm that I have read and fully agree to the [Contributor License Agreement (CLA)](https://github.com/open-webui/open-webui/blob/main/CONTRIBUTOR_LICENSE_AGREEMENT), and I am providing my contributions under its terms. > [!NOTE] > Deleting the CLA section will lead to immediate closure of your PR and it will not be merged in. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

GiteaMirror added the pull-request label 2026-05-16 01:34:58 -05:00

GiteaMirror closed this issue

2026-05-16 01:35:01 -05:00

Sign in to join this conversation.

Branches Tags

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: github-starred/open-webui#98741