[PR #23871] [CLOSED] fix: personal open-terminal connection status storage and terminal button visibility #98457

New Issue

2026-05-16T01:16:05-05:00

GiteaMirror commented

2026-05-16 01:16:05 -05:00

📋 Pull Request Information

Original PR: https://github.com/open-webui/open-webui/pull/23871
Author: @silenceroom
Created: 4/19/2026
Status: ❌ Closed

Base: dev ← Head: fix/terminal_button_visibility

📝 Commits (2)

bcca7c4 fix: hide terminal button when no terminals are enabled and fix toggle persistence
4aebed7 fix: clear selectedTerminalId when terminal is deleted or renamed

📊 Changes

5 files changed (+14 additions, -7 deletions)

View changed files

📝 src/lib/components/chat/MessageInput.svelte (+1 -1)
📝 src/lib/components/chat/MessageInput/TerminalMenu.svelte (+1 -1)
📝 src/lib/components/chat/Settings/Integrations.svelte (+9 -2)
📝 src/lib/components/chat/Settings/Integrations/Terminals/Connection.svelte (+1 -1)
📝 src/lib/components/common/Switch.svelte (+2 -2)

📄 Description

Pull Request Checklist

Note to first-time contributors: Please open a discussion post in Discussions to discuss your idea/fix with the community before creating a pull request, and describe your changes before submitting a pull request.

This is to ensure large feature PRs are discussed with the community first, before starting work on it. If the community does not want this feature or it is not relevant for Open WebUI as a project, it can be identified in the discussion before working on the feature and submitting the PR.

Before submitting, make sure you've checked the following:

Target branch: Verify that the pull request targets the dev branch. PRs targeting main will be immediately closed.
Description: Provide a concise description of the changes made in this pull request down below.
Changelog: Ensure a changelog entry following the format of Keep a Changelog is added at the bottom of the PR description.
Documentation: Add docs in Open WebUI Docs Repository. Document user-facing behavior, environment variables, public APIs/interfaces, or deployment steps.
Dependencies: Are there any new or upgraded dependencies? If so, explain why, update the changelog/docs, and include any compatibility notes. Actually run the code/function that uses updated library to ensure it doesn't crash.
Testing: Perform manual tests to verify the implemented fix/feature works as intended AND does not break any other functionality. Include reproducible steps to demonstrate the issue before the fix. Test edge cases (URL encoding, HTML entities, types). Take this as an opportunity to make screenshots of the feature/fix and include them in the PR description.
Agentic AI Code: Confirm this Pull Request is not written by any AI Agent or has at least gone through additional human review AND manual testing. If any AI Agent is the co-author of this PR, it may lead to immediate closure of the PR.
Code review: Have you performed a self-review of your code, addressing any coding standard issues and ensuring adherence to the project's coding standards?
Design & Architecture: Prefer smart defaults over adding new settings; use local state for ephemeral UI logic. Open a Discussion for major architectural or UX changes.
Git Hygiene: Keep PRs atomic (one logical change). Clean up commits and rebase on dev to ensure no unrelated commits (e.g. from main) are included. Push updates to the existing PR branch instead of closing and reopening.
Title Prefix: To clearly categorize this pull request, prefix the pull request title using one of the following:
- BREAKING CHANGE: Significant changes that may affect compatibility
- build: Changes that affect the build system or external dependencies
- ci: Changes to our continuous integration processes or workflows
- chore: Refactor, cleanup, or other non-functional code changes
- docs: Documentation update or addition
- feat: Introduces a new feature or enhancement to the codebase
- fix: Bug fix or error correction
- i18n: Internationalization or localization changes
- perf: Performance improvement
- refactor: Code restructuring for better maintainability, readability, or scalability
- style: Changes that do not affect the meaning of the code (white space, formatting, missing semi-colons, etc.)
- test: Adding missing tests or correcting existing tests
- WIP: Work in progress, a temporary label for incomplete or ongoing work

Changelog Entry

Description

This PR fixed below problems related to open-terminal connections under personal settings:

When disable/enable the Open-Terminal connections via personal integrations, the status reverseback after refresh the page.
Hide the Terminal button in the chatbox when there is no available Open-Terminal connections.

Added

[List any new features, functionalities, or additions]

Changed

Switch component (Switch.svelte): onCheckedChange callback and dispatch('change') now correctly pass the new toggled value (newValue) instead of the old state, fixing incorrect event data passed to parent components.
Terminal button visibility (MessageInput.svelte, TerminalMenu.svelte): Filter condition changed from s.url to s.url && s.enabled, ensuring only enabled terminal servers show the Terminal button or appear in the menu.
Terminal enabled state restoration (Chat.svelte): Loading logic now respects the enabled flag when restoring terminal state from localStorage.

Deprecated

None

Removed

None

Fixed

Terminal toggle direction (Terminals/Connection.svelte): Switch enable/disable operations were reversed due to the Switch component bug, now working correctly.
Stale terminal state (Integrations.svelte): selectedTerminalId is now automatically cleared to null when saving if the currently selected terminal has been disabled, preventing residual stale state.

Security

None

Breaking Changes

None

Test Plan

Disable all terminals in Terminal settings page, confirm Terminal button no longer appears in the message input
Re-enable a terminal, confirm Terminal button appears correctly
Repeatedly toggle Terminal switch states, confirm enable/disable direction is correct

Contributor License Agreement

By submitting this pull request, I confirm that I have read and fully agree to the Contributor License Agreement (CLA), and I am providing my contributions under its terms.

Note

Deleting the CLA section will lead to immediate closure of your PR and it will not be merged in.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/open-webui/open-webui/pull/23871 **Author:** [@silenceroom](https://github.com/silenceroom) **Created:** 4/19/2026 **Status:** ❌ Closed **Base:** `dev` ← **Head:** `fix/terminal_button_visibility` --- ### 📝 Commits (2) - [`bcca7c4`](https://github.com/open-webui/open-webui/commit/bcca7c437312f525b3ed8bb34a97e5f34871edf9) fix: hide terminal button when no terminals are enabled and fix toggle persistence - [`4aebed7`](https://github.com/open-webui/open-webui/commit/4aebed750dff29fbac3f91e22dd214e7337841b8) fix: clear selectedTerminalId when terminal is deleted or renamed ### 📊 Changes **5 files changed** (+14 additions, -7 deletions) <details> <summary>View changed files</summary> 📝 `src/lib/components/chat/MessageInput.svelte` (+1 -1) 📝 `src/lib/components/chat/MessageInput/TerminalMenu.svelte` (+1 -1) 📝 `src/lib/components/chat/Settings/Integrations.svelte` (+9 -2) 📝 `src/lib/components/chat/Settings/Integrations/Terminals/Connection.svelte` (+1 -1) 📝 `src/lib/components/common/Switch.svelte` (+2 -2) </details> ### 📄 Description  # Pull Request Checklist ### Note to first-time contributors: Please open a discussion post in [Discussions](https://github.com/open-webui/open-webui/discussions) to discuss your idea/fix with the community before creating a pull request, and describe your changes before submitting a pull request. This is to ensure large feature PRs are discussed with the community first, before starting work on it. If the community does not want this feature or it is not relevant for Open WebUI as a project, it can be identified in the discussion before working on the feature and submitting the PR. **Before submitting, make sure you've checked the following:** - [x] **Target branch:** Verify that the pull request targets the `dev` branch. **PRs targeting `main` will be immediately closed.** - [x] **Description:** Provide a concise description of the changes made in this pull request down below. - [x] **Changelog:** Ensure a changelog entry following the format of [Keep a Changelog](https://keepachangelog.com/) is added at the bottom of the PR description. - [x] **Documentation:** Add docs in [Open WebUI Docs Repository](https://github.com/open-webui/docs). Document user-facing behavior, environment variables, public APIs/interfaces, or deployment steps. - [x] **Dependencies:** Are there any new or upgraded dependencies? If so, explain why, update the changelog/docs, and include any compatibility notes. Actually run the code/function that uses updated library to ensure it doesn't crash. - [x] **Testing:** Perform manual tests to **verify the implemented fix/feature works as intended AND does not break any other functionality**. Include reproducible steps to demonstrate the issue before the fix. Test edge cases (URL encoding, HTML entities, types). Take this as an opportunity to **make screenshots of the feature/fix and include them in the PR description**. - [x] **Agentic AI Code:** Confirm this Pull Request is **not written by any AI Agent** or has at least **gone through additional human review AND manual testing**. If any AI Agent is the co-author of this PR, it may lead to immediate closure of the PR. - [x] **Code review:** Have you performed a self-review of your code, addressing any coding standard issues and ensuring adherence to the project's coding standards? - [x] **Design & Architecture:** Prefer smart defaults over adding new settings; use local state for ephemeral UI logic. Open a Discussion for major architectural or UX changes. - [x] **Git Hygiene:** Keep PRs atomic (one logical change). Clean up commits and rebase on `dev` to ensure no unrelated commits (e.g. from `main`) are included. Push updates to the existing PR branch instead of closing and reopening. - [x] **Title Prefix:** To clearly categorize this pull request, prefix the pull request title using one of the following: - **BREAKING CHANGE**: Significant changes that may affect compatibility - **build**: Changes that affect the build system or external dependencies - **ci**: Changes to our continuous integration processes or workflows - **chore**: Refactor, cleanup, or other non-functional code changes - **docs**: Documentation update or addition - **feat**: Introduces a new feature or enhancement to the codebase - **fix**: Bug fix or error correction - **i18n**: Internationalization or localization changes - **perf**: Performance improvement - **refactor**: Code restructuring for better maintainability, readability, or scalability - **style**: Changes that do not affect the meaning of the code (white space, formatting, missing semi-colons, etc.) - **test**: Adding missing tests or correcting existing tests - **WIP**: Work in progress, a temporary label for incomplete or ongoing work # Changelog Entry ### Description This PR fixed below problems related to open-terminal connections under personal settings: 1. When disable/enable the Open-Terminal connections via personal integrations, the status reverseback after refresh the page. 2. Hide the Terminal button in the chatbox when there is no available Open-Terminal connections. ### Added - [List any new features, functionalities, or additions] ### Changed - **Switch component** (`Switch.svelte`): `onCheckedChange` callback and `dispatch('change')` now correctly pass the new toggled value (`newValue`) instead of the old state, fixing incorrect event data passed to parent components. - **Terminal button visibility** (`MessageInput.svelte`, `TerminalMenu.svelte`): Filter condition changed from `s.url` to `s.url && s.enabled`, ensuring only enabled terminal servers show the Terminal button or appear in the menu. - **Terminal enabled state restoration** (`Chat.svelte`): Loading logic now respects the `enabled` flag when restoring terminal state from localStorage. ### Deprecated - None ### Removed - None ### Fixed - **Terminal toggle direction** (`Terminals/Connection.svelte`): Switch enable/disable operations were reversed due to the Switch component bug, now working correctly. - **Stale terminal state** (`Integrations.svelte`): `selectedTerminalId` is now automatically cleared to `null` when saving if the currently selected terminal has been disabled, preventing residual stale state. ### Security - None ### Breaking Changes - None --- ### Test Plan - [x] Disable all terminals in Terminal settings page, confirm Terminal button no longer appears in the message input - [x] Re-enable a terminal, confirm Terminal button appears correctly - [x] Repeatedly toggle Terminal switch states, confirm enable/disable direction is correct ### Contributor License Agreement  - [x] By submitting this pull request, I confirm that I have read and fully agree to the [Contributor License Agreement (CLA)](https://github.com/open-webui/open-webui/blob/main/CONTRIBUTOR_LICENSE_AGREEMENT), and I am providing my contributions under its terms. > [!NOTE] > Deleting the CLA section will lead to immediate closure of your PR and it will not be merged in. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

GiteaMirror added the pull-request label 2026-05-16 01:16:05 -05:00

GiteaMirror closed this issue

2026-05-16 01:16:07 -05:00

Sign in to join this conversation.

Branches Tags

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: github-starred/open-webui#98457