github-starred/open-webui
2
0
Fork 0
mirror of https://github.com/open-webui/open-webui.git synced 2026-08-24 14:23:59 -05:00
Code Issues 2.4k Packages Projects Releases 129 Wiki Activity

[PR #23509] [CLOSED] fix(ui): polish grouped tool-call stack statuses and grouped summary behavior plus tool icons and group specific name #98264

New Issue
Closed
opened 2026-05-16 01:02:45 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-05-16 01:02:45 -05:00
Owner
Copy Link
Copy Source

📋 Pull Request Information

Original PR: https://github.com/open-webui/open-webui/pull/23509
Author: @wdp-2010
Created: 4/8/2026
Status: ❌ Closed

Base: dev ← Head: main

📝 Commits (2)

  • f4f11d6 feat(ui): improve grouped tool-call summaries and status rendering
  • ae24b51 fix(ui): restore iframe args flow and align note-memory rule names

📊 Changes

7 files changed (+3067 additions, -182 deletions)

View changed files

➕ docs/TOOL_CALL_GROUPING.md (+132 -0)
📝 src/lib/components/chat/Messages/Markdown/ConsecutiveDetailsGroup.svelte (+327 -26)
📝 src/lib/components/chat/Messages/Markdown/MarkdownTokens.svelte (+71 -17)
📝 src/lib/components/common/FullHeightIframe.svelte (+6 -6)
📝 src/lib/components/common/ToolCallDisplay.svelte (+1802 -133)
➕ src/lib/utils/toolCallInlineStyles.ts (+12 -0)
➕ src/lib/utils/toolCallPresentation.ts (+717 -0)

📄 Description

feat(ui): polish grouped tool-call summaries, status stacks, and grouping rules

Pull Request Checklist

Note to first-time contributors: Please open a discussion post in Discussions to discuss your idea/fix with the community before creating a pull request, and describe your changes before submitting a pull request.

This is to ensure large feature PRs are discussed with the community first, before starting work on it. If the community does not want this feature or it is not relevant for Open WebUI as a project, it can be identified in the discussion before working on the feature and submitting the PR.

Before submitting, make sure you've checked the following:

  • Target branch: Verify that the pull request targets the dev branch. PRs targeting main will be immediately closed.
  • Description: Provide a concise description of the changes made in this pull request down below.
  • Changelog: Ensure a changelog entry following the format of Keep a Changelog is added at the bottom of the PR description.
  • Documentation: Add docs in Open WebUI Docs Repository. Document user-facing behavior, environment variables, public APIs/interfaces, or deployment steps.
  • Dependencies: Are there any new or upgraded dependencies? If so, explain why, update the changelog/docs, and include any compatibility notes. Actually run the code/function that uses updated library to ensure it doesn't crash.
  • Testing: Perform manual tests to verify the implemented fix/feature works as intended AND does not break any other functionality. Include reproducible steps to demonstrate the issue before the fix. Test edge cases (URL encoding, HTML entities, types). Take this as an opportunity to make screenshots of the feature/fix and include them in the PR description.
  • Agentic AI Code: Confirm this Pull Request has gone through additional human review AND manual testing.
  • Code review: Have you performed a self-review of your code, addressing any coding standard issues and ensuring adherence to the project's coding standards?
  • Design & Architecture: Prefer smart defaults over adding new settings; use local state for ephemeral UI logic. Open a Discussion for major architectural or UX changes.
  • Git Hygiene: Keep PRs atomic (one logical change). Clean up commits and rebase on dev to ensure no unrelated commits (e.g. from main) are included. Push updates to the existing PR branch instead of closing and reopening.
  • Title Prefix: To clearly categorize this pull request, prefix the pull request title using one of the following:
    • BREAKING CHANGE: Significant changes that may affect compatibility
    • build: Changes that affect the build system or external dependencies
    • ci: Changes to our continuous integration processes or workflows
    • chore: Refactor, cleanup, or other non-functional code changes
    • docs: Documentation update or addition
    • feat: Introduces a new feature or enhancement to the codebase
    • fix: Bug fix or error correction
    • i18n: Internationalization or localization changes
    • perf: Performance improvement
    • refactor: Code restructuring for better maintainability, readability, or scalability
    • style: Changes that do not affect the meaning of the code (white space, formatting, missing semi-colons, etc.)
    • test: Adding missing tests or correcting existing tests
    • WIP: Work in progress, a temporary label for incomplete or ongoing work

Changelog Entry

MOST CODE GENERATED WITH GITHUB COPILOT (codex 5.3 and haiku 4.5) VERIFIED BY HUMAN

NOTE THAT I'M NOT A CODER AND I KNOW VERY LITTLE ABOUT SVELTE AND THE WHOLE STACK
Sorry in advance, feel free to ignore this pr, i thought it did really good work and might be very useful for this project and i also think it did a good job on design, most of the design comes from me, generated and executed by COPILOT

Human filled in:

Description

A redesign of the agent tool call, with tool specific icons, grouping of tool batches and clean animations
The tools are either grouped and named with a tool combination name such as searched the web the icons are status regarded:

  • Gray for empty response such as no search results
  • Green for succes
  • Red for failiure

The groups are provided with a icons stack so its clean and clear to the user what the model just did.

Added

  • Added a centralized tool presentation layer in toolCallPresentation.ts (icon, labels, semantic classification, layout metadata, and fallback inference).
  • Added a rule-based grouped summary system with ordered matching and explicit matcher types (allOf, anyOf, noneOf, onlyOf).
  • Added a new bounded combination rule for web research + code execution (web.search_and_execute_code).
  • Added shared inline tool-row style constants in toolCallInlineStyles.ts for consistent grouped UI spacing/alignment.
  • Added grouped status parsing utilities for failed/success/neutral outcomes, including no-results detection for discovery tools.
  • Added per-icon status stack aggregation that supports mixed outcomes for the same tool icon.
  • Added grouped token metadata (detail_group, groupClosed) and grouped done-state normalization helpers in markdown token processing.
  • Added grouped connector visuals and closed-group completion indicator (“Done”) in grouped tool-call UI.
  • Added docs/TOOL_CALL_GROUPING.md with matcher semantics, ordering strategy, and concrete rule examples.
  • Added docs index entries in docs/README.md that expose and summarize tool grouping documentation.

Changed

  • Changed grouped summary header from a single generic success icon to semantic stacked tool icons.
  • Changed grouped summary state coloring to consistently reflect failed, success, and neutral outcomes.
  • Changed grouped expand/collapse motion to transform-based transitions with stable anchoring and reduced jitter.
  • Changed grouped summary text behavior so named rule matches can suppress redundant raw detail text.
  • Changed grouped pending/done computation to rely on last tool-call completion and explicit group closure state.
  • Changed markdown token grouping to produce cleaner grouped tool-call blocks with proper continuity lines.
  • Changed tool call card rendering to use centralized presentation metadata (labels, icons, and semantics) across grouped and non-grouped views.
  • Changed result presentation in ToolCallDisplay.svelte from mostly generic JSON/text blocks to tool-aware sections (search, notes, memory, code, knowledge, and timestamp outputs).
  • Changed tool call expand animation to opacity-only entry for smoother, less distracting transitions.
  • Changed docs structure to include a dedicated grouping guide and an updated docs index entry for discoverability.

Deprecated

  • None.

Removed

  • Removed positional nudge from expand animation keyframes (opacity-only entry animation retained).

Fixed

  • Fixed icon stack drift/jitter during collapse in grouped summaries.
  • Fixed mixed-status stack ordering so status layers follow encounter order per tool icon.
  • Fixed no-result discovery calls being shown as success; these now render as neutral/gray where appropriate.
  • Fixed grouped completion signaling so closed grouped flows consistently render a terminal done state.
  • Fixed rule matching precision by adding bounded onlyOf support to prevent broad over-matching.
  • Fixed documentation drift by aligning matcher docs (allOf, anyOf, noneOf, onlyOf) with implementation.

Security

  • No security-impacting changes.

Breaking Changes

  • BREAKING CHANGE: None.

Additional Information

Screenshots or Videos

https://github.com/user-attachments/assets/87262da4-f25c-4ff7-9e6b-b6f1c173ed17

image image

Excuse me for the random search results

Contributor License Agreement

Note

Deleting the CLA section will lead to immediate closure of your PR and it will not be merged in.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/open-webui/open-webui/pull/23509 **Author:** [@wdp-2010](https://github.com/wdp-2010) **Created:** 4/8/2026 **Status:** ❌ Closed **Base:** `dev` ← **Head:** `main` --- ### 📝 Commits (2) - [`f4f11d6`](https://github.com/open-webui/open-webui/commit/f4f11d667d146346b10de05b8fb84de46178d275) feat(ui): improve grouped tool-call summaries and status rendering - [`ae24b51`](https://github.com/open-webui/open-webui/commit/ae24b516593db3c6519f8932854a30ad43b91d6f) fix(ui): restore iframe args flow and align note-memory rule names ### 📊 Changes **7 files changed** (+3067 additions, -182 deletions) <details> <summary>View changed files</summary> ➕ `docs/TOOL_CALL_GROUPING.md` (+132 -0) 📝 `src/lib/components/chat/Messages/Markdown/ConsecutiveDetailsGroup.svelte` (+327 -26) 📝 `src/lib/components/chat/Messages/Markdown/MarkdownTokens.svelte` (+71 -17) 📝 `src/lib/components/common/FullHeightIframe.svelte` (+6 -6) 📝 `src/lib/components/common/ToolCallDisplay.svelte` (+1802 -133) ➕ `src/lib/utils/toolCallInlineStyles.ts` (+12 -0) ➕ `src/lib/utils/toolCallPresentation.ts` (+717 -0) </details> ### 📄 Description # feat(ui): polish grouped tool-call summaries, status stacks, and grouping rules <!-- ⚠️ CRITICAL CHECKS FOR CONTRIBUTORS (READ, DON'T DELETE) ⚠️ 1. Target the `dev` branch. PRs targeting `main` will be automatically closed. 2. Do NOT delete the CLA section at the bottom. It is required for the bot to accept your PR. --> # Pull Request Checklist ### Note to first-time contributors: Please open a discussion post in [Discussions](https://github.com/open-webui/open-webui/discussions) to discuss your idea/fix with the community before creating a pull request, and describe your changes before submitting a pull request. This is to ensure large feature PRs are discussed with the community first, before starting work on it. If the community does not want this feature or it is not relevant for Open WebUI as a project, it can be identified in the discussion before working on the feature and submitting the PR. **Before submitting, make sure you've checked the following:** - [x] **Target branch:** Verify that the pull request targets the `dev` branch. **PRs targeting `main` will be immediately closed.** - [x] **Description:** Provide a concise description of the changes made in this pull request down below. - [x] **Changelog:** Ensure a changelog entry following the format of [Keep a Changelog](https://keepachangelog.com/) is added at the bottom of the PR description. - [ ] **Documentation:** Add docs in [Open WebUI Docs Repository](https://github.com/open-webui/docs). Document user-facing behavior, environment variables, public APIs/interfaces, or deployment steps. - [x] **Dependencies:** Are there any new or upgraded dependencies? If so, explain why, update the changelog/docs, and include any compatibility notes. Actually run the code/function that uses updated library to ensure it doesn't crash. - [x] **Testing:** Perform manual tests to **verify the implemented fix/feature works as intended AND does not break any other functionality**. Include reproducible steps to demonstrate the issue before the fix. Test edge cases (URL encoding, HTML entities, types). Take this as an opportunity to **make screenshots of the feature/fix and include them in the PR description**. - [x] **Agentic AI Code:** Confirm this Pull Request has gone through additional human review AND manual testing. - [x] **Code review:** Have you performed a self-review of your code, addressing any coding standard issues and ensuring adherence to the project's coding standards? - [x] **Design & Architecture:** Prefer smart defaults over adding new settings; use local state for ephemeral UI logic. Open a Discussion for major architectural or UX changes. - [x] **Git Hygiene:** Keep PRs atomic (one logical change). Clean up commits and rebase on `dev` to ensure no unrelated commits (e.g. from `main`) are included. Push updates to the existing PR branch instead of closing and reopening. - [x] **Title Prefix:** To clearly categorize this pull request, prefix the pull request title using one of the following: - **BREAKING CHANGE**: Significant changes that may affect compatibility - **build**: Changes that affect the build system or external dependencies - **ci**: Changes to our continuous integration processes or workflows - **chore**: Refactor, cleanup, or other non-functional code changes - **docs**: Documentation update or addition - **feat**: Introduces a new feature or enhancement to the codebase - **fix**: Bug fix or error correction - **i18n**: Internationalization or localization changes - **perf**: Performance improvement - **refactor**: Code restructuring for better maintainability, readability, or scalability - **style**: Changes that do not affect the meaning of the code (white space, formatting, missing semi-colons, etc.) - **test**: Adding missing tests or correcting existing tests - **WIP**: Work in progress, a temporary label for incomplete or ongoing work # Changelog Entry ## MOST CODE GENERATED WITH GITHUB COPILOT (codex 5.3 and haiku 4.5) VERIFIED BY HUMAN NOTE THAT I'M NOT A CODER AND I KNOW VERY LITTLE ABOUT SVELTE AND THE WHOLE STACK Sorry in advance, feel free to ignore this pr, i thought it did really good work and might be very useful for this project and i also think it did a good job on design, most of the design comes from me, generated and executed by COPILOT Human filled in: ### Description A redesign of the agent tool call, with tool specific icons, grouping of tool batches and clean animations The tools are either grouped and named with a tool combination name such as searched the web the icons are status regarded: - Gray for empty response such as no search results - Green for succes - Red for failiure The groups are provided with a icons stack so its clean and clear to the user what the model just did. ### Added - Added a centralized tool presentation layer in `toolCallPresentation.ts` (icon, labels, semantic classification, layout metadata, and fallback inference). - Added a rule-based grouped summary system with ordered matching and explicit matcher types (`allOf`, `anyOf`, `noneOf`, `onlyOf`). - Added a new bounded combination rule for web research + code execution (`web.search_and_execute_code`). - Added shared inline tool-row style constants in `toolCallInlineStyles.ts` for consistent grouped UI spacing/alignment. - Added grouped status parsing utilities for failed/success/neutral outcomes, including no-results detection for discovery tools. - Added per-icon status stack aggregation that supports mixed outcomes for the same tool icon. - Added grouped token metadata (`detail_group`, `groupClosed`) and grouped done-state normalization helpers in markdown token processing. - Added grouped connector visuals and closed-group completion indicator (“Done”) in grouped tool-call UI. - Added `docs/TOOL_CALL_GROUPING.md` with matcher semantics, ordering strategy, and concrete rule examples. - Added docs index entries in `docs/README.md` that expose and summarize tool grouping documentation. ### Changed - Changed grouped summary header from a single generic success icon to semantic stacked tool icons. - Changed grouped summary state coloring to consistently reflect failed, success, and neutral outcomes. - Changed grouped expand/collapse motion to transform-based transitions with stable anchoring and reduced jitter. - Changed grouped summary text behavior so named rule matches can suppress redundant raw detail text. - Changed grouped pending/done computation to rely on last tool-call completion and explicit group closure state. - Changed markdown token grouping to produce cleaner grouped tool-call blocks with proper continuity lines. - Changed tool call card rendering to use centralized presentation metadata (labels, icons, and semantics) across grouped and non-grouped views. - Changed result presentation in `ToolCallDisplay.svelte` from mostly generic JSON/text blocks to tool-aware sections (search, notes, memory, code, knowledge, and timestamp outputs). - Changed tool call expand animation to opacity-only entry for smoother, less distracting transitions. - Changed docs structure to include a dedicated grouping guide and an updated docs index entry for discoverability. ### Deprecated - None. ### Removed - Removed positional nudge from expand animation keyframes (opacity-only entry animation retained). ### Fixed - Fixed icon stack drift/jitter during collapse in grouped summaries. - Fixed mixed-status stack ordering so status layers follow encounter order per tool icon. - Fixed no-result discovery calls being shown as success; these now render as neutral/gray where appropriate. - Fixed grouped completion signaling so closed grouped flows consistently render a terminal done state. - Fixed rule matching precision by adding bounded `onlyOf` support to prevent broad over-matching. - Fixed documentation drift by aligning matcher docs (`allOf`, `anyOf`, `noneOf`, `onlyOf`) with implementation. ### Security - No security-impacting changes. ### Breaking Changes - **BREAKING CHANGE**: None. --- ### Additional Information ### Screenshots or Videos https://github.com/user-attachments/assets/87262da4-f25c-4ff7-9e6b-b6f1c173ed17 <img width="1180" height="674" alt="image" src="https://github.com/user-attachments/assets/4cd9d36f-02ef-41ee-99cf-a62e02d7a43e" /> <img width="1225" height="424" alt="image" src="https://github.com/user-attachments/assets/0a0fb004-be5b-499c-a008-b293f6395765" /> Excuse me for the random search results ### Contributor License Agreement <!-- 🚨 DO NOT DELETE THE TEXT BELOW 🚨 Keep the "Contributor License Agreement" confirmation text intact. Deleting it will trigger the CLA-Bot to INVALIDATE your PR. Your PR will NOT be reviewed or merged until you check the box below confirming that you have read and agree to the terms of the CLA. --> - [X] By submitting this pull request, I confirm that I have read and fully agree to the [Contributor License Agreement (CLA)](https://github.com/open-webui/open-webui/blob/main/CONTRIBUTOR_LICENSE_AGREEMENT), and I am providing my contributions under its terms. > [!NOTE] > Deleting the CLA section will lead to immediate closure of your PR and it will not be merged in. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-05-16 01:02:45 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
confirmed
confirmed issue
core
documentation
enhancement
good first issue
help wanted
non-core
pull-request
Mirrored from GitHub Pull Request
 python
question
testing wanted
No labels pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
GiteaMirror ninjasurge (Kaehlen Rog)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/open-webui#98264