[PR #23159] [CLOSED] perf: load chat message map from chat_message rows #98096

Closed
opened 2026-05-16 00:48:45 -05:00 by GiteaMirror · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/open-webui/open-webui/pull/23159
Author: @jmleksan
Created: 3/27/2026
Status: ❌ Closed

Base: dev ← Head: enh--Only-load-messages-for-map-not-whole-json


📝 Commits (1)

  • 88aea9f feat: enhance message mapping and filtering in ChatTable

📊 Changes

1 file changed (+63 additions, -8 deletions)

View changed files

📝 backend/open_webui/models/chats.py (+63 -8)

📄 Description

Pull Request Checklist

Before submitting, make sure you've checked the following:

  • Target branch: Verify that the pull request targets the dev branch. PRs targeting main will be immediately closed.
  • Description: Provide a concise description of the changes made in this pull request down below.
  • Changelog: Ensure a changelog entry following the format of Keep a Changelog is added at the bottom of the PR description.
  • Documentation: Add docs in Open WebUI Docs Repository. Document user-facing behavior, environment variables, public APIs/interfaces, or deployment steps. (No user-facing API or env changes; skip unless maintainers want an internal note.)
  • Dependencies: Are there any new or upgraded dependencies? If so, explain why, update the changelog/docs, and include any compatibility notes. Actually run the code/function that uses updated library to ensure it doesn't crash. (None.)
  • Testing: Perform manual tests to verify the implemented fix/feature works as intended AND does not break any other functionality. Include reproducible steps to demonstrate the issue before the fix. Test edge cases (URL encoding, HTML entities, types). Take this as an opportunity to make screenshots of the feature/fix and include them in the PR description. (Steps below; screenshots optional for this backend-only change.)
  • Agentic AI Code: Confirm this Pull Request is not written by any AI Agent or has at least gone through additional human review AND manual testing. If any AI Agent is the co-author of this PR, it may lead to immediate closure of the PR. (Confirm per your policy.)
  • Code review: Have you performed a self-review of your code, addressing any coding standard issues and ensuring adherence to the project's coding standards?
  • Design & Architecture: Prefer smart defaults over adding new settings; use local state for ephemeral UI logic. Open a Discussion for major architectural or UX changes.
  • Git Hygiene: Keep PRs atomic (one logical change). Clean up commits and rebase on dev to ensure no unrelated commits (e.g. from main) are included. Push updates to the existing PR branch instead of closing and reopening.
  • Title Prefix: To clearly categorize this pull request, prefix the pull request title using one of the following:
    • perf

Changelog Entry

  • ⚡ Chat history map from chat_message. Loading the message map for middleware now reads normalized chat_message rows when present instead of the full chat JSON blob, reducing DB I/O and parse cost for large chats; legacy chats without rows still use embedded history.

Description

  • get_messages_map_by_chat_id now builds history.messages from chat_message rows when any exist for the chat, avoiding loading and parsing the large chat JSON blob for that hot path. If there are no chat_message rows (legacy chats or failed dual-write), behavior falls back to reading embedded history from get_chat_by_id as before. The goal is to improve performance and reduce memory by not loading and parsing the full json blob.

Added

  • Chats._messages_map_from_chat_message_rows() helper to map ChatMessage ORM rows into the same shape as embedded history.messages.

Changed

  • Chats.get_messages_map_by_chat_id(): lightweight chat existence check; prefer SELECT from chat_message by chat_id; fallback to JSON-backed history when no rows.

Contributor License Agreement

Note

Deleting the CLA section will lead to immediate closure of your PR and it will not be merged in.


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/open-webui/open-webui/pull/23159 **Author:** [@jmleksan](https://github.com/jmleksan) **Created:** 3/27/2026 **Status:** ❌ Closed **Base:** `dev` ← **Head:** `enh--Only-load-messages-for-map-not-whole-json` --- ### 📝 Commits (1) - [`88aea9f`](https://github.com/open-webui/open-webui/commit/88aea9f75a2675b4ed434b3c57301e81185aad48) feat: enhance message mapping and filtering in ChatTable ### 📊 Changes **1 file changed** (+63 additions, -8 deletions) <details> <summary>View changed files</summary> 📝 `backend/open_webui/models/chats.py` (+63 -8) </details> ### 📄 Description <!-- ⚠️ CRITICAL CHECKS FOR CONTRIBUTORS (READ, DON'T DELETE) ⚠️ 1. Target the `dev` branch. PRs targeting `main` will be automatically closed. 2. Do NOT delete the CLA section at the bottom. It is required for the bot to accept your PR. --> # Pull Request Checklist **Before submitting, make sure you've checked the following:** - [x] **Target branch:** Verify that the pull request targets the `dev` branch. **PRs targeting `main` will be immediately closed.** - [x] **Description:** Provide a concise description of the changes made in this pull request down below. - [x] **Changelog:** Ensure a changelog entry following the format of [Keep a Changelog](https://keepachangelog.com/) is added at the bottom of the PR description. - [x] **Documentation:** Add docs in [Open WebUI Docs Repository](https://github.com/open-webui/docs). Document user-facing behavior, environment variables, public APIs/interfaces, or deployment steps. *(No user-facing API or env changes; skip unless maintainers want an internal note.)* - [x] **Dependencies:** Are there any new or upgraded dependencies? If so, explain why, update the changelog/docs, and include any compatibility notes. Actually run the code/function that uses updated library to ensure it doesn't crash. *(None.)* - [x] **Testing:** Perform manual tests to **verify the implemented fix/feature works as intended AND does not break any other functionality**. Include reproducible steps to demonstrate the issue before the fix. Test edge cases (URL encoding, HTML entities, types). Take this as an opportunity to **make screenshots of the feature/fix and include them in the PR description**. *(Steps below; screenshots optional for this backend-only change.)* - [x] **Agentic AI Code:** Confirm this Pull Request is **not written by any AI Agent** or has at least **gone through additional human review AND manual testing**. If any AI Agent is the co-author of this PR, it may lead to immediate closure of the PR. *(Confirm per your policy.)* - [x] **Code review:** Have you performed a self-review of your code, addressing any coding standard issues and ensuring adherence to the project's coding standards? - [x] **Design & Architecture:** Prefer smart defaults over adding new settings; use local state for ephemeral UI logic. Open a Discussion for major architectural or UX changes. - [x] **Git Hygiene:** Keep PRs atomic (one logical change). Clean up commits and rebase on `dev` to ensure no unrelated commits (e.g. from `main`) are included. Push updates to the existing PR branch instead of closing and reopening. - [x] **Title Prefix:** To clearly categorize this pull request, prefix the pull request title using one of the following: - **perf** --- # Changelog Entry - ⚡ **Chat history map from `chat_message`.** Loading the message map for middleware now reads normalized `chat_message` rows when present instead of the full `chat` JSON blob, reducing DB I/O and parse cost for large chats; legacy chats without rows still use embedded history. ### Description - **`get_messages_map_by_chat_id`** now builds `history.messages` from **`chat_message`** rows when any exist for the chat, avoiding loading and parsing the large **`chat` JSON** blob for that hot path. If there are no `chat_message` rows (legacy chats or failed dual-write), behavior falls back to reading embedded history from **`get_chat_by_id`** as before. The goal is to improve performance and reduce memory by not loading and parsing the full json blob. ### Added - `Chats._messages_map_from_chat_message_rows()` helper to map `ChatMessage` ORM rows into the same shape as embedded `history.messages`. ### Changed - `Chats.get_messages_map_by_chat_id()`: lightweight chat existence check; prefer `SELECT` from `chat_message` by `chat_id`; fallback to JSON-backed history when no rows. ### Contributor License Agreement <!-- 🚨 DO NOT DELETE THE TEXT BELOW 🚨 Keep the "Contributor License Agreement" confirmation text intact. Deleting it will trigger the CLA-Bot to INVALIDATE your PR. Your PR will NOT be reviewed or merged until you check the box below confirming that you have read and agree to the terms of the CLA. --> - [x] By submitting this pull request, I confirm that I have read and fully agree to the [Contributor License Agreement (CLA)](https://github.com/open-webui/open-webui/blob/main/CONTRIBUTOR_LICENSE_AGREEMENT), and I am providing my contributions under its terms. > [!NOTE] > Deleting the CLA section will lead to immediate closure of your PR and it will not be merged in. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-05-16 00:48:46 -05:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/open-webui#98096