[PR #12567] [MERGED] fix: Make Microsoft SSO work even when custom signing keys. #12475 #9770

New Issue

GiteaMirror · 2025-11-11T18:31:05-06:00

GiteaMirror commented

2025-11-11 18:31:05 -06:00

📋 Pull Request Information

Original PR: https://github.com/open-webui/open-webui/pull/12567
Author: @aleprj
Created: 4/7/2025
Status: ✅ Merged
Merged: 4/10/2025
Merged by: @tjbck

Base: dev ← Head: fix/ms-sso

📝 Commits (3)

63533c9 Merge pull request #12524 from open-webui/dev
818d24e fix: add appid to the URL to ensure we fetch the correct parameters in all scenarios
e8f0232 Merge branch 'open-webui:main' into fix/ms-sso

📊 Changes

1 file changed (+1 additions, -1 deletions)

View changed files

📝 backend/open_webui/config.py (+1 -1)

📄 Description

Pull Request Checklist

Note to first-time contributors: Please open a discussion post in Discussions and describe your changes before submitting a pull request.

Before submitting, make sure you've checked the following:

Target branch: Please verify that the pull request targets the dev branch.
Description: Provide a concise description of the changes made in this pull request.
Changelog: Ensure a changelog entry following the format of Keep a Changelog is added at the bottom of the PR description.
Documentation: Have you updated relevant documentation Open WebUI Docs, or other documentation sources?
Dependencies: Are there any new dependencies? Have you updated the dependency versions in the documentation?
Testing: Have you written and run sufficient tests to validate the changes?
Code review: Have you performed a self-review of your code, addressing any coding standard issues and ensuring adherence to the project's coding standards?
Prefix: To clearly categorize this pull request, prefix the pull request title using one of the following:
- BREAKING CHANGE: Significant changes that may affect compatibility
- build: Changes that affect the build system or external dependencies
- ci: Changes to our continuous integration processes or workflows
- chore: Refactor, cleanup, or other non-functional code changes
- docs: Documentation update or addition
- feat: Introduces a new feature or enhancement to the codebase
- fix: Bug fix or error correction
- i18n: Internationalization or localization changes
- perf: Performance improvement
- refactor: Code restructuring for better maintainability, readability, or scalability
- style: Changes that do not affect the meaning of the code (white space, formatting, missing semi-colons, etc.)
- test: Adding missing tests or correcting existing tests
- WIP: Work in progress, a temporary label for incomplete or ongoing work

Changelog Entry

Description

When retrieving Single Sign-On (SSO) parameters from Microsoft, we now include the application ID in our requests. This ensures that we receive the correct signing keys, particularly for applications configured with custom signing keys.

Fixed

Enhanced Microsoft Single Sign-On (SSO) now supports custom signing keys

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/open-webui/open-webui/pull/12567 **Author:** [@aleprj](https://github.com/aleprj) **Created:** 4/7/2025 **Status:** ✅ Merged **Merged:** 4/10/2025 **Merged by:** [@tjbck](https://github.com/tjbck) **Base:** `dev` ← **Head:** `fix/ms-sso` --- ### 📝 Commits (3) - [`63533c9`](https://github.com/open-webui/open-webui/commit/63533c9e3ab41edd7bd4124ef94f6b6dc09aa175) Merge pull request #12524 from open-webui/dev - [`818d24e`](https://github.com/open-webui/open-webui/commit/818d24e672c248d8376404a4e8b9d68afe4ff0ec) fix: add appid to the URL to ensure we fetch the correct parameters in all scenarios - [`e8f0232`](https://github.com/open-webui/open-webui/commit/e8f02328f422502a7d390e6827044bfba701cfd6) Merge branch 'open-webui:main' into fix/ms-sso ### 📊 Changes **1 file changed** (+1 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `backend/open_webui/config.py` (+1 -1) </details> ### 📄 Description # Pull Request Checklist ### Note to first-time contributors: Please open a discussion post in [Discussions](https://github.com/open-webui/open-webui/discussions) and describe your changes before submitting a pull request. **Before submitting, make sure you've checked the following:** - [x] **Target branch:** Please verify that the pull request targets the `dev` branch. - [x] **Description:** Provide a concise description of the changes made in this pull request. - [x] **Changelog:** Ensure a changelog entry following the format of [Keep a Changelog](https://keepachangelog.com/) is added at the bottom of the PR description. - [x] **Documentation:** Have you updated relevant documentation [Open WebUI Docs](https://github.com/open-webui/docs), or other documentation sources? - [x] **Dependencies:** Are there any new dependencies? Have you updated the dependency versions in the documentation? - [x] **Testing:** Have you written and run sufficient tests to validate the changes? - [x] **Code review:** Have you performed a self-review of your code, addressing any coding standard issues and ensuring adherence to the project's coding standards? - [x] **Prefix:** To clearly categorize this pull request, prefix the pull request title using one of the following: - **BREAKING CHANGE**: Significant changes that may affect compatibility - **build**: Changes that affect the build system or external dependencies - **ci**: Changes to our continuous integration processes or workflows - **chore**: Refactor, cleanup, or other non-functional code changes - **docs**: Documentation update or addition - **feat**: Introduces a new feature or enhancement to the codebase - **fix**: Bug fix or error correction - **i18n**: Internationalization or localization changes - **perf**: Performance improvement - **refactor**: Code restructuring for better maintainability, readability, or scalability - **style**: Changes that do not affect the meaning of the code (white space, formatting, missing semi-colons, etc.) - **test**: Adding missing tests or correcting existing tests - **WIP**: Work in progress, a temporary label for incomplete or ongoing work # Changelog Entry ### Description - When retrieving Single Sign-On (SSO) parameters from Microsoft, we now include the application ID in our requests. This ensures that we receive the correct signing keys, particularly for applications configured with custom signing keys. ### Fixed - Enhanced Microsoft Single Sign-On (SSO) now supports custom signing keys --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

GiteaMirror added the pull-request label 2025-11-11 18:31:05 -06:00

GiteaMirror closed this issue

2025-11-11 18:31:05 -06:00

GiteaMirror referenced this issue

2026-04-20 04:09:38 -05:00

[PR #10015] [CLOSED] fix: Ollama payload.py handling for num_predict and other options #22453

GiteaMirror referenced this issue

2026-04-20 04:11:59 -05:00

[PR #10360] [MERGED] fix: Update Ollama option handling in payload.py's convert_payload_openai_to_ollama #22507

GiteaMirror referenced this issue

2026-04-20 04:12:05 -05:00

[PR #10363] [MERGED] feat: Update Payload's apply_model_params_to_body_ollama with full Ollama supported options #22509