[PR #22274] [CLOSED] perf: lazy-compute createMessagesList in FloatingButtons #97618

New Issue

GiteaMirror · 2026-05-16T00:13:18-05:00

GiteaMirror commented

2026-05-16 00:13:18 -05:00

📋 Pull Request Information

Original PR: https://github.com/open-webui/open-webui/pull/22274
Author: @Classic298
Created: 3/5/2026
Status: ❌ Closed

Base: dev ← Head: perf/lazy-floating-buttons-messages

📝 Commits (1)

5ab04bd perf: lazy-compute createMessagesList in FloatingButtons

📊 Changes

2 files changed (+3 additions, -3 deletions)

View changed files

📝 src/lib/components/chat/ContentRenderer/FloatingButtons.svelte (+2 -2)
📝 src/lib/components/chat/Messages/ContentRenderer.svelte (+1 -1)

📄 Description

Defer createMessagesList tree walk from render-time to action-time. Previously, every rendered message eagerly computed the full message chain on every history change, even though FloatingButtons only uses it when the user selects text and triggers an action.

Changed the messages prop to a getMessages getter function that is called lazily only when an action is actually invoked.

Contributor License Agreement

By submitting this pull request, I confirm that I have read and fully agree to the Contributor License Agreement (CLA), and I am providing my contributions under its terms.

Note

Deleting the CLA section will lead to immediate closure of your PR and it will not be merged in.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/open-webui/open-webui/pull/22274 **Author:** [@Classic298](https://github.com/Classic298) **Created:** 3/5/2026 **Status:** ❌ Closed **Base:** `dev` ← **Head:** `perf/lazy-floating-buttons-messages` --- ### 📝 Commits (1) - [`5ab04bd`](https://github.com/open-webui/open-webui/commit/5ab04bdb1a7a49b4452415728ebac11d4c93bb09) perf: lazy-compute createMessagesList in FloatingButtons ### 📊 Changes **2 files changed** (+3 additions, -3 deletions) <details> <summary>View changed files</summary> 📝 `src/lib/components/chat/ContentRenderer/FloatingButtons.svelte` (+2 -2) 📝 `src/lib/components/chat/Messages/ContentRenderer.svelte` (+1 -1) </details> ### 📄 Description Defer createMessagesList tree walk from render-time to action-time. <ins>**Previously, every rendered message eagerly computed the full message chain on every history change, even though FloatingButtons only uses it when the user selects text and triggers an action.**</ins> Changed the messages prop to a getMessages getter function that is called lazily only when an action is actually invoked. ### Contributor License Agreement  By submitting this pull request, I confirm that I have read and fully agree to the [Contributor License Agreement (CLA)](https://github.com/open-webui/open-webui/blob/main/CONTRIBUTOR_LICENSE_AGREEMENT), and I am providing my contributions under its terms. > [!NOTE] > Deleting the CLA section will lead to immediate closure of your PR and it will not be merged in. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

GiteaMirror added the pull-request label 2026-05-16 00:13:18 -05:00

GiteaMirror closed this issue

2026-05-16 00:13:21 -05:00

Sign in to join this conversation.

Branches Tags

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: github-starred/open-webui#97618