[PR #21699] [MERGED] fix: align profile dropdown items and prevent drag clicks #97255

New Issue

GiteaMirror · 2026-05-15T23:40:45-05:00

GiteaMirror commented

2026-05-15 23:40:45 -05:00

📋 Pull Request Information

Original PR: https://github.com/open-webui/open-webui/pull/21699
Author: @silentoplayz
Created: 2/21/2026
Status: ✅ Merged
Merged: 2/21/2026
Merged by: @tjbck

Base: dev ← Head: fix/dropdown-menu-drag-glitch

📝 Commits (1)

8ba012f fix(ui): align profile dropdown items and prevent phantom synthetic drag clicks

📊 Changes

1 file changed (+26 additions, -16 deletions)

View changed files

📝 src/lib/components/layout/Sidebar/UserMenu.svelte (+26 -16)

📄 Description

Pull Request Checklist

Note to first-time contributors: Please open a discussion post in Discussions to discuss your idea/fix with the community before creating a pull request, and describe your changes before submitting a pull request.

This is to ensure large feature PRs are discussed with the community first, before starting work on it. If the community does not want this feature or it is not relevant for Open WebUI as a project, it can be identified in the discussion before working on the feature and submitting the PR.

Before submitting, make sure you've checked the following:

Target branch: Verify that the pull request targets the dev branch. PRs targeting main will be immediately closed.
Description: Provide a concise description of the changes made in this pull request down below.
Changelog: Ensure a changelog entry following the format of Keep a Changelog is added at the bottom of the PR description.
Documentation: Add docs in Open WebUI Docs Repository. Document user-facing behavior, environment variables, public APIs/interfaces, or deployment steps.
Dependencies: Are there any new or upgraded dependencies? If so, explain why, update the changelog/docs, and include any compatibility notes. Actually run the code/function that uses updated library to ensure it doesn't crash.
Testing: Perform manual tests to verify the implemented fix/feature works as intended AND does not break any other functionality. Include reproducible steps to demonstrate the issue before the fix. Test edge cases (URL encoding, HTML entities, types). Take this as an opportunity to make screenshots of the feature/fix and include them in the PR description.
Agentic AI Code: Confirm this Pull Request is not written by any AI Agent or has at least gone through additional identification AND manual testing. If any AI Agent is the co-author of this PR, it may lead to immediate closure of the PR.
Code review: Have you performed a self-review of your code, addressing any coding standard issues and ensuring adherence to the project's coding standards?
Design & Architecture: Prefer smart defaults over adding new settings; use local state for ephemeral UI logic. Open a Discussion for major architectural or UX changes.
Git Hygiene: Keep PRs atomic (one logical change). Clean up commits and rebase on dev to ensure no unrelated commits (e.g. from main) are included. Push updates to the existing PR branch instead of closing and reopening.
Title Prefix: To clearly categorize this pull request, prefix the pull request title using one of the following:
- fix: Bug fix or error correction

Changelog Entry

Description

Fixed draggable user profile menu items and completely eliminated a phantom link execution bug caused by native HTML text selection conflicts on headless Svelte components.

Added

Appended draggable="false" directly to five as="a" elements in src/lib/components/layout/Sidebar/UserMenu.svelte (Playground, Admin Panel, Documentation, Releases, Keyboard Shortcuts) to natively discard ghost image cursor drags.
Expanded the select-none tailwind utility across completely ALL dropdown elements identically to prevent the browser text selection listener from interfering with bits-ui hover states.

Changed

Realigned layout margins by refactoring gap-3 element padding uniformly into the conventional Open WebUI mr-3 cursor-pointer truncate classes to perfectly match default siblings natively.

Fixed

Eliminated vertical alignment UI stutter and spacing regressions on Playground, Admin Panel and User Guidelines nodes inside UserMenu.svelte.
Fixed a silent usability bug causing headless dropdowns to fire "Virtual Synthetic Clicks" internally after accidentally dropping a text/drag selection remotely outside the Dropdown modal.
Native "Open in New Tab" via Middle/Right-Clicking behaves exactly identically to an unmodified build, without relying strictly on internal UI JS goto() navigation closures.

Additional Information

Context: Several issues were identified with the UserMenu.svelte dropdowns used throughout Open WebUI (both main sidebar and upper-right active chat header dropwdowns). Originally:
1. The Playground, Admin Panel, Documentation, and Releases nodes were accidentally natively draggable since they leverage HTML as="a" components—this caused ghost clones behind the user's cursor when accidentally mouse-swiping.
2. The horizontal icon alignment was inconsistent (leveraging gap-3 instead of the project norm mr-3).
3. When an attempted fix was floated to completely remove the as="a" anchors entirely, it caused a massive usability regression: native users could no longer middle-click Admin Panel to "Open In New Tab".
4. Another massive regression emerged: when the select-none class was removed from buttons within Svelte headless components, simply dragging the cursor away from a dropdown item and releasing the mouse outside the menu mysteriously fired an identical phantom goto() response. This occurred natively because selecting/highlighting underlying text blindly suppresses the necessary pointerleave listener that bits-ui requires natively to deactivate internal hover states!
Having diagnosed all these edge cases, this PR restores the native as="a" tag, appends draggable="false" directly, uniformizes the mr-3 cursor-pointer formatting horizontally, and uniformly forces standard select-none tailwind constraints unconditionally across the modal dropdown—completely resolving both the alignment glitches and all three drag phantom anomalies flawlessly.

Contributor License Agreement

By submitting this pull request, I confirm that I have read and fully agree to the Contributor License Agreement (CLA), and I am providing my contributions under its terms.

Note

Deleting the CLA section will lead to immediate closure of your PR and it will not be merged in.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/open-webui/open-webui/pull/21699 **Author:** [@silentoplayz](https://github.com/silentoplayz) **Created:** 2/21/2026 **Status:** ✅ Merged **Merged:** 2/21/2026 **Merged by:** [@tjbck](https://github.com/tjbck) **Base:** `dev` ← **Head:** `fix/dropdown-menu-drag-glitch` --- ### 📝 Commits (1) - [`8ba012f`](https://github.com/open-webui/open-webui/commit/8ba012f8b62cc41b70f07ea6c6c7729dc12cdaab) fix(ui): align profile dropdown items and prevent phantom synthetic drag clicks ### 📊 Changes **1 file changed** (+26 additions, -16 deletions) <details> <summary>View changed files</summary> 📝 `src/lib/components/layout/Sidebar/UserMenu.svelte` (+26 -16) </details> ### 📄 Description  # Pull Request Checklist ### Note to first-time contributors: Please open a discussion post in [Discussions](https://github.com/open-webui/open-webui/discussions) to discuss your idea/fix with the community before creating a pull request, and describe your changes before submitting a pull request. This is to ensure large feature PRs are discussed with the community first, before starting work on it. If the community does not want this feature or it is not relevant for Open WebUI as a project, it can be identified in the discussion before working on the feature and submitting the PR. **Before submitting, make sure you've checked the following:** - [x] **Target branch:** Verify that the pull request targets the `dev` branch. **PRs targeting `main` will be immediately closed.** - [x] **Description:** Provide a concise description of the changes made in this pull request down below. - [x] **Changelog:** Ensure a changelog entry following the format of [Keep a Changelog](https://keepachangelog.com/) is added at the bottom of the PR description. - [x] **Documentation:** Add docs in [Open WebUI Docs Repository](https://github.com/open-webui/docs). Document user-facing behavior, environment variables, public APIs/interfaces, or deployment steps. - [x] **Dependencies:** Are there any new or upgraded dependencies? If so, explain why, update the changelog/docs, and include any compatibility notes. Actually run the code/function that uses updated library to ensure it doesn't crash. - [x] **Testing:** Perform manual tests to **verify the implemented fix/feature works as intended AND does not break any other functionality**. Include reproducible steps to demonstrate the issue before the fix. Test edge cases (URL encoding, HTML entities, types). Take this as an opportunity to **make screenshots of the feature/fix and include them in the PR description**. - [x] **Agentic AI Code:** Confirm this Pull Request is **not written by any AI Agent** or has at least **gone through additional identification AND manual testing**. If any AI Agent is the co-author of this PR, it may lead to immediate closure of the PR. - [x] **Code review:** Have you performed a self-review of your code, addressing any coding standard issues and ensuring adherence to the project's coding standards? - [x] **Design & Architecture:** Prefer smart defaults over adding new settings; use local state for ephemeral UI logic. Open a Discussion for major architectural or UX changes. - [x] **Git Hygiene:** Keep PRs atomic (one logical change). Clean up commits and rebase on `dev` to ensure no unrelated commits (e.g. from `main`) are included. Push updates to the existing PR branch instead of closing and reopening. - [x] **Title Prefix:** To clearly categorize this pull request, prefix the pull request title using one of the following: - **fix**: Bug fix or error correction # Changelog Entry ### Description - Fixed draggable user profile menu items and completely eliminated a phantom link execution bug caused by native HTML text selection conflicts on headless Svelte components. ### Added - Appended `draggable="false"` directly to five `as="a"` elements in `src/lib/components/layout/Sidebar/UserMenu.svelte` (`Playground`, `Admin Panel`, `Documentation`, `Releases`, `Keyboard Shortcuts`) to natively discard ghost image cursor drags. - Expanded the `select-none` tailwind utility across completely ALL dropdown elements identically to prevent the browser text selection listener from interfering with `bits-ui` hover states. ### Changed - Realigned layout margins by refactoring `gap-3` element padding uniformly into the conventional Open WebUI `mr-3 cursor-pointer truncate` classes to perfectly match default siblings natively. ### Fixed - Eliminated vertical alignment UI stutter and spacing regressions on `Playground`, `Admin Panel` and `User Guidelines` nodes inside `UserMenu.svelte`. - Fixed a silent usability bug causing headless dropdowns to fire "Virtual Synthetic Clicks" internally after accidentally dropping a text/drag selection remotely outside the Dropdown modal. - Native "Open in New Tab" via Middle/Right-Clicking behaves exactly identically to an unmodified build, without relying strictly on internal UI JS `goto()` navigation closures. --- ### Additional Information - **Context**: Several issues were identified with the `UserMenu.svelte` dropdowns used throughout Open WebUI (both main sidebar and upper-right active chat header dropwdowns). Originally: 1. The `Playground`, `Admin Panel`, `Documentation`, and `Releases` nodes were accidentally natively draggable since they leverage HTML `as="a"` components—this caused ghost clones behind the user's cursor when accidentally mouse-swiping. 2. The horizontal icon alignment was inconsistent (leveraging `gap-3` instead of the project norm `mr-3`). 3. When an attempted fix was floated to completely remove the `as="a"` anchors entirely, it caused a massive usability regression: native users could no longer middle-click `Admin Panel` to "Open In New Tab". 4. Another massive regression emerged: when the `select-none` class was removed from buttons within Svelte headless components, simply dragging the cursor away from a dropdown item and releasing the mouse outside the menu mysteriously fired an identical phantom `goto()` response. This occurred natively because selecting/highlighting underlying text blindly suppresses the necessary `pointerleave` listener that `bits-ui` requires natively to deactivate internal hover states! - Having diagnosed all these edge cases, this PR restores the native `as="a"` tag, appends `draggable="false"` directly, uniformizes the `mr-3 cursor-pointer` formatting horizontally, and uniformly forces standard `select-none` tailwind constraints unconditionally across the modal dropdown—completely resolving both the alignment glitches and all three drag phantom anomalies flawlessly. ### Contributor License Agreement  By submitting this pull request, I confirm that I have read and fully agree to the [Contributor License Agreement (CLA)](https://github.com/open-webui/open-webui/blob/main/CONTRIBUTOR_LICENSE_AGREEMENT), and I am providing my contributions under its terms. > [!NOTE] > Deleting the CLA section will lead to immediate closure of your PR and it will not be merged in. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

GiteaMirror added the pull-request label 2026-05-15 23:40:45 -05:00

GiteaMirror closed this issue

2026-05-15 23:40:47 -05:00

Sign in to join this conversation.

Branches Tags

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: github-starred/open-webui#97255