[PR #21009] [MERGED] perf: reduce triple query to single fetch in model toggle #96921

New Issue

GiteaMirror · 2026-05-15T23:18:04-05:00

GiteaMirror commented

2026-05-15 23:18:04 -05:00

📋 Pull Request Information

Original PR: https://github.com/open-webui/open-webui/pull/21009
Author: @Classic298
Created: 1/28/2026
Status: ✅ Merged
Merged: 1/29/2026
Merged by: @tjbck

Base: dev ← Head: model-triple

📝 Commits (1)

4c8e577 fix: reduce triple query to single fetch in model toggle

📊 Changes

1 file changed (+7 additions, -8 deletions)

View changed files

📝 backend/open_webui/models/models.py (+7 -8)

📄 Description

Summary

Eliminates redundant database queries in toggle_model_by_id. Previously, the function made 3 separate queries to toggle a model's active state.

Changes

models/models.py toggle_model_by_id:

Fetch model once with query().filter_by().first()
Toggle is_active directly on the object
Commit and refresh the same object
Return the validated model

Performance Impact

Before: 3 queries (fetch is_active, update, fetch model)
After: 1 query + commit + refresh on same object

Contributor License Agreement

By submitting this pull request, I confirm that I have read and fully agree to the Contributor License Agreement (CLA), and I am providing my contributions under its terms.

Note

Deleting the CLA section will lead to immediate closure of your PR and it will not be merged in.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/open-webui/open-webui/pull/21009 **Author:** [@Classic298](https://github.com/Classic298) **Created:** 1/28/2026 **Status:** ✅ Merged **Merged:** 1/29/2026 **Merged by:** [@tjbck](https://github.com/tjbck) **Base:** `dev` ← **Head:** `model-triple` --- ### 📝 Commits (1) - [`4c8e577`](https://github.com/open-webui/open-webui/commit/4c8e577af4644b9a179182e30f64d8700016e4d3) fix: reduce triple query to single fetch in model toggle ### 📊 Changes **1 file changed** (+7 additions, -8 deletions) <details> <summary>View changed files</summary> 📝 `backend/open_webui/models/models.py` (+7 -8) </details> ### 📄 Description ## Summary Eliminates redundant database queries in toggle_model_by_id. Previously, the function made 3 separate queries to toggle a model's active state. ## Changes models/models.py toggle_model_by_id: - Fetch model once with query().filter_by().first() - Toggle is_active directly on the object - Commit and refresh the same object - Return the validated model ## Performance Impact Before: 3 queries (fetch is_active, update, fetch model) After: 1 query + commit + refresh on same object ### Contributor License Agreement By submitting this pull request, I confirm that I have read and fully agree to the [Contributor License Agreement (CLA)](https://github.com/open-webui/open-webui/blob/main/CONTRIBUTOR_LICENSE_AGREEMENT), and I am providing my contributions under its terms. > [!NOTE] > Deleting the CLA section will lead to immediate closure of your PR and it will not be merged in. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

GiteaMirror added the pull-request label 2026-05-15 23:18:04 -05:00

GiteaMirror closed this issue

2026-05-15 23:18:06 -05:00

Sign in to join this conversation.

Branches Tags

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: github-starred/open-webui#96921