[PR #20279] [MERGED] fix: prevent null crashes in users and notes routers #96580

New Issue

GiteaMirror · 2026-05-15T22:51:41-05:00

GiteaMirror commented

2026-05-15 22:51:41 -05:00

📋 Pull Request Information

Original PR: https://github.com/open-webui/open-webui/pull/20279
Author: @Classic298
Created: 12/30/2025
Status: ✅ Merged
Merged: 12/31/2025
Merged by: @tjbck

Base: dev ← Head: fix/issue-022-023-routers-null

📝 Commits (1)

08a41a3 fix: prevent null crashes in users and notes routers

📊 Changes

2 files changed (+17 additions, -14 deletions)

View changed files

📝 backend/open_webui/routers/notes.py (+14 -13)
📝 backend/open_webui/routers/users.py (+3 -1)

📄 Description

Add null checks for ui settings in update_user_settings_by_session_user() and for user in get_notes(). Prevents AttributeError when ui dict is None or when note's user has been deleted.

Contributor License Agreement

By submitting this pull request, I confirm that I have read and fully agree to the Contributor License Agreement (CLA), and I am providing my contributions under its terms.

Note

Deleting the CLA section will lead to immediate closure of your PR and it will not be merged in.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/open-webui/open-webui/pull/20279 **Author:** [@Classic298](https://github.com/Classic298) **Created:** 12/30/2025 **Status:** ✅ Merged **Merged:** 12/31/2025 **Merged by:** [@tjbck](https://github.com/tjbck) **Base:** `dev` ← **Head:** `fix/issue-022-023-routers-null` --- ### 📝 Commits (1) - [`08a41a3`](https://github.com/open-webui/open-webui/commit/08a41a36ed6577b960a49adc875db4ad81a6da49) fix: prevent null crashes in users and notes routers ### 📊 Changes **2 files changed** (+17 additions, -14 deletions) <details> <summary>View changed files</summary> 📝 `backend/open_webui/routers/notes.py` (+14 -13) 📝 `backend/open_webui/routers/users.py` (+3 -1) </details> ### 📄 Description Add null checks for ui settings in update_user_settings_by_session_user() and for user in get_notes(). Prevents AttributeError when ui dict is None or when note's user has been deleted. ### Contributor License Agreement By submitting this pull request, I confirm that I have read and fully agree to the [Contributor License Agreement (CLA)](https://github.com/open-webui/open-webui/blob/main/CONTRIBUTOR_LICENSE_AGREEMENT), and I am providing my contributions under its terms. > [!NOTE] > Deleting the CLA section will lead to immediate closure of your PR and it will not be merged in. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

GiteaMirror added the pull-request label 2026-05-15 22:51:41 -05:00

GiteaMirror closed this issue

2026-05-15 22:51:43 -05:00

Sign in to join this conversation.

Branches Tags

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: github-starred/open-webui#96580