[PR #18856] [CLOSED] fix: make folder emoji changes reactive in sidebar (#18131) #96041

New Issue

2026-05-15T22:16:01-05:00

GiteaMirror commented

2026-05-15 22:16:01 -05:00

📋 Pull Request Information

Original PR: https://github.com/open-webui/open-webui/pull/18856
Author: @fsmw
Created: 11/1/2025
Status: ❌ Closed

Base: dev ← Head: fix/18131-folder-emoji-reactivity

📝 Commits (2)

9c9092f fix(retrieval): preserve Chinese punctuation in uploaded documents
3759fda fix: make folder emoji changes reactive in sidebar (#18131)

📊 Changes

3 files changed (+27 additions, -15 deletions)

View changed files

📝 backend/open_webui/retrieval/loaders/main.py (+1 -2)
📝 src/lib/components/chat/Placeholder/FolderTitle.svelte (+13 -3)
📝 src/lib/components/layout/Sidebar.svelte (+13 -10)

📄 Description

Summary

Fix folder emoji changes not updating in sidebar until page refresh.

Problem

When changing a folder's emoji in the FolderTitle component, the sidebar display doesn't update reactively until the page is refreshed.

Root Cause

The updateIconHandler in FolderTitle.svelte was updating the API and local folder object, but not the global folders store that the sidebar uses.

Solution

Update global folders store: Modified updateIconHandler in FolderTitle.svelte to update the global folders store when emoji changes.
Add reactive statement: Added a reactive statement in Sidebar.svelte to automatically sync the local folders object with the global store changes.

Changes Made

src/lib/components/chat/Placeholder/FolderTitle.svelte: Update global folders store in updateIconHandler
src/lib/components/layout/Sidebar.svelte: Add reactive statement to sync local folders with global store

Testing

The fix ensures emoji changes appear immediately in the sidebar without requiring a page refresh.

Fixes #18131

Contributor License Agreement

By submitting this pull request, I confirm that I have read and fully agree to the Contributor License Agreement (CLA), and I am providing my contributions under its terms.

Fernando San Martin

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/open-webui/open-webui/pull/18856 **Author:** [@fsmw](https://github.com/fsmw) **Created:** 11/1/2025 **Status:** ❌ Closed **Base:** `dev` ← **Head:** `fix/18131-folder-emoji-reactivity` --- ### 📝 Commits (2) - [`9c9092f`](https://github.com/open-webui/open-webui/commit/9c9092f2c22d5b55a1663037fdfa38476849a20c) fix(retrieval): preserve Chinese punctuation in uploaded documents - [`3759fda`](https://github.com/open-webui/open-webui/commit/3759fdab8ce029c1e57491d288f455545480da65) fix: make folder emoji changes reactive in sidebar (#18131) ### 📊 Changes **3 files changed** (+27 additions, -15 deletions) <details> <summary>View changed files</summary> 📝 `backend/open_webui/retrieval/loaders/main.py` (+1 -2) 📝 `src/lib/components/chat/Placeholder/FolderTitle.svelte` (+13 -3) 📝 `src/lib/components/layout/Sidebar.svelte` (+13 -10) </details> ### 📄 Description ## Summary Fix folder emoji changes not updating in sidebar until page refresh. ## Problem When changing a folder's emoji in the FolderTitle component, the sidebar display doesn't update reactively until the page is refreshed. ## Root Cause The `updateIconHandler` in `FolderTitle.svelte` was updating the API and local folder object, but not the global `folders` store that the sidebar uses. ## Solution 1. **Update global folders store**: Modified `updateIconHandler` in `FolderTitle.svelte` to update the global `folders` store when emoji changes. 2. **Add reactive statement**: Added a reactive statement in `Sidebar.svelte` to automatically sync the local `folders` object with the global store changes. ## Changes Made - `src/lib/components/chat/Placeholder/FolderTitle.svelte`: Update global folders store in `updateIconHandler` - `src/lib/components/layout/Sidebar.svelte`: Add reactive statement to sync local folders with global store ## Testing The fix ensures emoji changes appear immediately in the sidebar without requiring a page refresh. Fixes #18131 ### Contributor License Agreement By submitting this pull request, I confirm that I have read and fully agree to the [Contributor License Agreement (CLA)](https://github.com/open-webui/open-webui/blob/main/CONTRIBUTOR_LICENSE_AGREEMENT), and I am providing my contributions under its terms. Fernando San Martin --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

GiteaMirror added the pull-request label 2026-05-15 22:16:01 -05:00

GiteaMirror closed this issue

2026-05-15 22:16:03 -05:00

Sign in to join this conversation.

Branches Tags

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: github-starred/open-webui#96041