[PR #18260] [MERGED] fix: allow toast notifications to be closed when a modal is open #95769

New Issue

GiteaMirror · 2026-05-15T21:57:41-05:00

GiteaMirror commented

2026-05-15 21:57:41 -05:00

📋 Pull Request Information

Original PR: https://github.com/open-webui/open-webui/pull/18260
Author: @silentoplayz
Created: 10/12/2025
Status: ✅ Merged
Merged: 10/14/2025
Merged by: @tjbck

Base: dev ← Head: fix-toast-click-issue

📝 Commits (1)

1e6426e fix: allow toast notifications to be closed when a modal is open

📊 Changes

1 file changed (+5 additions, -1 deletions)

View changed files

📝 src/lib/components/common/Modal.svelte (+5 -1)

📄 Description

Pull Request Checklist

Before submitting, make sure you've checked the following:

Target branch: Verify that the pull request targets the dev branch. Not targeting the dev branch may lead to immediate closure of the PR.
Description: Provide a concise description of the changes made in this pull request.
Changelog: Ensure a changelog entry following the format of Keep a Changelog is added at the bottom of the PR description.
Documentation: If necessary, update relevant documentation Open WebUI Docs like environment variables, the tutorials, or other documentation sources.
Dependencies: Are there any new dependencies? Have you updated the dependency versions in the documentation?
Testing: Perform manual tests to verify the implemented fix/feature works as intended AND does not break any other functionality. Take this as an opportunity to make screenshots of the feature/fix and include it in the PR description.
Agentic AI Code:: Confirm this Pull Request is not written by any AI Agent or has at least gone through additional human review and manual testing. If any AI Agent is the co-author of this PR, it may lead to immediate closure of the PR.
Code review: Have you performed a self-review of your code, addressing any coding standard issues and ensuring adherence to the project's coding standards?
Title Prefix: To clearly categorize this pull request, prefix the pull request title using one of the following:
- BREAKING CHANGE: Significant changes that may affect compatibility
- build: Changes that affect the build system or external dependencies
- ci: Changes to our continuous integration processes or workflows
- chore: Refactor, cleanup, or other non-functional code changes
- docs: Documentation update or addition
- feat: Introduces a new feature or enhancement to the codebase
- fix: Bug fix or error correction
- i18n: Internationalization or localization changes
- perf: Performance improvement
- refactor: Code restructuring for better maintainability, readability, or scalability
- style: Changes that do not affect the meaning of the code (white space, formatting, missing semi-colons, etc.)
- test: Adding missing tests or correcting existing tests
- WIP: Work in progress, a temporary label for incomplete or ongoing work

Changelog Entry

Description

This pull request fixes an issue where users could not dismiss notification toasts when the user settings modal was open. The modal's focus trap was preventing interactions with elements outside of it, including the toasts. This change configures the focus trap to allow clicks on toast notifications, ensuring they can always be closed.

Changed

Updated the focus-trap configuration in src/lib/components/common/Modal.svelte to allow clicks on elements with the data-sonner-toast attribute.

Fixed

Corrected an issue where the user settings modal blocked interactions with notification toasts, preventing them from being dismissed.

Contributor License Agreement

By submitting this pull request, I confirm that I have read and fully agree to the Contributor License Agreement (CLA), and I am providing my contributions under its terms.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/open-webui/open-webui/pull/18260 **Author:** [@silentoplayz](https://github.com/silentoplayz) **Created:** 10/12/2025 **Status:** ✅ Merged **Merged:** 10/14/2025 **Merged by:** [@tjbck](https://github.com/tjbck) **Base:** `dev` ← **Head:** `fix-toast-click-issue` --- ### 📝 Commits (1) - [`1e6426e`](https://github.com/open-webui/open-webui/commit/1e6426ed4f9f34c8c6cfecffaa6d305b6bb7fec5) fix: allow toast notifications to be closed when a modal is open ### 📊 Changes **1 file changed** (+5 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `src/lib/components/common/Modal.svelte` (+5 -1) </details> ### 📄 Description # Pull Request Checklist **Before submitting, make sure you've checked the following:** - [X] **Target branch:** Verify that the pull request targets the `dev` branch. Not targeting the `dev` branch may lead to immediate closure of the PR. - [X] **Description:** Provide a concise description of the changes made in this pull request. - [X] **Changelog:** Ensure a changelog entry following the format of [Keep a Changelog](https://keepachangelog.com/) is added at the bottom of the PR description. - [X] **Documentation:** If necessary, update relevant documentation [Open WebUI Docs](https://github.com/open-webui/docs) like environment variables, the tutorials, or other documentation sources. - [X] **Dependencies:** Are there any new dependencies? Have you updated the dependency versions in the documentation? - [X] **Testing:** Perform manual tests to verify the implemented fix/feature works as intended AND does not break any other functionality. Take this as an opportunity to make screenshots of the feature/fix and include it in the PR description. - [X] **Agentic AI Code:**: Confirm this Pull Request is **not written by any AI Agent** or has at least gone through additional human review **and** manual testing. If any AI Agent is the co-author of this PR, it may lead to immediate closure of the PR. - [X] **Code review:** Have you performed a self-review of your code, addressing any coding standard issues and ensuring adherence to the project's coding standards? - [X] **Title Prefix:** To clearly categorize this pull request, prefix the pull request title using one of the following: - **BREAKING CHANGE**: Significant changes that may affect compatibility - **build**: Changes that affect the build system or external dependencies - **ci**: Changes to our continuous integration processes or workflows - **chore**: Refactor, cleanup, or other non-functional code changes - **docs**: Documentation update or addition - **feat**: Introduces a new feature or enhancement to the codebase - **fix**: Bug fix or error correction - **i18n**: Internationalization or localization changes - **perf**: Performance improvement - **refactor**: Code restructuring for better maintainability, readability, or scalability - **style**: Changes that do not affect the meaning of the code (white space, formatting, missing semi-colons, etc.) - **test**: Adding missing tests or correcting existing tests - **WIP**: Work in progress, a temporary label for incomplete or ongoing work # Changelog Entry ### Description - This pull request fixes an issue where users could not dismiss notification toasts when the user settings modal was open. The modal's focus trap was preventing interactions with elements outside of it, including the toasts. This change configures the focus trap to allow clicks on toast notifications, ensuring they can always be closed. ### Changed - Updated the `focus-trap` configuration in `src/lib/components/common/Modal.svelte` to allow clicks on elements with the `data-sonner-toast` attribute. ### Fixed - Corrected an issue where the user settings modal blocked interactions with notification toasts, preventing them from being dismissed. ### Contributor License Agreement By submitting this pull request, I confirm that I have read and fully agree to the [Contributor License Agreement (CLA)](https://github.com/open-webui/open-webui/blob/main/CONTRIBUTOR_LICENSE_AGREEMENT), and I am providing my contributions under its terms. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

GiteaMirror added the pull-request label 2026-05-15 21:57:41 -05:00

GiteaMirror closed this issue

2026-05-15 21:57:44 -05:00

Sign in to join this conversation.

Branches Tags

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: github-starred/open-webui#95769