github-starred/open-webui
2
0
Fork 0
mirror of https://github.com/open-webui/open-webui.git synced 2026-07-16 14:39:31 -05:00
Code Issues 2.4k Packages Projects Releases 129 Wiki Activity

[PR #11553] [CLOSED] feat:Per-model valve customization #9555

New Issue
Closed
opened 2025-11-11 18:25:35 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2025-11-11 18:25:35 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/open-webui/open-webui/pull/11553
Author: @kaytwo
Created: 3/11/2025
Status: ❌ Closed

Base: dev ← Head: justPerModelValves

📝 Commits (4)

  • e3e446d per model valves appear to be saving to and retrieving from the db successfully
  • c6e3271 overwrite action, tool, and filter valves
  • 3bc97cf formatting
  • 078f025 handle empty valves

📊 Changes

8 files changed (+179 additions, -11 deletions)

View changed files

📝 backend/open_webui/utils/chat.py (+6 -1)
📝 backend/open_webui/utils/filter.py (+11 -0)
📝 backend/open_webui/utils/tools.py (+12 -0)
📝 src/lib/components/common/Valves.svelte (+5 -5)
📝 src/lib/components/workspace/Models/ActionsSelector.svelte (+18 -1)
📝 src/lib/components/workspace/Models/FiltersSelector.svelte (+20 -1)
📝 src/lib/components/workspace/Models/ModelEditor.svelte (+89 -2)
📝 src/lib/components/workspace/Models/ToolsSelector.svelte (+18 -1)

📄 Description

Pull Request Checklist

Note to first-time contributors: Please open a discussion post in Discussions and describe your changes before submitting a pull request.

Before submitting, make sure you've checked the following:

  • Target branch: Please verify that the pull request targets the dev branch.
  • Description: Provide a concise description of the changes made in this pull request.
  • Changelog: Ensure a changelog entry following the format of Keep a Changelog is added at the bottom of the PR description.
  • Documentation: Have you updated relevant documentation Open WebUI Docs, or other documentation sources?
  • Dependencies: Are there any new dependencies? Have you updated the dependency versions in the documentation?
  • Testing: Have you written and run sufficient tests for validating the changes?
  • Code review: Have you performed a self-review of your code, addressing any coding standard issues and ensuring adherence to the project's coding standards?
  • Prefix: To cleary categorize this pull request, prefix the pull request title, using one of the following:
    • BREAKING CHANGE: Significant changes that may affect compatibility
    • build: Changes that affect the build system or external dependencies
    • ci: Changes to our continuous integration processes or workflows
    • chore: Refactor, cleanup, or other non-functional code changes
    • docs: Documentation update or addition
    • feat: Introduces a new feature or enhancement to the codebase
    • fix: Bug fix or error correction
    • i18n: Internationalization or localization changes
    • perf: Performance improvement
    • refactor: Code restructuring for better maintainability, readability, or scalability
    • style: Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc.)
    • test: Adding missing tests or correcting existing tests
    • WIP: Work in progress, a temporary label for incomplete or ongoing work

Changelog Entry

Description

  • Allows filters, actions, and tools to be reconfigured on a per-model basis. This allows the same tool/function to be re-used in different customized models while (a) maintaining per-instance default Valves and (b) allowing each individual model to use the tool/function with overridden valve values.

Added

  • ☑️ Configure function and tool valves per-model: instance-wide valve configurations can be overridden in the model editor.

Breaking Changes

  • Should be completely backwards compatible

Additional Information

More motivation/discussion available in #11461. Will add docs if maintainers agree to merge.

Screenshots or Videos

New user interface (uses a collapsible customization similar to others on the same page/for configuring valves elsewhere):
image

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/open-webui/open-webui/pull/11553 **Author:** [@kaytwo](https://github.com/kaytwo) **Created:** 3/11/2025 **Status:** ❌ Closed **Base:** `dev` ← **Head:** `justPerModelValves` --- ### 📝 Commits (4) - [`e3e446d`](https://github.com/open-webui/open-webui/commit/e3e446d29f44ca60b4a4502e5e9bdc8335493ac8) per model valves appear to be saving to and retrieving from the db successfully - [`c6e3271`](https://github.com/open-webui/open-webui/commit/c6e32715e356e1eae83229af083372675e362dd6) overwrite action, tool, and filter valves - [`3bc97cf`](https://github.com/open-webui/open-webui/commit/3bc97cf3fb8ee73417673fcd5590383df3924e39) formatting - [`078f025`](https://github.com/open-webui/open-webui/commit/078f025830f4769b3edad7b909de68fb22a407ef) handle empty valves ### 📊 Changes **8 files changed** (+179 additions, -11 deletions) <details> <summary>View changed files</summary> 📝 `backend/open_webui/utils/chat.py` (+6 -1) 📝 `backend/open_webui/utils/filter.py` (+11 -0) 📝 `backend/open_webui/utils/tools.py` (+12 -0) 📝 `src/lib/components/common/Valves.svelte` (+5 -5) 📝 `src/lib/components/workspace/Models/ActionsSelector.svelte` (+18 -1) 📝 `src/lib/components/workspace/Models/FiltersSelector.svelte` (+20 -1) 📝 `src/lib/components/workspace/Models/ModelEditor.svelte` (+89 -2) 📝 `src/lib/components/workspace/Models/ToolsSelector.svelte` (+18 -1) </details> ### 📄 Description # Pull Request Checklist ### Note to first-time contributors: Please open a discussion post in [Discussions](https://github.com/open-webui/open-webui/discussions) and describe your changes before submitting a pull request. **Before submitting, make sure you've checked the following:** - [x] **Target branch:** Please verify that the pull request targets the `dev` branch. - [x] **Description:** Provide a concise description of the changes made in this pull request. - [x] **Changelog:** Ensure a changelog entry following the format of [Keep a Changelog](https://keepachangelog.com/) is added at the bottom of the PR description. - [ ] **Documentation:** Have you updated relevant documentation [Open WebUI Docs](https://github.com/open-webui/docs), or other documentation sources? - [x] **Dependencies:** Are there any new dependencies? Have you updated the dependency versions in the documentation? - [x] **Testing:** Have you written and run sufficient tests for validating the changes? - [x] **Code review:** Have you performed a self-review of your code, addressing any coding standard issues and ensuring adherence to the project's coding standards? - [x] **Prefix:** To cleary categorize this pull request, prefix the pull request title, using one of the following: - **BREAKING CHANGE**: Significant changes that may affect compatibility - **build**: Changes that affect the build system or external dependencies - **ci**: Changes to our continuous integration processes or workflows - **chore**: Refactor, cleanup, or other non-functional code changes - **docs**: Documentation update or addition - **feat**: Introduces a new feature or enhancement to the codebase - **fix**: Bug fix or error correction - **i18n**: Internationalization or localization changes - **perf**: Performance improvement - **refactor**: Code restructuring for better maintainability, readability, or scalability - **style**: Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc.) - **test**: Adding missing tests or correcting existing tests - **WIP**: Work in progress, a temporary label for incomplete or ongoing work # Changelog Entry ### Description - Allows filters, actions, and tools to be reconfigured on a per-model basis. This allows the same tool/function to be re-used in different customized models while (a) maintaining per-instance default Valves and (b) allowing each individual model to use the tool/function with overridden valve values. ### Added - ☑️ **Configure function and tool valves per-model**: instance-wide valve configurations can be overridden in the model editor. ### Breaking Changes - Should be completely backwards compatible --- ### Additional Information More motivation/discussion available in #11461. Will add docs if maintainers agree to merge. ### Screenshots or Videos New user interface (uses a collapsible customization similar to others on the same page/for configuring valves elsewhere): <img width="889" alt="image" src="https://github.com/user-attachments/assets/35778b64-a476-41b4-a1a1-a0cf77e875ec" /> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2025-11-11 18:25:35 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
confirmed
confirmed issue
core
documentation
enhancement
good first issue
help wanted
non-core
pull-request
Mirrored from GitHub Pull Request
 python
question
testing wanted
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/open-webui#9555
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?