[PR #14781] [MERGED] fix: fix #14752 and add manual transcription retrieval #94629

New Issue

GiteaMirror · 2026-05-15T20:39:21-05:00

GiteaMirror commented

2026-05-15 20:39:21 -05:00

📋 Pull Request Information

Original PR: https://github.com/open-webui/open-webui/pull/14781
Author: @lucyknada
Created: 6/8/2025
Status: ✅ Merged
Merged: 6/8/2025
Merged by: @tjbck

Base: dev ← Head: patch-2

📝 Commits (1)

b0965a8 fixes #14752 and adds manual transcription option

📊 Changes

1 file changed (+28 additions, -6 deletions)

View changed files

📝 backend/open_webui/retrieval/loaders/youtube.py (+28 -6)

📄 Description

Pull Request Checklist

Target branch: Please verify that the pull request targets the dev branch.
Description: Provide a concise description of the changes made in this pull request.
Changelog: Ensure a changelog entry following the format of Keep a Changelog is added at the bottom of the PR description.
Documentation: Have you updated relevant documentation Open WebUI Docs, or other documentation sources?
Dependencies: Are there any new dependencies? Have you updated the dependency versions in the documentation?
Testing: Have you written and run sufficient tests to validate the changes?
Code review: Have you performed a self-review of your code, addressing any coding standard issues and ensuring adherence to the project's coding standards?
Prefix: To clearly categorize this pull request, prefix the pull request title using one of the following:
- BREAKING CHANGE: Significant changes that may affect compatibility
- build: Changes that affect the build system or external dependencies
- ci: Changes to our continuous integration processes or workflows
- chore: Refactor, cleanup, or other non-functional code changes
- docs: Documentation update or addition
- feat: Introduces a new feature or enhancement to the codebase
- fix: Bug fix or error correction
- i18n: Internationalization or localization changes
- perf: Performance improvement
- refactor: Code restructuring for better maintainability, readability, or scalability
- style: Changes that do not affect the meaning of the code (white space, formatting, missing semi-colons, etc.)
- test: Adding missing tests or correcting existing tests
- WIP: Work in progress, a temporary label for incomplete or ongoing work

Changelog Entry

Description

Fixes a series of cascading errors in the YouTube transcript retrieval functionality. The initial "no element found" error reported was a red herring for a chain of unhandled exceptions in the backend, including ParseError, AttributeError, and TypeError when fetching transcripts from certain videos. This change makes the YouTube video embed feature more robust by preventing backend crashes when a transcript is unavailable or invalid.

Fixed

YouTube Transcript Fetching:
- Resolved a TypeError when raising the NoTranscriptFound exception by providing the required video_id, requested_language_codes, and transcript_data arguments.
- Prevented an xml.etree.ElementTree.ParseError by wrapping the transcript.fetch() call in a try...except block to gracefully handle empty or invalid XML responses from the youtube_transcript_api.
- Fixed an AttributeError by correctly accessing the .text attribute on FetchedTranscriptSnippet objects instead of attempting to use the .get() method.

Contributor License Agreement

By submitting this pull request, I confirm that I have read and fully agree to the Contributor License Agreement (CLA), and I am providing my contributions under its terms.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/open-webui/open-webui/pull/14781 **Author:** [@lucyknada](https://github.com/lucyknada) **Created:** 6/8/2025 **Status:** ✅ Merged **Merged:** 6/8/2025 **Merged by:** [@tjbck](https://github.com/tjbck) **Base:** `dev` ← **Head:** `patch-2` --- ### 📝 Commits (1) - [`b0965a8`](https://github.com/open-webui/open-webui/commit/b0965a8184798d7ae383b6b3e155e7667de3bc82) fixes #14752 and adds manual transcription option ### 📊 Changes **1 file changed** (+28 additions, -6 deletions) <details> <summary>View changed files</summary> 📝 `backend/open_webui/retrieval/loaders/youtube.py` (+28 -6) </details> ### 📄 Description # Pull Request Checklist - [x] **Target branch:** Please verify that the pull request targets the `dev` branch. - [x] **Description:** Provide a concise description of the changes made in this pull request. - [x] **Changelog:** Ensure a changelog entry following the format of [Keep a Changelog](https://keepachangelog.com/) is added at the bottom of the PR description. - [ ] **Documentation:** Have you updated relevant documentation [Open WebUI Docs](https://github.com/open-webui/docs), or other documentation sources? - [ ] **Dependencies:** Are there any new dependencies? Have you updated the dependency versions in the documentation? - [X] **Testing:** Have you written and run sufficient tests to validate the changes? - [x] **Code review:** Have you performed a self-review of your code, addressing any coding standard issues and ensuring adherence to the project's coding standards? - [x] **Prefix:** To clearly categorize this pull request, prefix the pull request title using one of the following: - **BREAKING CHANGE**: Significant changes that may affect compatibility - **build**: Changes that affect the build system or external dependencies - **ci**: Changes to our continuous integration processes or workflows - **chore**: Refactor, cleanup, or other non-functional code changes - **docs**: Documentation update or addition - **feat**: Introduces a new feature or enhancement to the codebase - **fix**: Bug fix or error correction - **i18n**: Internationalization or localization changes - **perf**: Performance improvement - **refactor**: Code restructuring for better maintainability, readability, or scalability - **style**: Changes that do not affect the meaning of the code (white space, formatting, missing semi-colons, etc.) - **test**: Adding missing tests or correcting existing tests - **WIP**: Work in progress, a temporary label for incomplete or ongoing work # Changelog Entry ### Description - Fixes a series of cascading errors in the YouTube transcript retrieval functionality. The initial "no element found" error reported was a red herring for a chain of unhandled exceptions in the backend, including `ParseError`, `AttributeError`, and `TypeError` when fetching transcripts from certain videos. This change makes the YouTube video embed feature more robust by preventing backend crashes when a transcript is unavailable or invalid. ### Fixed - **YouTube Transcript Fetching**: - Resolved a `TypeError` when raising the `NoTranscriptFound` exception by providing the required `video_id`, `requested_language_codes`, and `transcript_data` arguments. - Prevented an `xml.etree.ElementTree.ParseError` by wrapping the `transcript.fetch()` call in a `try...except` block to gracefully handle empty or invalid XML responses from the `youtube_transcript_api`. - Fixed an `AttributeError` by correctly accessing the `.text` attribute on `FetchedTranscriptSnippet` objects instead of attempting to use the `.get()` method. --- ### Contributor License Agreement By submitting this pull request, I confirm that I have read and fully agree to the [Contributor License Agreement (CLA)](/CONTRIBUTOR_LICENSE_AGREEMENT), and I am providing my contributions under its terms. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

GiteaMirror added the pull-request label 2026-05-15 20:39:21 -05:00

GiteaMirror closed this issue

2026-05-15 20:39:25 -05:00

Sign in to join this conversation.

Branches Tags

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: github-starred/open-webui#94629