github-starred/open-webui
2
0
Fork 0
mirror of https://github.com/open-webui/open-webui.git synced 2026-07-16 14:39:31 -05:00
Code Issues 2.4k Packages Projects Releases 129 Wiki Activity

[PR #10825] [CLOSED] feat: New permission toggle to manage "Public" sharing capability #9401

New Issue
Closed
opened 2025-11-11 18:21:39 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2025-11-11 18:21:39 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/open-webui/open-webui/pull/10825
Author: @taylorwilsdon
Created: 2/26/2025
Status: ❌ Closed

Base: dev ← Head: disable_public_sharing_option

📝 Commits (10+)

  • 0d97064 Implement new permission for public sharing, apply to AccessControl.svelte, exempt administrators so that they can always share publicly
  • cdb09c3 Implement support for env var configuration
  • 93d0a4d Update users.py
  • 49fad0d Update Permissions.svelte
  • 636494c Update Permissions.svelte
  • 5f129b6 Merge branch 'dev' into disable_public_sharing_option
  • 5471d98 Update translation.json
  • 1a1f9b0 Update translation.json
  • 96048e2 Update config.py
  • e44fa7c Update config.py

📊 Changes

6 files changed (+79 additions, -15 deletions)

View changed files

📝 backend/open_webui/config.py (+5 -0)
📝 backend/open_webui/routers/users.py (+1 -0)
📝 src/lib/components/admin/Users/Groups/Permissions.svelte (+8 -0)
📝 src/lib/components/workspace/Models/ModelEditor.svelte (+5 -1)
📝 src/lib/components/workspace/common/AccessControl.svelte (+59 -14)
📝 src/lib/i18n/locales/en-US/translation.json (+1 -0)

📄 Description

Pull Request Checklist

  • Target branch: Please verify that the pull request targets the dev branch.
  • Description: Provide a concise description of the changes made in this pull request.
  • Changelog: Ensure a changelog entry following the format of Keep a Changelog is added at the bottom of the PR description.
  • Documentation: Have you updated relevant documentation Open WebUI Docs, or other documentation sources?
  • Dependencies: Are there any new dependencies? Have you updated the dependency versions in the documentation?
  • Testing: Have you written and run sufficient tests for validating the changes?
  • Code review: Have you performed a self-review of your code, addressing any coding standard issues and ensuring adherence to the project's coding standards?
  • Prefix: To cleary categorize this pull request, prefix the pull request title, using one of the following:
    • feat: Introduces a new feature or enhancement to the codebase

Changelog Entry

Description

  • Implement new permission for public sharing that can be applied to default permissions or group-level designations, allowing administrators to determine whether regular users can share newly created models Publicly or not, to avoid clogging up the models selector for other users

Added

  • New toggle in Permissions.svelte for "Public Sharing" that utilizes the existing permissions.workspace object.
  • New logic in AccessControl.svelte to disable the Public option for non-admin users whose default or Group-level permissions dictate that Public Sharing is disabled.

Additional Information

Screenshots or Videos

https://github.com/user-attachments/assets/c8907acc-38c2-4803-a4ff-a97935b01053

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/open-webui/open-webui/pull/10825 **Author:** [@taylorwilsdon](https://github.com/taylorwilsdon) **Created:** 2/26/2025 **Status:** ❌ Closed **Base:** `dev` ← **Head:** `disable_public_sharing_option` --- ### 📝 Commits (10+) - [`0d97064`](https://github.com/open-webui/open-webui/commit/0d970640ea4df61256e3053825cf31e47b22ba2f) Implement new permission for public sharing, apply to AccessControl.svelte, exempt administrators so that they can always share publicly - [`cdb09c3`](https://github.com/open-webui/open-webui/commit/cdb09c3fb37fe6eb6a6e0b4bb5d68200181f6fd2) Implement support for env var configuration - [`93d0a4d`](https://github.com/open-webui/open-webui/commit/93d0a4d789a58aba905b37787d19dce5ff5eae0e) Update users.py - [`49fad0d`](https://github.com/open-webui/open-webui/commit/49fad0d9b273a9ba87536611a87feb5c17e20eb5) Update Permissions.svelte - [`636494c`](https://github.com/open-webui/open-webui/commit/636494c012634a46d3b2f81943488ef6edad8ea3) Update Permissions.svelte - [`5f129b6`](https://github.com/open-webui/open-webui/commit/5f129b67c3153d4cc0ddb436490c448b23ae9017) Merge branch 'dev' into disable_public_sharing_option - [`5471d98`](https://github.com/open-webui/open-webui/commit/5471d98bf0d14c6a67cec61e18748911090b1cb2) Update translation.json - [`1a1f9b0`](https://github.com/open-webui/open-webui/commit/1a1f9b0a424dc8a64a8c3bb1fd093dd28b736668) Update translation.json - [`96048e2`](https://github.com/open-webui/open-webui/commit/96048e2f02e1a32ffec13ad92a8acf8aae20454a) Update config.py - [`e44fa7c`](https://github.com/open-webui/open-webui/commit/e44fa7ca918e3e34d7838d0578826969e50dabfa) Update config.py ### 📊 Changes **6 files changed** (+79 additions, -15 deletions) <details> <summary>View changed files</summary> 📝 `backend/open_webui/config.py` (+5 -0) 📝 `backend/open_webui/routers/users.py` (+1 -0) 📝 `src/lib/components/admin/Users/Groups/Permissions.svelte` (+8 -0) 📝 `src/lib/components/workspace/Models/ModelEditor.svelte` (+5 -1) 📝 `src/lib/components/workspace/common/AccessControl.svelte` (+59 -14) 📝 `src/lib/i18n/locales/en-US/translation.json` (+1 -0) </details> ### 📄 Description # Pull Request Checklist - [x] **Target branch:** Please verify that the pull request targets the `dev` branch. - [x] **Description:** Provide a concise description of the changes made in this pull request. - [x] **Changelog:** Ensure a changelog entry following the format of [Keep a Changelog](https://keepachangelog.com/) is added at the bottom of the PR description. - [x] **Documentation:** Have you updated relevant documentation [Open WebUI Docs](https://github.com/open-webui/docs), or other documentation sources? - Matching documentation PR @ https://github.com/open-webui/docs/pull/421 - [x] **Dependencies:** Are there any new dependencies? Have you updated the dependency versions in the documentation? - [x] **Testing:** Have you written and run sufficient tests for validating the changes? - [x] **Code review:** Have you performed a self-review of your code, addressing any coding standard issues and ensuring adherence to the project's coding standards? - [x] **Prefix:** To cleary categorize this pull request, prefix the pull request title, using one of the following: - **feat**: Introduces a new feature or enhancement to the codebase # Changelog Entry ### Description - Implement new permission for public sharing that can be applied to default permissions or group-level designations, allowing administrators to determine whether regular users can share newly created models Publicly or not, to avoid clogging up the models selector for other users ### Added - New toggle in `Permissions.svelte` for "Public Sharing" that utilizes the existing `permissions.workspace` object. - New logic in `AccessControl.svelte` to disable the Public option for non-admin users whose default or Group-level permissions dictate that Public Sharing is disabled. ### Additional Information - Discussion: - https://github.com/open-webui/open-webui/discussions/10824 ### Screenshots or Videos https://github.com/user-attachments/assets/c8907acc-38c2-4803-a4ff-a97935b01053 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2025-11-11 18:21:39 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
confirmed
confirmed issue
core
documentation
enhancement
good first issue
help wanted
non-core
pull-request
Mirrored from GitHub Pull Request
 python
question
testing wanted
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/open-webui#9401
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?