[PR #12507] [MERGED] fix: fix web results all getting the same source id when using embedding and retrieval #93973

New Issue

2026-05-15T19:55:49-05:00

GiteaMirror commented

2026-05-15 19:55:49 -05:00

📋 Pull Request Information

Original PR: https://github.com/open-webui/open-webui/pull/12507
Author: @Ithanil
Created: 4/6/2025
Status: ✅ Merged
Merged: 4/6/2025
Merged by: @tjbck

Base: dev ← Head: fix_web_result_collection_source_ids

📝 Commits (1)

4476060 fix web results all getting the same source id when using embedding and retrieval

📊 Changes

2 files changed (+27 additions, -23 deletions)

View changed files

📝 backend/open_webui/routers/retrieval.py (+17 -14)
📝 backend/open_webui/utils/middleware.py (+10 -9)

📄 Description

Pull Request Checklist

Note to first-time contributors: Please open a discussion post in Discussions and describe your changes before submitting a pull request.

Before submitting, make sure you've checked the following:

Target branch: Please verify that the pull request targets the dev branch.
Description: Provide a concise description of the changes made in this pull request.
Changelog: Ensure a changelog entry following the format of Keep a Changelog is added at the bottom of the PR description.
Documentation: Have you updated relevant documentation Open WebUI Docs, or other documentation sources?
Dependencies: Are there any new dependencies? Have you updated the dependency versions in the documentation?
Testing: Have you written and run sufficient tests to validate the changes?
Code review: Have you performed a self-review of your code, addressing any coding standard issues and ensuring adherence to the project's coding standards?
Prefix: To clearly categorize this pull request, prefix the pull request title using one of the following:
- BREAKING CHANGE: Significant changes that may affect compatibility
- build: Changes that affect the build system or external dependencies
- ci: Changes to our continuous integration processes or workflows
- chore: Refactor, cleanup, or other non-functional code changes
- docs: Documentation update or addition
- feat: Introduces a new feature or enhancement to the codebase
- fix: Bug fix or error correction
- i18n: Internationalization or localization changes
- perf: Performance improvement
- refactor: Code restructuring for better maintainability, readability, or scalability
- style: Changes that do not affect the meaning of the code (white space, formatting, missing semi-colons, etc.)
- test: Adding missing tests or correcting existing tests
- WIP: Work in progress, a temporary label for incomplete or ongoing work

Changelog Entry

Description

All web search results per search query were assigned the same source id before, despite containing content from different URLs. Thus, URLs wouldn't be cited correctly.

This PR fixes the source id assignment for the case of web search with embedding&retrieval, making sure every URL gets its own collection and thus source id.

Fixed

Return one result file and collection per URL in chat_web_search_handler

Additional Information

This fixes https://github.com/open-webui/open-webui/discussions/11205 for web search (together with https://github.com/open-webui/open-webui/pull/12506). I think further fixes are needed for RAG with knowledge bases and potentially also tool results (https://github.com/open-webui/open-webui/discussions/10595). The case of regular file uploads within the chat is fine.

It works in conjunction with additional sources, e.g. from file uploads, or multiple search queries.

Alternatives considered

https://github.com/open-webui/open-webui/discussions/11205#discussioncomment-12684414 , but I think that would assign a different source id to every chunk in embed&retrieval mode.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/open-webui/open-webui/pull/12507 **Author:** [@Ithanil](https://github.com/Ithanil) **Created:** 4/6/2025 **Status:** ✅ Merged **Merged:** 4/6/2025 **Merged by:** [@tjbck](https://github.com/tjbck) **Base:** `dev` ← **Head:** `fix_web_result_collection_source_ids` --- ### 📝 Commits (1) - [`4476060`](https://github.com/open-webui/open-webui/commit/447606004429074e127ff3d7989a1b22c53dcba9) fix web results all getting the same source id when using embedding and retrieval ### 📊 Changes **2 files changed** (+27 additions, -23 deletions) <details> <summary>View changed files</summary> 📝 `backend/open_webui/routers/retrieval.py` (+17 -14) 📝 `backend/open_webui/utils/middleware.py` (+10 -9) </details> ### 📄 Description # Pull Request Checklist ### Note to first-time contributors: Please open a discussion post in [Discussions](https://github.com/open-webui/open-webui/discussions) and describe your changes before submitting a pull request. **Before submitting, make sure you've checked the following:** - [x] **Target branch:** Please verify that the pull request targets the `dev` branch. - [x] **Description:** Provide a concise description of the changes made in this pull request. - [x] **Changelog:** Ensure a changelog entry following the format of [Keep a Changelog](https://keepachangelog.com/) is added at the bottom of the PR description. - [x] **Documentation:** Have you updated relevant documentation [Open WebUI Docs](https://github.com/open-webui/docs), or other documentation sources? - [x] **Dependencies:** Are there any new dependencies? Have you updated the dependency versions in the documentation? - [x] **Testing:** Have you written and run sufficient tests to validate the changes? - [x] **Code review:** Have you performed a self-review of your code, addressing any coding standard issues and ensuring adherence to the project's coding standards? - [x] **Prefix:** To clearly categorize this pull request, prefix the pull request title using one of the following: - **BREAKING CHANGE**: Significant changes that may affect compatibility - **build**: Changes that affect the build system or external dependencies - **ci**: Changes to our continuous integration processes or workflows - **chore**: Refactor, cleanup, or other non-functional code changes - **docs**: Documentation update or addition - **feat**: Introduces a new feature or enhancement to the codebase - **fix**: Bug fix or error correction - **i18n**: Internationalization or localization changes - **perf**: Performance improvement - **refactor**: Code restructuring for better maintainability, readability, or scalability - **style**: Changes that do not affect the meaning of the code (white space, formatting, missing semi-colons, etc.) - **test**: Adding missing tests or correcting existing tests - **WIP**: Work in progress, a temporary label for incomplete or ongoing work # Changelog Entry ### Description All web search results per search query were assigned the same source id before, despite containing content from different URLs. Thus, URLs wouldn't be cited correctly. This PR fixes the source id assignment for the case of web search with embedding&retrieval, making sure every URL gets its own collection and thus source id. ### Fixed - Return one result file and collection per URL in chat_web_search_handler --- ### Additional Information This fixes https://github.com/open-webui/open-webui/discussions/11205 for web search (together with https://github.com/open-webui/open-webui/pull/12506). I think further fixes are needed for RAG with knowledge bases and potentially also tool results (https://github.com/open-webui/open-webui/discussions/10595). The case of regular file uploads within the chat is fine. It works in conjunction with additional sources, e.g. from file uploads, or multiple search queries. ### Alternatives considered https://github.com/open-webui/open-webui/discussions/11205#discussioncomment-12684414 , but I think that would assign a different source id to every chunk in embed&retrieval mode. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

GiteaMirror added the pull-request label 2026-05-15 19:55:49 -05:00

GiteaMirror closed this issue

2026-05-15 19:55:51 -05:00

Sign in to join this conversation.

Branches Tags

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: github-starred/open-webui#93973