[PR #10417] [MERGED] build: load the proxy from the system env for Pyodide to download packages #9323

New Issue

GiteaMirror · 2025-11-11T18:19:49-06:00

GiteaMirror commented

2025-11-11 18:19:49 -06:00

📋 Pull Request Information

Original PR: https://github.com/open-webui/open-webui/pull/10417
Author: @hangxingliu
Created: 2/20/2025
Status: ✅ Merged
Merged: 2/20/2025
Merged by: @tjbck

Base: dev ← Head: liu/fix-build-proxy

📝 Commits (1)

3ae7302 build: load the proxy from the system env for Pyodide to download packages #6234

📊 Changes

3 files changed (+43 additions, -0 deletions)

View changed files

📝 package-lock.json (+10 -0)
📝 package.json (+1 -0)
📝 scripts/prepare-pyodide.js (+32 -0)

📄 Description

Pull Request Checklist

Note to first-time contributors: Please open a discussion post in Discussions and describe your changes before submitting a pull request.

Before submitting, make sure you've checked the following:

Target branch: Please verify that the pull request targets the dev branch.
Description: Provide a concise description of the changes made in this pull request.
Changelog: Ensure a changelog entry following the format of Keep a Changelog is added at the bottom of the PR description.
Documentation: Have you updated relevant documentation Open WebUI Docs, or other documentation sources?
Dependencies: Are there any new dependencies? Have you updated the dependency versions in the documentation?
Testing: Have you written and run sufficient tests for validating the changes?
Code review: Have you performed a self-review of your code, addressing any coding standard issues and ensuring adherence to the project's coding standards?
Prefix: To cleary categorize this pull request, prefix the pull request title, using one of the following:
- BREAKING CHANGE: Significant changes that may affect compatibility
- build: Changes that affect the build system or external dependencies
- ci: Changes to our continuous integration processes or workflows
- chore: Refactor, cleanup, or other non-functional code changes
- docs: Documentation update or addition
- feat: Introduces a new feature or enhancement to the codebase
- fix: Bug fix or error correction
- i18n: Internationalization or localization changes
- perf: Performance improvement
- refactor: Code restructuring for better maintainability, readability, or scalability
- style: Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc.)
- test: Adding missing tests or correcting existing tests
- WIP: Work in progress, a temporary label for incomplete or ongoing work

Changelog Entry

Description

Building this project will fail in a network environment that could only access internet through a specified network proxy. Because there is a step in npm run build doesn't respect network proxy configs in system environment variables just like what people were discussing in the post #6234 .

Fixed

A function for initializing the global HTTP/HTTPS request agent has been added into the script scripts/prepare-pyodide.js. This function will only initialize this global request agent when there are any available proxy configs in environment variables.

To implement this feature, an Node.js official package named undici needs to be added as a devDependencies.

Additional Information

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/open-webui/open-webui/pull/10417 **Author:** [@hangxingliu](https://github.com/hangxingliu) **Created:** 2/20/2025 **Status:** ✅ Merged **Merged:** 2/20/2025 **Merged by:** [@tjbck](https://github.com/tjbck) **Base:** `dev` ← **Head:** `liu/fix-build-proxy` --- ### 📝 Commits (1) - [`3ae7302`](https://github.com/open-webui/open-webui/commit/3ae7302f7b9ed57b1ce899e3e931c1862fb1bad2) build: load the proxy from the system env for Pyodide to download packages #6234 ### 📊 Changes **3 files changed** (+43 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `package-lock.json` (+10 -0) 📝 `package.json` (+1 -0) 📝 `scripts/prepare-pyodide.js` (+32 -0) </details> ### 📄 Description # Pull Request Checklist ### Note to first-time contributors: Please open a discussion post in [Discussions](https://github.com/open-webui/open-webui/discussions) and describe your changes before submitting a pull request. **Before submitting, make sure you've checked the following:** - [x] **Target branch:** Please verify that the pull request targets the `dev` branch. - [x] **Description:** Provide a concise description of the changes made in this pull request. - [x] **Changelog:** Ensure a changelog entry following the format of [Keep a Changelog](https://keepachangelog.com/) is added at the bottom of the PR description. - [x] **Documentation:** Have you updated relevant documentation [Open WebUI Docs](https://github.com/open-webui/docs), or other documentation sources? - [x] **Dependencies:** Are there any new dependencies? Have you updated the dependency versions in the documentation? - [x] **Testing:** Have you written and run sufficient tests for validating the changes? - [x] **Code review:** Have you performed a self-review of your code, addressing any coding standard issues and ensuring adherence to the project's coding standards? - [x] **Prefix:** To cleary categorize this pull request, prefix the pull request title, using one of the following: - **BREAKING CHANGE**: Significant changes that may affect compatibility - **build**: Changes that affect the build system or external dependencies - **ci**: Changes to our continuous integration processes or workflows - **chore**: Refactor, cleanup, or other non-functional code changes - **docs**: Documentation update or addition - **feat**: Introduces a new feature or enhancement to the codebase - **fix**: Bug fix or error correction - **i18n**: Internationalization or localization changes - **perf**: Performance improvement - **refactor**: Code restructuring for better maintainability, readability, or scalability - **style**: Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc.) - **test**: Adding missing tests or correcting existing tests - **WIP**: Work in progress, a temporary label for incomplete or ongoing work # Changelog Entry ### Description Building this project will fail in a network environment that could only access internet through a specified network proxy. Because there is a step in `npm run build` doesn't respect network proxy configs in system environment variables just like what people were discussing in the post #6234 . ### Fixed A function for initializing the global HTTP/HTTPS request agent has been added into the script `scripts/prepare-pyodide.js`. This function will only initialize this global request agent when there are any available proxy configs in environment variables. To implement this feature, an Node.js official package named [undici](https://github.com/nodejs/undici) needs to be added as a `devDependencies`. --- ### Additional Information - https://github.com/open-webui/open-webui/discussions/6234 - https://github.com/pyodide/pyodide/issues/4891 - https://stackoverflow.com/questions/72306101/make-a-request-in-native-fetch-with-proxy-in-nodejs-18 - https://about.gitlab.com/blog/2021/01/27/we-need-to-talk-no-proxy/ --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

GiteaMirror added the pull-request label 2025-11-11 18:19:49 -06:00

GiteaMirror closed this issue

2025-11-11 18:19:50 -06:00

Sign in to join this conversation.

Branches Tags

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: github-starred/open-webui#9323