[PR #10285] [MERGED] fix: Fixed an issue with clearing application cookies during OAuth signout #9283

New Issue

GiteaMirror · 2025-11-11T18:18:37-06:00

GiteaMirror commented

2025-11-11 18:18:37 -06:00

📋 Pull Request Information

Original PR: https://github.com/open-webui/open-webui/pull/10285
Author: @the-c0d3br34k3r
Created: 2/18/2025
Status: ✅ Merged
Merged: 2/19/2025
Merged by: @tjbck

Base: dev ← Head: issue8885_auth

📝 Commits (1)

6c6be5d Fixed an issue with clearing application cookies during OAuth signout

📊 Changes

1 file changed (+1 additions, -0 deletions)

View changed files

📝 backend/open_webui/routers/auths.py (+1 -0)

📄 Description

Pull Request Checklist

Discussion: https://github.com/open-webui/open-webui/discussions/9679 and #8885.

Before submitting, make sure you've checked the following:

Target branch: Please verify that the pull request targets the dev branch.
Description: Provide a concise description of the changes made in this pull request.
Changelog: Ensure a changelog entry following the format of Keep a Changelog is added at the bottom of the PR description.
Documentation: Have you updated relevant documentation Open WebUI Docs, or other documentation sources?
Dependencies: Are there any new dependencies? Have you updated the dependency versions in the documentation?
Testing: Have you written and run sufficient tests for validating the changes? - No existing tests for OAuth flow. This needs to be addressed in a separate ticket if needed.
Code review: Have you performed a self-review of your code, addressing any coding standard issues and ensuring adherence to the project's coding standards?
Prefix: To cleary categorize this pull request, prefix the pull request title, using one of the following:
- BREAKING CHANGE: Significant changes that may affect compatibility
- build: Changes that affect the build system or external dependencies
- ci: Changes to our continuous integration processes or workflows
- chore: Refactor, cleanup, or other non-functional code changes
- docs: Documentation update or addition
- feat: Introduces a new feature or enhancement to the codebase
- fix: Bug fix or error correction
- i18n: Internationalization or localization changes
- perf: Performance improvement
- refactor: Code restructuring for better maintainability, readability, or scalability
- style: Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc.)
- test: Adding missing tests or correcting existing tests
- WIP: Work in progress, a temporary label for incomplete or ongoing work

Changelog Entry

During the OAuth signout flow, although the token and oauth_id_token cookies were marked for deletion, a new RedirectResponse is created and returned. This does not contain the header info from the he Response object used to mark the cookies to be deleted. Hence the cookies remained. Fixed this by re-using the headers from the other Response object.

Fixed

[PR #7640] [CLOSED] fix: remove blur effect causing unwanted shadows in dark mode navbar (#8885)

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/open-webui/open-webui/pull/10285 **Author:** [@the-c0d3br34k3r](https://github.com/the-c0d3br34k3r) **Created:** 2/18/2025 **Status:** ✅ Merged **Merged:** 2/19/2025 **Merged by:** [@tjbck](https://github.com/tjbck) **Base:** `dev` ← **Head:** `issue8885_auth` --- ### 📝 Commits (1) - [`6c6be5d`](https://github.com/open-webui/open-webui/commit/6c6be5de886f07c64e170b70865b56718d6809f5) Fixed an issue with clearing application cookies during OAuth signout ### 📊 Changes **1 file changed** (+1 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `backend/open_webui/routers/auths.py` (+1 -0) </details> ### 📄 Description # Pull Request Checklist Discussion: https://github.com/open-webui/open-webui/discussions/9679 and #8885. **Before submitting, make sure you've checked the following:** - [x] **Target branch:** Please verify that the pull request targets the `dev` branch. - [x] **Description:** Provide a concise description of the changes made in this pull request. - [x] **Changelog:** Ensure a changelog entry following the format of [Keep a Changelog](https://keepachangelog.com/) is added at the bottom of the PR description. - [ ] **Documentation:** Have you updated relevant documentation [Open WebUI Docs](https://github.com/open-webui/docs), or other documentation sources? - [ ] **Dependencies:** Are there any new dependencies? Have you updated the dependency versions in the documentation? - [ ] **Testing:** Have you written and run sufficient tests for validating the changes? - No existing tests for OAuth flow. This needs to be addressed in a separate ticket if needed. - [ ] **Code review:** Have you performed a self-review of your code, addressing any coding standard issues and ensuring adherence to the project's coding standards? - [x] **Prefix:** To cleary categorize this pull request, prefix the pull request title, using one of the following: - **BREAKING CHANGE**: Significant changes that may affect compatibility - **build**: Changes that affect the build system or external dependencies - **ci**: Changes to our continuous integration processes or workflows - **chore**: Refactor, cleanup, or other non-functional code changes - **docs**: Documentation update or addition - **feat**: Introduces a new feature or enhancement to the codebase - **fix**: Bug fix or error correction - **i18n**: Internationalization or localization changes - **perf**: Performance improvement - **refactor**: Code restructuring for better maintainability, readability, or scalability - **style**: Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc.) - **test**: Adding missing tests or correcting existing tests - **WIP**: Work in progress, a temporary label for incomplete or ongoing work # Changelog Entry During the OAuth signout flow, although the `token` and `oauth_id_token` cookies were marked for deletion, a new RedirectResponse is created and returned. This does not contain the header info from the he Response object used to mark the cookies to be deleted. Hence the cookies remained. Fixed this by re-using the headers from the other Response object. ### Fixed - #8885 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

GiteaMirror added the pull-request label 2025-11-11 18:18:37 -06:00

GiteaMirror closed this issue

2025-11-11 18:18:37 -06:00

GiteaMirror referenced this issue

2026-04-19 21:38:32 -05:00

[GH-ISSUE #9283] [Bug]DuckDuckGo Web Search is broken #15448

GiteaMirror referenced this issue

2026-04-19 21:40:44 -05:00

[GH-ISSUE #9404] Web search is not working in 0.5.9 Search returns SyntaxError: Unexpected token '<', "<html> <h"... is not valid JSON #15491

GiteaMirror referenced this issue

2026-04-25 05:05:16 -05:00

[GH-ISSUE #9283] [Bug]DuckDuckGo Web Search is broken #30976