[PR #10268] [MERGED] feat: citations disabled model to exclude source citations in messages #9279

Closed
opened 2025-11-11 18:18:31 -06:00 by GiteaMirror · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/open-webui/open-webui/pull/10268
Author: @hurxxxx
Created: 2/18/2025
Status: Merged
Merged: 2/19/2025
Merged by: @tjbck

Base: devHead: feat/hide-citations-in-message


📝 Commits (2)

  • 9d06e3b feat: chat responses using the citations-disabled model to exclude source citations
  • 84af508 Merge branch 'dev' into feat/hide-citations-in-message

📊 Changes

2 files changed (+17 additions, -10 deletions)

View changed files

📝 src/lib/components/chat/Messages/ContentRenderer.svelte (+5 -0)
📝 src/lib/components/chat/Messages/Markdown/Source.svelte (+12 -10)

📄 Description

Pull Request Checklist

Note to first-time contributors: Please open a discussion post in Discussions and describe your changes before submitting a pull request.

Before submitting, make sure you've checked the following:

  • Target branch: Please verify that the pull request targets the dev branch.
  • Description: Provide a concise description of the changes made in this pull request.
  • Changelog: Ensure a changelog entry following the format of Keep a Changelog is added at the bottom of the PR description.
  • Documentation: Have you updated relevant documentation Open WebUI Docs, or other documentation sources?
  • Dependencies: Are there any new dependencies? Have you updated the dependency versions in the documentation?
  • Testing: Have you written and run sufficient tests for validating the changes?
  • Code review: Have you performed a self-review of your code, addressing any coding standard issues and ensuring adherence to the project's coding standards?
  • Prefix: To cleary categorize this pull request, prefix the pull request title, using one of the following:
    • BREAKING CHANGE: Significant changes that may affect compatibility
    • build: Changes that affect the build system or external dependencies
    • ci: Changes to our continuous integration processes or workflows
    • chore: Refactor, cleanup, or other non-functional code changes
    • docs: Documentation update or addition
    • feat: Introduces a new feature or enhancement to the codebase
    • fix: Bug fix or error correction
    • i18n: Internationalization or localization changes
    • perf: Performance improvement
    • refactor: Code restructuring for better maintainability, readability, or scalability
    • style: Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc.)
    • test: Adding missing tests or correcting existing tests
    • WIP: Work in progress, a temporary label for incomplete or ongoing work

Changelog Entry

Description

  • Citations in messages are being exposed in models with 'Citations' disabled.

Changed

  • Set the source to 'N/A' for models with 'Citations' disabled and prevent rendering 'N/A' in the Source.svelte component.

Screenshots or Videos

  • Source Display Screen
    OUI-01

  • Citations are disabled, but the source filename is still displayed in the message.
    OUI-02

  • Updated Screen After Changes
    OUI-03


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/open-webui/open-webui/pull/10268 **Author:** [@hurxxxx](https://github.com/hurxxxx) **Created:** 2/18/2025 **Status:** ✅ Merged **Merged:** 2/19/2025 **Merged by:** [@tjbck](https://github.com/tjbck) **Base:** `dev` ← **Head:** `feat/hide-citations-in-message` --- ### 📝 Commits (2) - [`9d06e3b`](https://github.com/open-webui/open-webui/commit/9d06e3b2cd1da7eb66740039011cd4df3a25ca0b) feat: chat responses using the citations-disabled model to exclude source citations - [`84af508`](https://github.com/open-webui/open-webui/commit/84af508525b911c260b88c9c6ddd56107c6b5860) Merge branch 'dev' into feat/hide-citations-in-message ### 📊 Changes **2 files changed** (+17 additions, -10 deletions) <details> <summary>View changed files</summary> 📝 `src/lib/components/chat/Messages/ContentRenderer.svelte` (+5 -0) 📝 `src/lib/components/chat/Messages/Markdown/Source.svelte` (+12 -10) </details> ### 📄 Description # Pull Request Checklist ### Note to first-time contributors: Please open a discussion post in [Discussions](https://github.com/open-webui/open-webui/discussions) and describe your changes before submitting a pull request. **Before submitting, make sure you've checked the following:** - [x] **Target branch:** Please verify that the pull request targets the `dev` branch. - [x] **Description:** Provide a concise description of the changes made in this pull request. - [x] **Changelog:** Ensure a changelog entry following the format of [Keep a Changelog](https://keepachangelog.com/) is added at the bottom of the PR description. - [ ] **Documentation:** Have you updated relevant documentation [Open WebUI Docs](https://github.com/open-webui/docs), or other documentation sources? - [ ] **Dependencies:** Are there any new dependencies? Have you updated the dependency versions in the documentation? - [x] **Testing:** Have you written and run sufficient tests for validating the changes? - [x] **Code review:** Have you performed a self-review of your code, addressing any coding standard issues and ensuring adherence to the project's coding standards? - [x] **Prefix:** To cleary categorize this pull request, prefix the pull request title, using one of the following: - **BREAKING CHANGE**: Significant changes that may affect compatibility - **build**: Changes that affect the build system or external dependencies - **ci**: Changes to our continuous integration processes or workflows - **chore**: Refactor, cleanup, or other non-functional code changes - **docs**: Documentation update or addition - **feat**: Introduces a new feature or enhancement to the codebase - **fix**: Bug fix or error correction - **i18n**: Internationalization or localization changes - **perf**: Performance improvement - **refactor**: Code restructuring for better maintainability, readability, or scalability - **style**: Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc.) - **test**: Adding missing tests or correcting existing tests - **WIP**: Work in progress, a temporary label for incomplete or ongoing work # Changelog Entry ### Description - Citations in messages are being exposed in models with 'Citations' disabled. ### Changed - Set the source to 'N/A' for models with 'Citations' disabled and prevent rendering 'N/A' in the Source.svelte component. --- ### Screenshots or Videos - Source Display Screen ![OUI-01](https://github.com/user-attachments/assets/2669a024-7543-467f-beab-87f023015996) - Citations are disabled, but the source filename is still displayed in the message. ![OUI-02](https://github.com/user-attachments/assets/ca89b32e-5b80-4526-99b0-d395ce16e8c8) - Updated Screen After Changes ![OUI-03](https://github.com/user-attachments/assets/4149178c-b8ca-40cf-91a4-b572247dc8e7) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2025-11-11 18:18:31 -06:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/open-webui#9279